| Message ID | 20170704193133.87092-13-sjg@chromium.org |
|---|---|
| State | Accepted |
| Delegated to: | Jaehoon Chung |
| Headers | show |
Hi Simon, On Wed, Jul 5, 2017 at 3:31 AM, Simon Glass <sjg@chromium.org> wrote: > The 'scsi scan' function handles this at present and we don't want to > do it twice. With driver model we want to adopt U-Boot's lazy init > approach where possible. > > Drop the automatic scan when probing a SCSI bus. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > Changes in v2: None > > drivers/ata/ahci.c | 5 ----- > 1 file changed, 5 deletions(-) > This is a duplicated patch of http://patchwork.ozlabs.org/patch/777313/ BTW: when will plan to apply that series? Regards, Bin
Hi Bin, On 22 July 2017 at 22:42, Bin Meng <bmeng.cn@gmail.com> wrote: > Hi Simon, > > On Wed, Jul 5, 2017 at 3:31 AM, Simon Glass <sjg@chromium.org> wrote: >> The 'scsi scan' function handles this at present and we don't want to >> do it twice. With driver model we want to adopt U-Boot's lazy init >> approach where possible. >> >> Drop the automatic scan when probing a SCSI bus. >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> --- >> >> Changes in v2: None >> >> drivers/ata/ahci.c | 5 ----- >> 1 file changed, 5 deletions(-) >> > > This is a duplicated patch of http://patchwork.ozlabs.org/patch/777313/ > > BTW: when will plan to apply that series? Hopefully tomorrow. Have been waiting for the tegra livetree series but it is tested now. Regards, Simon
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 066524758a..5e4df19386 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -1181,11 +1181,6 @@ int ahci_probe_scsi(struct udevice *ahci_dev, ulong base) if (ret) return ret; - debug("Scanning %s\n", dev->name); - ret = scsi_scan_dev(dev, true); - if (ret) - return ret; - return 0; }
The 'scsi scan' function handles this at present and we don't want to do it twice. With driver model we want to adopt U-Boot's lazy init approach where possible. Drop the automatic scan when probing a SCSI bus. Signed-off-by: Simon Glass <sjg@chromium.org> --- Changes in v2: None drivers/ata/ahci.c | 5 ----- 1 file changed, 5 deletions(-)