| Message ID | 20170218184640.30635-3-heiko@sntech.de |
|---|---|
| State | Accepted |
| Commit | 6496498a626dbde4d0ed96406e4efee9ff2ab0c0 |
| Delegated to: | Simon Glass |
| Headers | show |
On 18 February 2017 at 11:46, Heiko Stuebner <heiko@sntech.de> wrote: > The gpll and cpll init values are only used in rk_clk_init in the SPL > and therefore produce compile time warnings in regular uboot builds. > Fix that with an #ifdef. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > --- > drivers/clk/rockchip/clk_rk3288.c | 2 ++ > 1 file changed, 2 insertions(+) Acked-by: Simon Glass <sjg@chromium.org>
On 21 February 2017 at 11:08, Simon Glass <sjg@chromium.org> wrote: > On 18 February 2017 at 11:46, Heiko Stuebner <heiko@sntech.de> wrote: >> The gpll and cpll init values are only used in rk_clk_init in the SPL >> and therefore produce compile time warnings in regular uboot builds. >> Fix that with an #ifdef. >> >> Signed-off-by: Heiko Stuebner <heiko@sntech.de> >> --- >> drivers/clk/rockchip/clk_rk3288.c | 2 ++ >> 1 file changed, 2 insertions(+) > > Acked-by: Simon Glass <sjg@chromium.org> Applied to u-boot-rockchip, thanks!
diff --git a/drivers/clk/rockchip/clk_rk3288.c b/drivers/clk/rockchip/clk_rk3288.c index d15504c3aa..78356766a7 100644 --- a/drivers/clk/rockchip/clk_rk3288.c +++ b/drivers/clk/rockchip/clk_rk3288.c @@ -131,8 +131,10 @@ enum { /* Keep divisors as low as possible to reduce jitter and power usage */ static const struct pll_div apll_init_cfg = PLL_DIVISORS(APLL_HZ, 1, 1); +#ifdef CONFIG_SPL_BUILD static const struct pll_div gpll_init_cfg = PLL_DIVISORS(GPLL_HZ, 2, 2); static const struct pll_div cpll_init_cfg = PLL_DIVISORS(CPLL_HZ, 1, 2); +#endif static int rkclk_set_pll(struct rk3288_cru *cru, enum rk_clk_id clk_id, const struct pll_div *div)
The gpll and cpll init values are only used in rk_clk_init in the SPL and therefore produce compile time warnings in regular uboot builds. Fix that with an #ifdef. Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- drivers/clk/rockchip/clk_rk3288.c | 2 ++ 1 file changed, 2 insertions(+)