| Message ID | 20161006143401.12012-6-antoine.tenart@free-electrons.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
On 10/06/2016 08:33 AM, Antoine Tenart wrote: > Select the newly introduced ARM_GIC option to the relevant configuration > which also have a psci implementation. > diff --git a/arch/arm/mach-tegra/tegra124/Kconfig b/arch/arm/mach-tegra/tegra124/Kconfig > config TARGET_JETSON_TK1 > bool "NVIDIA Tegra124 Jetson TK1 board" > + select ARM_GIC > select CPU_V7_HAS_NONSEC > select CPU_V7_HAS_VIRT > select ARCH_SUPPORT_PSCI > > config TARGET_CEI_TK1_SOM > bool "Colorado Engineering Inc Tegra124 TK1-som board" > + select ARM_GIC > select CPU_V7_HAS_NONSEC if !SPL_BUILD > select CPU_V7_HAS_VIRT if !SPL_BUILD > help This isn't correct; all Tegra variants have an ARM GIC; it's not board-specific. Shouldn't CONFIG_TEGRA or CONFIG_TEGRA_COMMON select ARM_GIC?
Hi Stephen, On Thu, Oct 06, 2016 at 10:15:06AM -0600, Stephen Warren wrote: > On 10/06/2016 08:33 AM, Antoine Tenart wrote: > >Select the newly introduced ARM_GIC option to the relevant configuration > >which also have a psci implementation. > > >diff --git a/arch/arm/mach-tegra/tegra124/Kconfig b/arch/arm/mach-tegra/tegra124/Kconfig > > > config TARGET_JETSON_TK1 > > bool "NVIDIA Tegra124 Jetson TK1 board" > >+ select ARM_GIC > > select CPU_V7_HAS_NONSEC > > select CPU_V7_HAS_VIRT > > select ARCH_SUPPORT_PSCI > > > > config TARGET_CEI_TK1_SOM > > bool "Colorado Engineering Inc Tegra124 TK1-som board" > >+ select ARM_GIC > > select CPU_V7_HAS_NONSEC if !SPL_BUILD > > select CPU_V7_HAS_VIRT if !SPL_BUILD > > help > > This isn't correct; all Tegra variants have an ARM GIC; it's not > board-specific. Shouldn't CONFIG_TEGRA or CONFIG_TEGRA_COMMON select > ARM_GIC? I focused on adding ARM_GIC for targets using PSCI, but I was hopping for comments like this one :) I'll move the ARM_GIC selection to CONFIG_TEGRA or CONFIG_TEGRA_COMMON then. Thanks! Antoine
diff --git a/arch/arm/mach-tegra/tegra124/Kconfig b/arch/arm/mach-tegra/tegra124/Kconfig index df7746228386..41d75bd2f321 100644 --- a/arch/arm/mach-tegra/tegra124/Kconfig +++ b/arch/arm/mach-tegra/tegra124/Kconfig @@ -6,12 +6,14 @@ choice config TARGET_JETSON_TK1 bool "NVIDIA Tegra124 Jetson TK1 board" + select ARM_GIC select CPU_V7_HAS_NONSEC select CPU_V7_HAS_VIRT select ARCH_SUPPORT_PSCI config TARGET_CEI_TK1_SOM bool "Colorado Engineering Inc Tegra124 TK1-som board" + select ARM_GIC select CPU_V7_HAS_NONSEC if !SPL_BUILD select CPU_V7_HAS_VIRT if !SPL_BUILD help
Select the newly introduced ARM_GIC option to the relevant configuration which also have a psci implementation. Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> --- arch/arm/mach-tegra/tegra124/Kconfig | 2 ++ 1 file changed, 2 insertions(+)