| Message ID | 1570787542-40896-9-git-send-email-ley.foon.tan@intel.com |
|---|---|
| State | Superseded |
| Delegated to: | Simon Goldschmidt |
| Headers | show |
| Series | Add Intel Agilex SoC support | expand |
Am 11.10.2019 um 11:52 schrieb Ley Foon Tan: > CLKMGR_INTOSC_HZ should be 400MHz, instead of 460MHz. Having this in a separate patch is clearly better. > > Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com> > --- > arch/arm/mach-socfpga/include/mach/clock_manager_soc64.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-socfpga/include/mach/clock_manager_soc64.h b/arch/arm/mach-socfpga/include/mach/clock_manager_soc64.h > index 3b4bb62ca5..1a134b89ba 100644 > --- a/arch/arm/mach-socfpga/include/mach/clock_manager_soc64.h > +++ b/arch/arm/mach-socfpga/include/mach/clock_manager_soc64.h > @@ -14,7 +14,7 @@ const unsigned int cm_get_intosc_clk_hz(void); > const unsigned int cm_get_fpga_clk_hz(void); > > #define CLKMGR_EOSC1_HZ 25000000 > -#define CLKMGR_INTOSC_HZ 460000000 > +#define CLKMGR_INTOSC_HZ 400000000 > #define CLKMGR_FPGA_CLK_HZ 50000000 What are these defines anyway? CLKMGR_EOSC1_HZ and CLKMGR_FPGA_CLK_HZ seem unused? Can they be removed (that comment would probably have been better in 8/19...)? Regards, Simon > > /* Clock configuration accessors */ >
On Wed, Oct 23, 2019 at 2:31 AM Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> wrote: > > Am 11.10.2019 um 11:52 schrieb Ley Foon Tan: > > CLKMGR_INTOSC_HZ should be 400MHz, instead of 460MHz. > > Having this in a separate patch is clearly better. > > > > > Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com> > > --- > > arch/arm/mach-socfpga/include/mach/clock_manager_soc64.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-socfpga/include/mach/clock_manager_soc64.h b/arch/arm/mach-socfpga/include/mach/clock_manager_soc64.h > > index 3b4bb62ca5..1a134b89ba 100644 > > --- a/arch/arm/mach-socfpga/include/mach/clock_manager_soc64.h > > +++ b/arch/arm/mach-socfpga/include/mach/clock_manager_soc64.h > > @@ -14,7 +14,7 @@ const unsigned int cm_get_intosc_clk_hz(void); > > const unsigned int cm_get_fpga_clk_hz(void); > > > > #define CLKMGR_EOSC1_HZ 25000000 > > -#define CLKMGR_INTOSC_HZ 460000000 > > +#define CLKMGR_INTOSC_HZ 400000000 > > #define CLKMGR_FPGA_CLK_HZ 50000000 > > What are these defines anyway? CLKMGR_EOSC1_HZ and CLKMGR_FPGA_CLK_HZ > seem unused? Can they be removed (that comment would probably have been > better in 8/19...)? They are unused now. Will remove them. Thanks. Regards Ley Foon > > > > > /* Clock configuration accessors */ > > >
diff --git a/arch/arm/mach-socfpga/include/mach/clock_manager_soc64.h b/arch/arm/mach-socfpga/include/mach/clock_manager_soc64.h index 3b4bb62ca5..1a134b89ba 100644 --- a/arch/arm/mach-socfpga/include/mach/clock_manager_soc64.h +++ b/arch/arm/mach-socfpga/include/mach/clock_manager_soc64.h @@ -14,7 +14,7 @@ const unsigned int cm_get_intosc_clk_hz(void); const unsigned int cm_get_fpga_clk_hz(void); #define CLKMGR_EOSC1_HZ 25000000 -#define CLKMGR_INTOSC_HZ 460000000 +#define CLKMGR_INTOSC_HZ 400000000 #define CLKMGR_FPGA_CLK_HZ 50000000 /* Clock configuration accessors */
CLKMGR_INTOSC_HZ should be 400MHz, instead of 460MHz. Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com> --- arch/arm/mach-socfpga/include/mach/clock_manager_soc64.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)