| Message ID | 1539595287-31378-4-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | virtio: Introduce VirtIO driver support | expand |
On 15 October 2018 at 03:20, Bin Meng <bmeng.cn@gmail.com> wrote: > This adds a call to dm_remove_devices_flags() to do_bootm_linux() > so that drivers that have one of the removal flags set (e.g. > DM_FLAG_ACTIVE_DMA_REMOVE) in their driver struct, may do some > last-stage cleanup before the OS is started. > > arm and x86 already did such, and we should do the same for riscv. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > > --- > > Changes in v3: None > Changes in v2: > - new patch to add dm_remove_devices_flags() call to do_bootm_linux() > for riscv bootm > > arch/riscv/lib/bootm.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On 15 October 2018 at 03:20, Bin Meng <bmeng.cn@gmail.com> wrote: > This adds a call to dm_remove_devices_flags() to do_bootm_linux() > so that drivers that have one of the removal flags set (e.g. > DM_FLAG_ACTIVE_DMA_REMOVE) in their driver struct, may do some > last-stage cleanup before the OS is started. > > arm and x86 already did such, and we should do the same for riscv. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > > --- > > Changes in v3: None > Changes in v2: > - new patch to add dm_remove_devices_flags() call to do_bootm_linux() > for riscv bootm > > arch/riscv/lib/bootm.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot-dm/next, thanks!
diff --git a/arch/riscv/lib/bootm.c b/arch/riscv/lib/bootm.c index a7a9fb9..2b5ccce 100644 --- a/arch/riscv/lib/bootm.c +++ b/arch/riscv/lib/bootm.c @@ -9,9 +9,11 @@ #include <common.h> #include <command.h> #include <image.h> -#include <u-boot/zlib.h> #include <asm/byteorder.h> #include <asm/csr.h> +#include <dm/device.h> +#include <dm/root.h> +#include <u-boot/zlib.h> DECLARE_GLOBAL_DATA_PTR; @@ -57,6 +59,13 @@ int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images) /* we assume that the kernel is in place */ printf("\nStarting kernel ...\n\n"); + /* + * Call remove function of all devices with a removal flag set. + * This may be useful for last-stage operations, like cancelling + * of DMA operation or releasing device internal buffers. + */ + dm_remove_devices_flags(DM_REMOVE_ACTIVE_ALL); + cleanup_before_linux(); if (IMAGE_ENABLE_OF_LIBFDT && images->ft_len)
This adds a call to dm_remove_devices_flags() to do_bootm_linux() so that drivers that have one of the removal flags set (e.g. DM_FLAG_ACTIVE_DMA_REMOVE) in their driver struct, may do some last-stage cleanup before the OS is started. arm and x86 already did such, and we should do the same for riscv. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- Changes in v3: None Changes in v2: - new patch to add dm_remove_devices_flags() call to do_bootm_linux() for riscv bootm arch/riscv/lib/bootm.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)