| Message ID | 1510005776-4783-1-git-send-email-philipp.tomsich@theobroma-systems.com |
|---|---|
| State | Accepted |
| Commit | df1e6212f957627731daf9844efe960ca8a549df |
| Headers | show |
| Series | [U-Boot,1/6] rockchip: dts: rk3399-puma: fix the modelling of BIOS_DISABLE | expand |
> The fixed regulator for overriding BIOS_DISABLE had been modelling > backwards (i.e. the GPIO polarity and the enable-active-low/high > property had both been inverted), causing the 'regulator' command > to always print/expect 'disabled'/'enabled' backwards. > > This fixes the mix-up and models it correctly: > * the GPIO is low-active > * the regulator should be enabled (enable-active-high) during > boot-on initialisation > > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > > arch/arm/dts/rk3399-puma.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied to u-boot-rockchip, thanks!
diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi index 4c22279..19d0717 100644 --- a/arch/arm/dts/rk3399-puma.dtsi +++ b/arch/arm/dts/rk3399-puma.dtsi @@ -112,8 +112,8 @@ compatible = "regulator-fixed"; u-boot,dm-pre-reloc; regulator-name = "bios_enable"; - enable-active-low; - gpio = <&gpio3 29 GPIO_ACTIVE_HIGH>; + enable-active-high; + gpio = <&gpio3 29 GPIO_ACTIVE_LOW>; regulator-always-on; regulator-boot-on; regulator-min-microvolt = <1800000>;
The fixed regulator for overriding BIOS_DISABLE had been modelling backwards (i.e. the GPIO polarity and the enable-active-low/high property had both been inverted), causing the 'regulator' command to always print/expect 'disabled'/'enabled' backwards. This fixes the mix-up and models it correctly: * the GPIO is low-active * the regulator should be enabled (enable-active-high) during boot-on initialisation Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> --- arch/arm/dts/rk3399-puma.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)