From patchwork Mon Nov 6 22:02:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Tomsich X-Patchwork-Id: 834976 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3yW67L58lnz9s7f for ; Tue, 7 Nov 2017 09:05:18 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 73D02C21F20; Mon, 6 Nov 2017 22:03:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id B031FC21F34; Mon, 6 Nov 2017 22:03:08 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id ECC39C21DC3; Mon, 6 Nov 2017 22:03:05 +0000 (UTC) Received: from mail.theobroma-systems.com (vegas.theobroma-systems.com [144.76.126.164]) by lists.denx.de (Postfix) with ESMTPS id 8621FC21C34 for ; Mon, 6 Nov 2017 22:03:05 +0000 (UTC) Received: from [86.59.122.178] (port=46564 helo=android.lan) by mail.theobroma-systems.com with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA256:128) (Exim 4.80) (envelope-from ) id 1eBpTy-0008AS-GR; Mon, 06 Nov 2017 23:03:02 +0100 From: Philipp Tomsich To: u-boot@lists.denx.de Date: Mon, 6 Nov 2017 23:02:51 +0100 Message-Id: <1510005776-4783-1-git-send-email-philipp.tomsich@theobroma-systems.com> X-Mailer: git-send-email 2.1.4 Cc: Klaus Goger Subject: [U-Boot] [PATCH 1/6] rockchip: dts: rk3399-puma: fix the modelling of BIOS_DISABLE X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The fixed regulator for overriding BIOS_DISABLE had been modelling backwards (i.e. the GPIO polarity and the enable-active-low/high property had both been inverted), causing the 'regulator' command to always print/expect 'disabled'/'enabled' backwards. This fixes the mix-up and models it correctly: * the GPIO is low-active * the regulator should be enabled (enable-active-high) during boot-on initialisation Signed-off-by: Philipp Tomsich --- arch/arm/dts/rk3399-puma.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi index 4c22279..19d0717 100644 --- a/arch/arm/dts/rk3399-puma.dtsi +++ b/arch/arm/dts/rk3399-puma.dtsi @@ -112,8 +112,8 @@ compatible = "regulator-fixed"; u-boot,dm-pre-reloc; regulator-name = "bios_enable"; - enable-active-low; - gpio = <&gpio3 29 GPIO_ACTIVE_HIGH>; + enable-active-high; + gpio = <&gpio3 29 GPIO_ACTIVE_LOW>; regulator-always-on; regulator-boot-on; regulator-min-microvolt = <1800000>;