| Message ID | 1503386732-24210-1-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
On Tue, Aug 22, 2017 at 3:25 PM, Bin Meng <bmeng.cn@gmail.com> wrote: > There is already a macro LBAFU to aid formatted print with lbaint_t > variables. Let's use it in the common block command codes. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > > --- > > Changes in v2: > - Change to use LBAFU > Oops, forget to prefix the email title with v2. > cmd/blk_common.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/cmd/blk_common.c b/cmd/blk_common.c > index 86c75e7..0c0c23e 100644 > --- a/cmd/blk_common.c > +++ b/cmd/blk_common.c > @@ -68,9 +68,8 @@ int blk_common_cmd(int argc, char * const argv[], enum if_type if_type, > ulong cnt = simple_strtoul(argv[4], NULL, 16); > ulong n; > > - printf("\n%s read: device %d block # %lld, count %ld ... ", > - if_name, *cur_devnump, (unsigned long long)blk, > - cnt); > + printf("\n%s read: device %d block # "LBAFU", count %lu ... ", > + if_name, *cur_devnump, blk, cnt); > > n = blk_read_devnum(if_type, *cur_devnump, blk, cnt, > (ulong *)addr); > @@ -84,9 +83,8 @@ int blk_common_cmd(int argc, char * const argv[], enum if_type if_type, > ulong cnt = simple_strtoul(argv[4], NULL, 16); > ulong n; > > - printf("\n%s write: device %d block # %lld, count %ld ... ", > - if_name, *cur_devnump, (unsigned long long)blk, > - cnt); > + printf("\n%s write: device %d block # "LBAFU", count %lu ... ", > + if_name, *cur_devnump, blk, cnt); > > n = blk_write_devnum(if_type, *cur_devnump, blk, cnt, > (ulong *)addr); > -- Regards, Bin
diff --git a/cmd/blk_common.c b/cmd/blk_common.c index 86c75e7..0c0c23e 100644 --- a/cmd/blk_common.c +++ b/cmd/blk_common.c @@ -68,9 +68,8 @@ int blk_common_cmd(int argc, char * const argv[], enum if_type if_type, ulong cnt = simple_strtoul(argv[4], NULL, 16); ulong n; - printf("\n%s read: device %d block # %lld, count %ld ... ", - if_name, *cur_devnump, (unsigned long long)blk, - cnt); + printf("\n%s read: device %d block # "LBAFU", count %lu ... ", + if_name, *cur_devnump, blk, cnt); n = blk_read_devnum(if_type, *cur_devnump, blk, cnt, (ulong *)addr); @@ -84,9 +83,8 @@ int blk_common_cmd(int argc, char * const argv[], enum if_type if_type, ulong cnt = simple_strtoul(argv[4], NULL, 16); ulong n; - printf("\n%s write: device %d block # %lld, count %ld ... ", - if_name, *cur_devnump, (unsigned long long)blk, - cnt); + printf("\n%s write: device %d block # "LBAFU", count %lu ... ", + if_name, *cur_devnump, blk, cnt); n = blk_write_devnum(if_type, *cur_devnump, blk, cnt, (ulong *)addr);
There is already a macro LBAFU to aid formatted print with lbaint_t variables. Let's use it in the common block command codes. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- Changes in v2: - Change to use LBAFU cmd/blk_common.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)