| Message ID | 1496217855-8745-1-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Accepted |
| Commit | 455a5a8086b17bd6fb60c86ec34299cae6ce2950 |
| Delegated to: | Bin Meng |
| Headers | show |
On 31.05.2017 10:04, Bin Meng wrote: > The default value of "fsp,mrc-init-tseg-size" should be 1 (1MB) per > FSP default settings. 0 is not valid. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> How does this change affect the x86 U-Boot versions? Did you experience any problems with the incorrect value of 0? Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan
Hi Stefan, On Wed, May 31, 2017 at 4:18 PM, Stefan Roese <sr@denx.de> wrote: > On 31.05.2017 10:04, Bin Meng wrote: >> >> The default value of "fsp,mrc-init-tseg-size" should be 1 (1MB) per >> FSP default settings. 0 is not valid. >> >> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > > > How does this change affect the x86 U-Boot versions? Did you > experience any problems with the incorrect value of 0? What do you mean by "affecting the x86 U-Boot versions"? Do you want to track back which U-Boot version introduce the wrong tseg-size setting? I did not experience any problems with the incorrect value of 0, probably because U-Boot does not have SMM support yet. But definitely it is wrong. Regards, Bin
Hi Bin, On 31.05.2017 11:18, Bin Meng wrote: > Hi Stefan, > > On Wed, May 31, 2017 at 4:18 PM, Stefan Roese <sr@denx.de> wrote: >> On 31.05.2017 10:04, Bin Meng wrote: >>> >>> The default value of "fsp,mrc-init-tseg-size" should be 1 (1MB) per >>> FSP default settings. 0 is not valid. >>> >>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> >> >> >> How does this change affect the x86 U-Boot versions? Did you >> experience any problems with the incorrect value of 0? > > What do you mean by "affecting the x86 U-Boot versions"? Do you want > to track back which U-Boot version introduce the wrong tseg-size > setting? No, I just meant, if you were experiencing any problems that were caused by these incorrect values. > I did not experience any problems with the incorrect value of 0, > probably because U-Boot does not have SMM support yet. But definitely > it is wrong. That explain it. Thanks, Stefan
On 31 May 2017 at 02:04, Bin Meng <bmeng.cn@gmail.com> wrote: > The default value of "fsp,mrc-init-tseg-size" should be 1 (1MB) per > FSP default settings. 0 is not valid. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > --- > > arch/x86/cpu/baytrail/fsp_configs.c | 2 +- > arch/x86/dts/bayleybay.dts | 2 +- > arch/x86/dts/baytrail_som-db5800-som-6867.dts | 2 +- > arch/x86/dts/conga-qeval20-qa3-e3845.dts | 2 +- > arch/x86/dts/dfi-bt700.dtsi | 2 +- > arch/x86/dts/minnowmax.dts | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > Reviewed-by: Simon Glass <sjg@chromium.org>
On Thu, Jun 1, 2017 at 11:12 AM, Simon Glass <sjg@chromium.org> wrote: > On 31 May 2017 at 02:04, Bin Meng <bmeng.cn@gmail.com> wrote: >> The default value of "fsp,mrc-init-tseg-size" should be 1 (1MB) per >> FSP default settings. 0 is not valid. >> >> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> >> --- >> >> arch/x86/cpu/baytrail/fsp_configs.c | 2 +- >> arch/x86/dts/bayleybay.dts | 2 +- >> arch/x86/dts/baytrail_som-db5800-som-6867.dts | 2 +- >> arch/x86/dts/conga-qeval20-qa3-e3845.dts | 2 +- >> arch/x86/dts/dfi-bt700.dtsi | 2 +- >> arch/x86/dts/minnowmax.dts | 2 +- >> 6 files changed, 6 insertions(+), 6 deletions(-) >> > > Reviewed-by: Simon Glass <sjg@chromium.org> applied to u-boot-x86, thanks!
diff --git a/arch/x86/cpu/baytrail/fsp_configs.c b/arch/x86/cpu/baytrail/fsp_configs.c index d49b8d2..365e0dd 100644 --- a/arch/x86/cpu/baytrail/fsp_configs.c +++ b/arch/x86/cpu/baytrail/fsp_configs.c @@ -148,7 +148,7 @@ void update_fsp_configs(struct fsp_config_data *config, fsp_upd->mrc_init_tseg_size = fdtdec_get_int(blob, node, "fsp,mrc-init-tseg-size", - 0); + 1); fsp_upd->mrc_init_mmio_size = fdtdec_get_int(blob, node, "fsp,mrc-init-mmio-size", 0x800); diff --git a/arch/x86/dts/bayleybay.dts b/arch/x86/dts/bayleybay.dts index 1ae058d..42a8131 100644 --- a/arch/x86/dts/bayleybay.dts +++ b/arch/x86/dts/bayleybay.dts @@ -236,7 +236,7 @@ fsp { compatible = "intel,baytrail-fsp"; - fsp,mrc-init-tseg-size = <0>; + fsp,mrc-init-tseg-size = <1>; fsp,mrc-init-mmio-size = <0x800>; fsp,mrc-init-spd-addr1 = <0xa0>; fsp,mrc-init-spd-addr2 = <0xa2>; diff --git a/arch/x86/dts/baytrail_som-db5800-som-6867.dts b/arch/x86/dts/baytrail_som-db5800-som-6867.dts index aa8bfb8..d4199a3 100644 --- a/arch/x86/dts/baytrail_som-db5800-som-6867.dts +++ b/arch/x86/dts/baytrail_som-db5800-som-6867.dts @@ -259,7 +259,7 @@ fsp { compatible = "intel,baytrail-fsp"; - fsp,mrc-init-tseg-size = <0>; + fsp,mrc-init-tseg-size = <1>; fsp,mrc-init-mmio-size = <0x800>; fsp,mrc-init-spd-addr1 = <0xa0>; fsp,mrc-init-spd-addr2 = <0xa2>; diff --git a/arch/x86/dts/conga-qeval20-qa3-e3845.dts b/arch/x86/dts/conga-qeval20-qa3-e3845.dts index 898e9c9..904197a 100644 --- a/arch/x86/dts/conga-qeval20-qa3-e3845.dts +++ b/arch/x86/dts/conga-qeval20-qa3-e3845.dts @@ -246,7 +246,7 @@ fsp { compatible = "intel,baytrail-fsp"; - fsp,mrc-init-tseg-size = <0>; + fsp,mrc-init-tseg-size = <1>; fsp,mrc-init-mmio-size = <0x800>; fsp,mrc-init-spd-addr1 = <0xa0>; fsp,mrc-init-spd-addr2 = <0xa2>; diff --git a/arch/x86/dts/dfi-bt700.dtsi b/arch/x86/dts/dfi-bt700.dtsi index 546981a..a369e73 100644 --- a/arch/x86/dts/dfi-bt700.dtsi +++ b/arch/x86/dts/dfi-bt700.dtsi @@ -248,7 +248,7 @@ fsp { compatible = "intel,baytrail-fsp"; - fsp,mrc-init-tseg-size = <0>; + fsp,mrc-init-tseg-size = <1>; fsp,mrc-init-mmio-size = <0x800>; fsp,mrc-init-spd-addr1 = <0xa0>; fsp,mrc-init-spd-addr2 = <0xa2>; diff --git a/arch/x86/dts/minnowmax.dts b/arch/x86/dts/minnowmax.dts index af64c68..4d55abb 100644 --- a/arch/x86/dts/minnowmax.dts +++ b/arch/x86/dts/minnowmax.dts @@ -260,7 +260,7 @@ fsp { compatible = "intel,baytrail-fsp"; - fsp,mrc-init-tseg-size = <0>; + fsp,mrc-init-tseg-size = <1>; fsp,mrc-init-mmio-size = <0x800>; fsp,mrc-init-spd-addr1 = <0xa0>; fsp,mrc-init-spd-addr2 = <0xa2>;
The default value of "fsp,mrc-init-tseg-size" should be 1 (1MB) per FSP default settings. 0 is not valid. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- arch/x86/cpu/baytrail/fsp_configs.c | 2 +- arch/x86/dts/bayleybay.dts | 2 +- arch/x86/dts/baytrail_som-db5800-som-6867.dts | 2 +- arch/x86/dts/conga-qeval20-qa3-e3845.dts | 2 +- arch/x86/dts/dfi-bt700.dtsi | 2 +- arch/x86/dts/minnowmax.dts | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)