diff mbox

[U-Boot,RFC,v1,2/2] arm: ls1021aqds: Enable driver model lpuart serial driver

Message ID 1454979421-18766-3-git-send-email-york.sun@nxp.com
State Superseded
Delegated to: York Sun
Headers show

Commit Message

York Sun Feb. 9, 2016, 12:57 a.m. UTC 
Convert ls1021aqds_nor_lpuart and ls1021aqds_ddr4_nor_lpuart
to driver model suport. Enable lpuart port driver.

Signed-off-by: York Sun <york.sun@nxp.com>
CC: Alison Wang <alison.wang@nxp.com>
CC: Bin Meng <bmeng.cn@gmail.com>

---

 arch/arm/dts/Makefile                        |    1 +
 arch/arm/dts/ls1021a-qds-lpuart.dts          |   16 ++++++++++++++++
 configs/ls1021aqds_ddr4_nor_lpuart_defconfig |    4 ++++
 configs/ls1021aqds_nor_lpuart_defconfig      |    4 ++++
 4 files changed, 25 insertions(+)
 create mode 100644 arch/arm/dts/ls1021a-qds-lpuart.dts

Comments

Bin Meng Feb. 14, 2016, 3:01 a.m. UTC | #1 
Hi York,

On Tue, Feb 9, 2016 at 8:57 AM, York Sun <york.sun@nxp.com> wrote:
> Convert ls1021aqds_nor_lpuart and ls1021aqds_ddr4_nor_lpuart
> to driver model suport. Enable lpuart port driver.
>
> Signed-off-by: York Sun <york.sun@nxp.com>
> CC: Alison Wang <alison.wang@nxp.com>
> CC: Bin Meng <bmeng.cn@gmail.com>
>
> ---
>
>  arch/arm/dts/Makefile                        |    1 +
>  arch/arm/dts/ls1021a-qds-lpuart.dts          |   16 ++++++++++++++++
>  configs/ls1021aqds_ddr4_nor_lpuart_defconfig |    4 ++++
>  configs/ls1021aqds_nor_lpuart_defconfig      |    4 ++++
>  4 files changed, 25 insertions(+)
>  create mode 100644 arch/arm/dts/ls1021a-qds-lpuart.dts
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index ef58aec..c27b80c 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -95,6 +95,7 @@ dtb-$(CONFIG_TARGET_BEAGLE_X15) += am57xx-beagle-x15.dtb
>  dtb-$(CONFIG_TARGET_STV0991) += stv0991.dtb
>
>  dtb-$(CONFIG_LS102XA) += ls1021a-qds-duart.dtb \
> +       ls1021a-qds-lpuart.dtb \
>         ls1021a-twr-duart.dtb ls1021a-twr-lpuart.dtb
>  dtb-$(CONFIG_FSL_LSCH3) += fsl-ls2080a-qds.dtb \
>         fsl-ls2080a-rdb.dtb
> diff --git a/arch/arm/dts/ls1021a-qds-lpuart.dts b/arch/arm/dts/ls1021a-qds-lpuart.dts
> new file mode 100644
> index 0000000..1d16ffd
> --- /dev/null
> +++ b/arch/arm/dts/ls1021a-qds-lpuart.dts
> @@ -0,0 +1,16 @@
> +/*
> + * Freescale ls1021a QDS board common device tree source
> + *
> + * Copyright 2013-2015 Freescale Semiconductor, Inc.
> + *
> + * SPDX-License-Identifier:    GPL-2.0+
> + */
> +
> +/dts-v1/;
> +#include "ls1021a-qds.dtsi"
> +
> +/ {
> +       chosen {
> +               stdout-path = &lpuart0;
> +       };
> +};
> diff --git a/configs/ls1021aqds_ddr4_nor_lpuart_defconfig b/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
> index 44b2a0d..ffac6dd 100644
> --- a/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
> +++ b/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
> @@ -1,7 +1,11 @@
>  CONFIG_ARM=y
>  CONFIG_TARGET_LS1021AQDS=y
>  CONFIG_SYS_EXTRA_OPTIONS="SYS_FSL_DDR4,LPUART"
> +CONFIG_DM_SERIAL=y
> +CONFIG_DEFAULT_DEVICE_TREE="ls1021a-qds-duart"

I believe this should be "ls1021a-qds-lpuart"?

>  # CONFIG_CMD_SETEXPR is not set
> +CONFIG_OF_CONTROL=y
> +CONFIG_DM=y
>  CONFIG_NETDEVICES=y
>  CONFIG_E1000=y
>  CONFIG_FSL_LPUART=y
> diff --git a/configs/ls1021aqds_nor_lpuart_defconfig b/configs/ls1021aqds_nor_lpuart_defconfig
> index 1186af2..e81448d 100644
> --- a/configs/ls1021aqds_nor_lpuart_defconfig
> +++ b/configs/ls1021aqds_nor_lpuart_defconfig
> @@ -1,7 +1,11 @@
>  CONFIG_ARM=y
>  CONFIG_TARGET_LS1021AQDS=y
> +CONFIG_DM_SERIAL=y
> +CONFIG_DEFAULT_DEVICE_TREE="ls1021a-qds-lpuart"
>  CONFIG_SYS_EXTRA_OPTIONS="LPUART"
>  # CONFIG_CMD_SETEXPR is not set
> +CONFIG_OF_CONTROL=y
> +CONFIG_DM=y
>  CONFIG_NETDEVICES=y
>  CONFIG_E1000=y
>  CONFIG_FSL_LPUART=y
> --

Regards,
Bin
Alison Wang Feb. 22, 2016, 7:07 a.m. UTC | #2 
Hi, York,

> On Tue, Feb 9, 2016 at 8:57 AM, York Sun <york.sun@nxp.com> wrote:
> > Convert ls1021aqds_nor_lpuart and ls1021aqds_ddr4_nor_lpuart to driver
> > model suport. Enable lpuart port driver.
> >
> > Signed-off-by: York Sun <york.sun@nxp.com>
> > CC: Alison Wang <alison.wang@nxp.com>
> > CC: Bin Meng <bmeng.cn@gmail.com>
> >
> > ---
> >
> >  arch/arm/dts/Makefile                        |    1 +
> >  arch/arm/dts/ls1021a-qds-lpuart.dts          |   16 ++++++++++++++++
> >  configs/ls1021aqds_ddr4_nor_lpuart_defconfig |    4 ++++
> >  configs/ls1021aqds_nor_lpuart_defconfig      |    4 ++++
> >  4 files changed, 25 insertions(+)
> >  create mode 100644 arch/arm/dts/ls1021a-qds-lpuart.dts
> >
> > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
> > ef58aec..c27b80c 100644
> > --- a/arch/arm/dts/Makefile
> > +++ b/arch/arm/dts/Makefile
> > @@ -95,6 +95,7 @@ dtb-$(CONFIG_TARGET_BEAGLE_X15) +=
> > am57xx-beagle-x15.dtb
> >  dtb-$(CONFIG_TARGET_STV0991) += stv0991.dtb
> >
> >  dtb-$(CONFIG_LS102XA) += ls1021a-qds-duart.dtb \
> > +       ls1021a-qds-lpuart.dtb \
> >         ls1021a-twr-duart.dtb ls1021a-twr-lpuart.dtb
> >  dtb-$(CONFIG_FSL_LSCH3) += fsl-ls2080a-qds.dtb \
> >         fsl-ls2080a-rdb.dtb
> > diff --git a/arch/arm/dts/ls1021a-qds-lpuart.dts
> > b/arch/arm/dts/ls1021a-qds-lpuart.dts
> > new file mode 100644
> > index 0000000..1d16ffd
> > --- /dev/null
> > +++ b/arch/arm/dts/ls1021a-qds-lpuart.dts
> > @@ -0,0 +1,16 @@
> > +/*
> > + * Freescale ls1021a QDS board common device tree source
> > + *
> > + * Copyright 2013-2015 Freescale Semiconductor, Inc.
> > + *
> > + * SPDX-License-Identifier:    GPL-2.0+
> > + */
> > +
> > +/dts-v1/;
> > +#include "ls1021a-qds.dtsi"
> > +
> > +/ {
> > +       chosen {
> > +               stdout-path = &lpuart0;
> > +       };
> > +};
> > diff --git a/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
> > b/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
> > index 44b2a0d..ffac6dd 100644
> > --- a/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
> > +++ b/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
> > @@ -1,7 +1,11 @@
> >  CONFIG_ARM=y
> >  CONFIG_TARGET_LS1021AQDS=y
> >  CONFIG_SYS_EXTRA_OPTIONS="SYS_FSL_DDR4,LPUART"
> > +CONFIG_DM_SERIAL=y
> > +CONFIG_DEFAULT_DEVICE_TREE="ls1021a-qds-duart"
> 
> I believe this should be "ls1021a-qds-lpuart"?
> 
> >  # CONFIG_CMD_SETEXPR is not set
> > +CONFIG_OF_CONTROL=y
> > +CONFIG_DM=y
> >  CONFIG_NETDEVICES=y
> >  CONFIG_E1000=y
> >  CONFIG_FSL_LPUART=y
> > diff --git a/configs/ls1021aqds_nor_lpuart_defconfig
> > b/configs/ls1021aqds_nor_lpuart_defconfig
> > index 1186af2..e81448d 100644
> > --- a/configs/ls1021aqds_nor_lpuart_defconfig
> > +++ b/configs/ls1021aqds_nor_lpuart_defconfig
> > @@ -1,7 +1,11 @@
> >  CONFIG_ARM=y
> >  CONFIG_TARGET_LS1021AQDS=y
> > +CONFIG_DM_SERIAL=y
> > +CONFIG_DEFAULT_DEVICE_TREE="ls1021a-qds-lpuart"
> >  CONFIG_SYS_EXTRA_OPTIONS="LPUART"
> >  # CONFIG_CMD_SETEXPR is not set
> > +CONFIG_OF_CONTROL=y
> > +CONFIG_DM=y
> >  CONFIG_NETDEVICES=y
> >  CONFIG_E1000=y
> >  CONFIG_FSL_LPUART=y
> > --
> 
[Alison Wang] I reviewed this set, and have no other comments except Bin Meng's.

BTW, I tested this set on LS1021AQDS board with that little modification about the comment.


Best Regards,
Alison Wang
York Sun Feb. 22, 2016, 5:19 p.m. UTC | #3 
On 02/21/2016 11:07 PM, Huan Wang wrote:
> Hi, York,
> 
>> On Tue, Feb 9, 2016 at 8:57 AM, York Sun <york.sun@nxp.com> wrote:
>>> Convert ls1021aqds_nor_lpuart and ls1021aqds_ddr4_nor_lpuart to driver
>>> model suport. Enable lpuart port driver.
>>>
>>> Signed-off-by: York Sun <york.sun@nxp.com>
>>> CC: Alison Wang <alison.wang@nxp.com>
>>> CC: Bin Meng <bmeng.cn@gmail.com>
>>>
>>> ---
>>>
>>>  arch/arm/dts/Makefile                        |    1 +
>>>  arch/arm/dts/ls1021a-qds-lpuart.dts          |   16 ++++++++++++++++
>>>  configs/ls1021aqds_ddr4_nor_lpuart_defconfig |    4 ++++
>>>  configs/ls1021aqds_nor_lpuart_defconfig      |    4 ++++
>>>  4 files changed, 25 insertions(+)
>>>  create mode 100644 arch/arm/dts/ls1021a-qds-lpuart.dts
>>>
>>> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
>>> ef58aec..c27b80c 100644
>>> --- a/arch/arm/dts/Makefile
>>> +++ b/arch/arm/dts/Makefile
>>> @@ -95,6 +95,7 @@ dtb-$(CONFIG_TARGET_BEAGLE_X15) +=
>>> am57xx-beagle-x15.dtb
>>>  dtb-$(CONFIG_TARGET_STV0991) += stv0991.dtb
>>>
>>>  dtb-$(CONFIG_LS102XA) += ls1021a-qds-duart.dtb \
>>> +       ls1021a-qds-lpuart.dtb \
>>>         ls1021a-twr-duart.dtb ls1021a-twr-lpuart.dtb
>>>  dtb-$(CONFIG_FSL_LSCH3) += fsl-ls2080a-qds.dtb \
>>>         fsl-ls2080a-rdb.dtb
>>> diff --git a/arch/arm/dts/ls1021a-qds-lpuart.dts
>>> b/arch/arm/dts/ls1021a-qds-lpuart.dts
>>> new file mode 100644
>>> index 0000000..1d16ffd
>>> --- /dev/null
>>> +++ b/arch/arm/dts/ls1021a-qds-lpuart.dts
>>> @@ -0,0 +1,16 @@
>>> +/*
>>> + * Freescale ls1021a QDS board common device tree source
>>> + *
>>> + * Copyright 2013-2015 Freescale Semiconductor, Inc.
>>> + *
>>> + * SPDX-License-Identifier:    GPL-2.0+
>>> + */
>>> +
>>> +/dts-v1/;
>>> +#include "ls1021a-qds.dtsi"
>>> +
>>> +/ {
>>> +       chosen {
>>> +               stdout-path = &lpuart0;
>>> +       };
>>> +};
>>> diff --git a/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
>>> b/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
>>> index 44b2a0d..ffac6dd 100644
>>> --- a/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
>>> +++ b/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
>>> @@ -1,7 +1,11 @@
>>>  CONFIG_ARM=y
>>>  CONFIG_TARGET_LS1021AQDS=y
>>>  CONFIG_SYS_EXTRA_OPTIONS="SYS_FSL_DDR4,LPUART"
>>> +CONFIG_DM_SERIAL=y
>>> +CONFIG_DEFAULT_DEVICE_TREE="ls1021a-qds-duart"
>>
>> I believe this should be "ls1021a-qds-lpuart"?
>>
>>>  # CONFIG_CMD_SETEXPR is not set
>>> +CONFIG_OF_CONTROL=y
>>> +CONFIG_DM=y
>>>  CONFIG_NETDEVICES=y
>>>  CONFIG_E1000=y
>>>  CONFIG_FSL_LPUART=y
>>> diff --git a/configs/ls1021aqds_nor_lpuart_defconfig
>>> b/configs/ls1021aqds_nor_lpuart_defconfig
>>> index 1186af2..e81448d 100644
>>> --- a/configs/ls1021aqds_nor_lpuart_defconfig
>>> +++ b/configs/ls1021aqds_nor_lpuart_defconfig
>>> @@ -1,7 +1,11 @@
>>>  CONFIG_ARM=y
>>>  CONFIG_TARGET_LS1021AQDS=y
>>> +CONFIG_DM_SERIAL=y
>>> +CONFIG_DEFAULT_DEVICE_TREE="ls1021a-qds-lpuart"
>>>  CONFIG_SYS_EXTRA_OPTIONS="LPUART"
>>>  # CONFIG_CMD_SETEXPR is not set
>>> +CONFIG_OF_CONTROL=y
>>> +CONFIG_DM=y
>>>  CONFIG_NETDEVICES=y
>>>  CONFIG_E1000=y
>>>  CONFIG_FSL_LPUART=y
>>> --
>>
> [Alison Wang] I reviewed this set, and have no other comments except Bin Meng's.
> 
> BTW, I tested this set on LS1021AQDS board with that little modification about the comment.
> 

Thanks. I will send out an update.

York
diff mbox

Patch

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index ef58aec..c27b80c 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -95,6 +95,7 @@  dtb-$(CONFIG_TARGET_BEAGLE_X15) += am57xx-beagle-x15.dtb
 dtb-$(CONFIG_TARGET_STV0991) += stv0991.dtb
 
 dtb-$(CONFIG_LS102XA) += ls1021a-qds-duart.dtb \
+	ls1021a-qds-lpuart.dtb \
 	ls1021a-twr-duart.dtb ls1021a-twr-lpuart.dtb
 dtb-$(CONFIG_FSL_LSCH3) += fsl-ls2080a-qds.dtb \
 	fsl-ls2080a-rdb.dtb
diff --git a/arch/arm/dts/ls1021a-qds-lpuart.dts b/arch/arm/dts/ls1021a-qds-lpuart.dts
new file mode 100644
index 0000000..1d16ffd
--- /dev/null
+++ b/arch/arm/dts/ls1021a-qds-lpuart.dts
@@ -0,0 +1,16 @@ 
+/*
+ * Freescale ls1021a QDS board common device tree source
+ *
+ * Copyright 2013-2015 Freescale Semiconductor, Inc.
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+/dts-v1/;
+#include "ls1021a-qds.dtsi"
+
+/ {
+	chosen {
+		stdout-path = &lpuart0;
+	};
+};
diff --git a/configs/ls1021aqds_ddr4_nor_lpuart_defconfig b/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
index 44b2a0d..ffac6dd 100644
--- a/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
+++ b/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
@@ -1,7 +1,11 @@ 
 CONFIG_ARM=y
 CONFIG_TARGET_LS1021AQDS=y
 CONFIG_SYS_EXTRA_OPTIONS="SYS_FSL_DDR4,LPUART"
+CONFIG_DM_SERIAL=y
+CONFIG_DEFAULT_DEVICE_TREE="ls1021a-qds-duart"
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_OF_CONTROL=y
+CONFIG_DM=y
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y
 CONFIG_FSL_LPUART=y
diff --git a/configs/ls1021aqds_nor_lpuart_defconfig b/configs/ls1021aqds_nor_lpuart_defconfig
index 1186af2..e81448d 100644
--- a/configs/ls1021aqds_nor_lpuart_defconfig
+++ b/configs/ls1021aqds_nor_lpuart_defconfig
@@ -1,7 +1,11 @@ 
 CONFIG_ARM=y
 CONFIG_TARGET_LS1021AQDS=y
+CONFIG_DM_SERIAL=y
+CONFIG_DEFAULT_DEVICE_TREE="ls1021a-qds-lpuart"
 CONFIG_SYS_EXTRA_OPTIONS="LPUART"
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_OF_CONTROL=y
+CONFIG_DM=y
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y
 CONFIG_FSL_LPUART=y