| Message ID | 1453292585-27710-1-git-send-email-trini@konsulko.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Bin Meng |
| Headers | show |
Hi Tom, On Wed, Jan 20, 2016 at 8:23 PM, Tom Rini <trini@konsulko.com> wrote: > clang-3.8 reports that these functions are unused, remove them. > > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > common/console.c | 48 ------------------------------------------------ > 1 file changed, 48 deletions(-) > > diff --git a/common/console.c b/common/console.c > index bc37b6d..b3f5fdc 100644 > --- a/common/console.c > +++ b/common/console.c > @@ -227,11 +227,6 @@ static void console_puts(int file, const char *s) > } > } > > -static inline void console_printdevs(int file) > -{ > - iomux_printdevs(file); > -} > - > static inline void console_doenv(int file, struct stdio_dev *dev) > { > iomux_doenv(file, dev->name); > @@ -265,11 +260,6 @@ static inline void console_puts(int file, const char *s) > stdio_devices[file]->puts(stdio_devices[file], s); > } > > -static inline void console_printdevs(int file) > -{ > - printf("%s\n", stdio_devices[file]->name); > -} > - > static inline void console_doenv(int file, struct stdio_dev *dev) > { > console_setfile(file, dev); > @@ -653,44 +643,6 @@ void clear_ctrlc(void) > ctrlc_was_pressed = 0; > } > > -#ifdef CONFIG_MODEM_SUPPORT_DEBUG > -char screen[1024]; > -char *cursor = screen; > -int once = 0; > -inline void dbg(const char *fmt, ...) > -{ > - va_list args; > - uint i; > - char printbuffer[CONFIG_SYS_PBSIZE]; > - > - if (!once) { > - memset(screen, 0, sizeof(screen)); > - once++; > - } > - > - va_start(args, fmt); > - > - /* For this to work, printbuffer must be larger than > - * anything we ever want to print. > - */ > - i = vsnprintf(printbuffer, sizeof(printbuffer), fmt, args); > - va_end(args); > - > - if ((screen + sizeof(screen) - 1 - cursor) > - < strlen(printbuffer) + 1) { > - memset(screen, 0, sizeof(screen)); > - cursor = screen; > - } > - sprintf(cursor, printbuffer); > - cursor += strlen(printbuffer); > - > -} > -#else > -static inline void dbg(const char *fmt, ...) > -{ > -} > -#endif > - > /** U-Boot INIT FUNCTIONS *************************************************/ > > struct stdio_dev *search_device(int flags, const char *name) > -- Please remove one more instance of CONFIG_MODEM_SUPPORT_DEBUG in README. Other than that, Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Regards, Bin
diff --git a/common/console.c b/common/console.c index bc37b6d..b3f5fdc 100644 --- a/common/console.c +++ b/common/console.c @@ -227,11 +227,6 @@ static void console_puts(int file, const char *s) } } -static inline void console_printdevs(int file) -{ - iomux_printdevs(file); -} - static inline void console_doenv(int file, struct stdio_dev *dev) { iomux_doenv(file, dev->name); @@ -265,11 +260,6 @@ static inline void console_puts(int file, const char *s) stdio_devices[file]->puts(stdio_devices[file], s); } -static inline void console_printdevs(int file) -{ - printf("%s\n", stdio_devices[file]->name); -} - static inline void console_doenv(int file, struct stdio_dev *dev) { console_setfile(file, dev); @@ -653,44 +643,6 @@ void clear_ctrlc(void) ctrlc_was_pressed = 0; } -#ifdef CONFIG_MODEM_SUPPORT_DEBUG -char screen[1024]; -char *cursor = screen; -int once = 0; -inline void dbg(const char *fmt, ...) -{ - va_list args; - uint i; - char printbuffer[CONFIG_SYS_PBSIZE]; - - if (!once) { - memset(screen, 0, sizeof(screen)); - once++; - } - - va_start(args, fmt); - - /* For this to work, printbuffer must be larger than - * anything we ever want to print. - */ - i = vsnprintf(printbuffer, sizeof(printbuffer), fmt, args); - va_end(args); - - if ((screen + sizeof(screen) - 1 - cursor) - < strlen(printbuffer) + 1) { - memset(screen, 0, sizeof(screen)); - cursor = screen; - } - sprintf(cursor, printbuffer); - cursor += strlen(printbuffer); - -} -#else -static inline void dbg(const char *fmt, ...) -{ -} -#endif - /** U-Boot INIT FUNCTIONS *************************************************/ struct stdio_dev *search_device(int flags, const char *name)
clang-3.8 reports that these functions are unused, remove them. Signed-off-by: Tom Rini <trini@konsulko.com> --- common/console.c | 48 ------------------------------------------------ 1 file changed, 48 deletions(-)