| Message ID | 1441773171-4575-4-git-send-email-sjg@chromium.org |
|---|---|
| State | Superseded |
| Delegated to: | Simon Glass |
| Headers | show |
On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass <sjg@chromium.org> wrote: > Return a useful error instead of -1 when something goes wrong. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > drivers/input/input.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/input.c b/drivers/input/input.c > index 007b855..9033935 100644 > --- a/drivers/input/input.c > +++ b/drivers/input/input.c > @@ -8,6 +8,7 @@ > */ > > #include <common.h> > +#include <errno.h> > #include <stdio_dev.h> > #include <input.h> > #include <linux/input.h> > @@ -467,7 +468,7 @@ int input_init(struct input_config *config, int leds) > input_add_table(config, KEY_LEFTCTRL, KEY_RIGHTCTRL, > kbd_ctrl_xlate, ARRAY_SIZE(kbd_ctrl_xlate))) { > debug("%s: Could not add modifier tables\n", __func__); > - return -1; > + return -ENOSPC; > } > > return 0; > -- Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff --git a/drivers/input/input.c b/drivers/input/input.c index 007b855..9033935 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c @@ -8,6 +8,7 @@ */ #include <common.h> +#include <errno.h> #include <stdio_dev.h> #include <input.h> #include <linux/input.h> @@ -467,7 +468,7 @@ int input_init(struct input_config *config, int leds) input_add_table(config, KEY_LEFTCTRL, KEY_RIGHTCTRL, kbd_ctrl_xlate, ARRAY_SIZE(kbd_ctrl_xlate))) { debug("%s: Could not add modifier tables\n", __func__); - return -1; + return -ENOSPC; } return 0;
Return a useful error instead of -1 when something goes wrong. Signed-off-by: Simon Glass <sjg@chromium.org> --- drivers/input/input.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)