| Message ID | 1441756374-6762-5-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted |
| Delegated to: | Simon Glass |
| Headers | show |
On Wed, Sep 9, 2015 at 7:52 AM, Simon Glass <sjg@chromium.org> wrote: > One debug() statement is missing a newline. The other has a repeated word. > Fix these. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > drivers/pci/pci-uclass.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c > index 437c81a..7347160 100644 > --- a/drivers/pci/pci-uclass.c > +++ b/drivers/pci/pci-uclass.c > @@ -418,7 +418,7 @@ int dm_pci_hose_probe_bus(struct pci_controller *hose, pci_dev_t bdf) > > ret = device_probe(bus); > if (ret) { > - debug("%s: Cannot probe bus bus %s: %d\n", __func__, bus->name, > + debug("%s: Cannot probe bus %s: %d\n", __func__, bus->name, > ret); > return ret; > } > @@ -537,7 +537,7 @@ static int pci_find_and_bind_driver(struct udevice *parent, > > ret = device_bind_driver(parent, drv, str, devp); > if (ret) { > - debug("%s: Failed to bind generic driver: %d", __func__, ret); > + debug("%s: Failed to bind generic driver: %d\n", __func__, ret); > return ret; > } > debug("%s: No match found: bound generic driver instead\n", __func__); > -- Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On 14 September 2015 at 06:15, Bin Meng <bmeng.cn@gmail.com> wrote: > On Wed, Sep 9, 2015 at 7:52 AM, Simon Glass <sjg@chromium.org> wrote: >> One debug() statement is missing a newline. The other has a repeated word. >> Fix these. >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> --- >> >> drivers/pci/pci-uclass.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c >> index 437c81a..7347160 100644 >> --- a/drivers/pci/pci-uclass.c >> +++ b/drivers/pci/pci-uclass.c >> @@ -418,7 +418,7 @@ int dm_pci_hose_probe_bus(struct pci_controller *hose, pci_dev_t bdf) >> >> ret = device_probe(bus); >> if (ret) { >> - debug("%s: Cannot probe bus bus %s: %d\n", __func__, bus->name, >> + debug("%s: Cannot probe bus %s: %d\n", __func__, bus->name, >> ret); >> return ret; >> } >> @@ -537,7 +537,7 @@ static int pci_find_and_bind_driver(struct udevice *parent, >> >> ret = device_bind_driver(parent, drv, str, devp); >> if (ret) { >> - debug("%s: Failed to bind generic driver: %d", __func__, ret); >> + debug("%s: Failed to bind generic driver: %d\n", __func__, ret); >> return ret; >> } >> debug("%s: No match found: bound generic driver instead\n", __func__); >> -- > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Applied to u-boot-x86.
diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c index 437c81a..7347160 100644 --- a/drivers/pci/pci-uclass.c +++ b/drivers/pci/pci-uclass.c @@ -418,7 +418,7 @@ int dm_pci_hose_probe_bus(struct pci_controller *hose, pci_dev_t bdf) ret = device_probe(bus); if (ret) { - debug("%s: Cannot probe bus bus %s: %d\n", __func__, bus->name, + debug("%s: Cannot probe bus %s: %d\n", __func__, bus->name, ret); return ret; } @@ -537,7 +537,7 @@ static int pci_find_and_bind_driver(struct udevice *parent, ret = device_bind_driver(parent, drv, str, devp); if (ret) { - debug("%s: Failed to bind generic driver: %d", __func__, ret); + debug("%s: Failed to bind generic driver: %d\n", __func__, ret); return ret; } debug("%s: No match found: bound generic driver instead\n", __func__);
One debug() statement is missing a newline. The other has a repeated word. Fix these. Signed-off-by: Simon Glass <sjg@chromium.org> --- drivers/pci/pci-uclass.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)