diff mbox

[U-Boot,3/7] x86: minnowmax: Remove smsc47x superio codes

Message ID 1438253358-25223-4-git-send-email-bmeng.cn@gmail.com
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Bin Meng July 30, 2015, 10:49 a.m. UTC
On Intel BayTrail SoC, there is a legacy UART (I/O 0x3f8) integrated
into the SoC which is enabled by the FSP. Remove the smsc47x superio
initialization codes.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 board/intel/minnowmax/minnowmax.c | 12 ------------
 include/configs/minnowmax.h       |  2 --
 2 files changed, 14 deletions(-)

Comments

Simon Glass July 30, 2015, 7:55 p.m. UTC | #1
On 30 July 2015 at 04:49, Bin Meng <bmeng.cn@gmail.com> wrote:
> On Intel BayTrail SoC, there is a legacy UART (I/O 0x3f8) integrated
> into the SoC which is enabled by the FSP. Remove the smsc47x superio
> initialization codes.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  board/intel/minnowmax/minnowmax.c | 12 ------------
>  include/configs/minnowmax.h       |  2 --
>  2 files changed, 14 deletions(-)

Acked-by: Simon Glass <sjg@chromium.org>
Simon Glass Aug. 2, 2015, 11:36 p.m. UTC | #2
On 30 July 2015 at 13:55, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2015 at 04:49, Bin Meng <bmeng.cn@gmail.com> wrote:
>> On Intel BayTrail SoC, there is a legacy UART (I/O 0x3f8) integrated
>> into the SoC which is enabled by the FSP. Remove the smsc47x superio
>> initialization codes.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>>  board/intel/minnowmax/minnowmax.c | 12 ------------
>>  include/configs/minnowmax.h       |  2 --
>>  2 files changed, 14 deletions(-)
>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-x86, thanks!
diff mbox

Patch

diff --git a/board/intel/minnowmax/minnowmax.c b/board/intel/minnowmax/minnowmax.c
index 383cae0..c4f2c33 100644
--- a/board/intel/minnowmax/minnowmax.c
+++ b/board/intel/minnowmax/minnowmax.c
@@ -6,12 +6,7 @@ 
 
 #include <common.h>
 #include <asm/gpio.h>
-#include <asm/ibmpc.h>
-#include <asm/pnp_def.h>
 #include <netdev.h>
-#include <smsc_lpc47m.h>
-
-#define SERIAL_DEV PNP_DEV(0x2e, 4)
 
 int arch_early_init_r(void)
 {
@@ -21,13 +16,6 @@  int arch_early_init_r(void)
 	return 0;
 }
 
-int board_early_init_f(void)
-{
-	lpc47m_enable_serial(SERIAL_DEV, UART0_BASE, UART0_IRQ);
-
-	return 0;
-}
-
 void setup_pch_gpios(u16 gpiobase, const struct pch_gpio_map *gpio)
 {
 	return;
diff --git a/include/configs/minnowmax.h b/include/configs/minnowmax.h
index 4781e79..655ce3d 100644
--- a/include/configs/minnowmax.h
+++ b/include/configs/minnowmax.h
@@ -14,11 +14,9 @@ 
 #include <configs/x86-common.h>
 
 #define CONFIG_SYS_MONITOR_LEN		(1 << 20)
-#define CONFIG_BOARD_EARLY_INIT_F
 #define CONFIG_ARCH_EARLY_INIT_R
 
 #define CONFIG_X86_SERIAL
-#define CONFIG_SMSC_LPC47M
 
 #define CONFIG_PCI_MEM_BUS		0xd0000000
 #define CONFIG_PCI_MEM_PHYS		CONFIG_PCI_MEM_BUS