diff mbox

[U-Boot] scripts/Makefile.lib: Make __dtb_dt_begin align on a 4 byte boundary

Message ID 1416476706-4381-1-git-send-email-bmeng.cn@gmail.com
State Rejected
Headers show

Commit Message

Bin Meng Nov. 20, 2014, 9:45 a.m. UTC
With CONFIG_OF_EMBED, __dtb_dt_begin must be aligned on a 4 byte
boundary otherwise fdtdec_prepare_fdt() will fail.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
 scripts/Makefile.lib | 1 +
 1 file changed, 1 insertion(+)

Comments

Masahiro Yamada Nov. 20, 2014, 10:04 a.m. UTC | #1
Hi Bin,

I think this issue is covered by Simon's patch:
http://patchwork.ozlabs.org/patch/411062/



On Thu, 20 Nov 2014 17:45:06 +0800
Bin Meng <bmeng.cn@gmail.com> wrote:

> With CONFIG_OF_EMBED, __dtb_dt_begin must be aligned on a 4 byte
> boundary otherwise fdtdec_prepare_fdt() will fail.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>  scripts/Makefile.lib | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 9d1383a..aead250 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -260,6 +260,7 @@ quiet_cmd_dt_S_dtb= DTB     $@
>  cmd_dt_S_dtb=						\
>  (							\
>  	echo '.section .dtb.init.rodata,"a"';		\
> +	echo '.p2align 2';				\
>  	echo '.global __dtb_$(*F)_begin';		\
>  	echo '__dtb_$(*F)_begin:';			\
>  	echo '.incbin "$<" ';				\
> -- 
> 1.8.2.1
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Bin Meng Nov. 20, 2014, 10:10 a.m. UTC | #2
Hi Masahiro,

On Thu, Nov 20, 2014 at 6:04 PM, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:
> Hi Bin,
>
> I think this issue is covered by Simon's patch:
> http://patchwork.ozlabs.org/patch/411062/
>

Thanks for the info. I did not notice that patch before.

Regards,
Bin
diff mbox

Patch

diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 9d1383a..aead250 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -260,6 +260,7 @@  quiet_cmd_dt_S_dtb= DTB     $@
 cmd_dt_S_dtb=						\
 (							\
 	echo '.section .dtb.init.rodata,"a"';		\
+	echo '.p2align 2';				\
 	echo '.global __dtb_$(*F)_begin';		\
 	echo '__dtb_$(*F)_begin:';			\
 	echo '.incbin "$<" ';				\