mbox series

[v2,0/6] Call phy_config at port probe time for the Felix DSA driver

Message ID 20210824120043.3823931-1-vladimir.oltean@nxp.com
Headers show
Series Call phy_config at port probe time for the Felix DSA driver | expand

Message

Vladimir Oltean Aug. 24, 2021, noon UTC 
Changes in v2:
Rebased on top of the master branch (solves this conflict:
https://patchwork.ozlabs.org/project/uboot/patch/20210629170839.2583797-4-olteanv@gmail.com/
with Tim Harvey's patch to make DSA masters promiscuous)

This series makes the Felix DSA driver initialize all its connected PHYs
regardless of whether those will be used for networking or not. This is
in order to satisfy the expectations of some software in later boot
stages.

To make this work, it is necessary to introduce a new method in struct
dsa_ops: .port_probe().

There is some further refactoring/cleanup along the way.

Vladimir Oltean (6):
  net: dsa: felix: felix_init() can be static
  net: dsa: use "err" instead of "ret" in dsa_port_probe
  net: dsa: refactor the code to set the port MAC address into a
    dedicated function
  net: dsa: introduce a .port_probe() method in struct dsa_ops
  net: dsa: felix: call phy_config at .port_probe() time
  net: dsa: felix: propagate the error code from phy_startup()

 drivers/net/mscc_eswitch/felix_switch.c | 28 ++++++-----
 include/net/dsa.h                       |  5 +-
 net/dsa-uclass.c                        | 62 +++++++++++++++----------
 3 files changed, 59 insertions(+), 36 deletions(-)

Comments

Vladimir Oltean Aug. 25, 2021, 11:08 a.m. UTC | #1 
On Tue, Aug 24, 2021 at 03:00:37PM +0300, Vladimir Oltean wrote:
> Changes in v2:
> Rebased on top of the master branch (solves this conflict:
> https://patchwork.ozlabs.org/project/uboot/patch/20210629170839.2583797-4-olteanv@gmail.com/
> with Tim Harvey's patch to make DSA masters promiscuous)
> 
> This series makes the Felix DSA driver initialize all its connected PHYs
> regardless of whether those will be used for networking or not. This is
> in order to satisfy the expectations of some software in later boot
> stages.
> 
> To make this work, it is necessary to introduce a new method in struct
> dsa_ops: .port_probe().
> 
> There is some further refactoring/cleanup along the way.
> 
> Vladimir Oltean (6):
>   net: dsa: felix: felix_init() can be static
>   net: dsa: use "err" instead of "ret" in dsa_port_probe
>   net: dsa: refactor the code to set the port MAC address into a
>     dedicated function
>   net: dsa: introduce a .port_probe() method in struct dsa_ops
>   net: dsa: felix: call phy_config at .port_probe() time
>   net: dsa: felix: propagate the error code from phy_startup()
> 
>  drivers/net/mscc_eswitch/felix_switch.c | 28 ++++++-----
>  include/net/dsa.h                       |  5 +-
>  net/dsa-uclass.c                        | 62 +++++++++++++++----------
>  3 files changed, 59 insertions(+), 36 deletions(-)
> 
> -- 
> 2.25.1
> 

It would be nice if these patches could go in through the networking
tree, I would like to send one more DM_DSA driver and it also needs the
new "port_probe" method introduced by this change set. Thanks.