From patchwork Tue Aug 24 12:00:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 1520249 X-Patchwork-Delegate: rfried.dev@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=TciVUPZq; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Gv74L0lDrz9sSs for ; Tue, 24 Aug 2021 22:01:20 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F387D80A22; Tue, 24 Aug 2021 14:01:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="TciVUPZq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6765782DB6; Tue, 24 Aug 2021 14:01:04 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, MSGID_FROM_MTA_HEADER,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on0615.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe07::615]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8508F81269 for ; Tue, 24 Aug 2021 14:00:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KgRKZpFk1mu+90ZMR1LYksAXqSONrTImQqhnYMZsJ37vdbcPrgmkSlprGpBEFxSb1pPL6dRhbtdLD7UcC2oic3kCGvk+cda4ILOEhR3ZCf2dB4TgD6FXalhffkwjI8wssLVidQuWeIn0xppnOny6Doltic2o5dQS6Ig0L6OxUIrrARNDGMOVBNEVtkH8tHNk3I/sv+cdsx1rvyCHxWIKC8Cenh0Y7g/VPe79172PemaG7BdZzUBLVlG8EBTGjAW/4pTK41gOXr+dO2TWnk6lB6G8UrWTZoU2AU3E5seIlz6x8k3QEynnNKOp955TiksJaAaw2wg8G0nL/3igTtlFWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kYs9jgAoFCqK48yq1kaIemUz9i6Lis1tKMjDjOvS8M0=; b=JQ1GZQztJ4RZjF1QH88RVqOTHKhf4UySnubtJG+yhLyKD5iSLwZBv/rgg+xAcfYG0ZbYPJVjnDQ1ukGZlSokuwCnOw4qtlwW2Ncsz0Kf0EejaNr90N6pIBVU60lhUxFHDwAP56hbGmktXQMpb43uXX9Ib7P83rOj6GQIIN13VItWf8G7/F/e/sk3BgBJlviA3wDThTVdDFUVzeMBVLlTPveE1m+va9nrZMY/X/jtdHRVgGcKwLs9cr9KcV9F+LnhDsghAShX/E2DmRxT37dHX2tI6zqJIYGsw/rwYEmIFGDairkWGBCnOQ+bFMQ8ib4HXZKCL1AAq1FF3s8NP7JEfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kYs9jgAoFCqK48yq1kaIemUz9i6Lis1tKMjDjOvS8M0=; b=TciVUPZqMulZGS6TNALFDSt+35JF7jy17OHkdYJwvWDosazjEHe2KlqWtoOJiBzPFHI79DRWv5OBCzRVePR0LCKLn1msC7q78QnzEXyRiBdVUdcAl8Vcp/D8iVe9x6G1fHOcF/iDq18kVldjZCyNRyjSX6Hl1923MVWCA7OO41o= Authentication-Results: ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VE1PR04MB7374.eurprd04.prod.outlook.com (2603:10a6:800:1ac::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.22; Tue, 24 Aug 2021 12:00:59 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4436.025; Tue, 24 Aug 2021 12:00:59 +0000 From: Vladimir Oltean To: Joe Hershberger , Ramon Fried , u-boot@lists.denx.de Cc: Claudiu Manoil , Michael Walle , Priyanka Jain Subject: [PATCH v2 1/6] net: dsa: felix: felix_init() can be static Date: Tue, 24 Aug 2021 15:00:38 +0300 Message-Id: <20210824120043.3823931-2-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210824120043.3823931-1-vladimir.oltean@nxp.com> References: <20210824120043.3823931-1-vladimir.oltean@nxp.com> X-ClientProxiedBy: PR3P192CA0010.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::15) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (188.25.144.60) by PR3P192CA0010.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Tue, 24 Aug 2021 12:00:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 39f5a1f5-e233-438d-3100-08d966f6d5ff X-MS-TrafficTypeDiagnostic: VE1PR04MB7374: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:381; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hgQB3j4teXM3d9L1kyzKKK75wwJK3tTmogBN1R9mPAxc9xQBRJGGWmvdpvEyfpOF7KVPvxym/ECfYe1l8itGMADE1GOJzRHXbFI+a+xBuV2WD0qDckk/mJdFW6QGXYPbS9dOcP25dRfP6HdwJjJMcz5859qCUreMCY/kC8lMuhvXoy4s2LfPoO1bSNOLccAdB2d1/ET0Q9KYE2r0z1FiXZ/ecWaF7kVu356Th0bsWMgCchopasx0ppa0wj13R7CyVdpohBuUWUZnEnMp3NVCYX3tYALr9mCt9no02gh+lc58yY9Yk/2aYtUG7t71zAdswrkqacu6Da5ZjvIQu8X5rN3odZqRJ3BAQtyPkegQ5/868JE4fWr6agd0tIm1LaHJffX8TbcXOk+zojpC/QaKHAJB/KARUza8os3fqf53/aIKiIRkvkX3gYk8V3UuDQ1m+/btRKZFPIHUC+ZpDJRT0k8WJnv9gY+QjweFJcO0l++yL50QMszwG0iEH8dRvbBnRDFrL+1PXyVQx5dF8cDTr2uhX1U6LrBpg+ocuJCeQ9QH0DPDHfnKmjAU7TqVY/2EDoLyV/iOKchbeRAj1OsfOqbpZMedue4jPxGBH8fw1JEHdIYHfajLZt8GZsF0ca2NNpKgt6D/Q1bFtge7Hn8SLq2jLD5vqdMAhwWGsTajDslriT2wKdEzV7SDxkQQf0gjH3Blij5o18wxFLUYA8ipvw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(396003)(376002)(39850400004)(346002)(110136005)(8936002)(54906003)(316002)(956004)(2906002)(6512007)(6506007)(83380400001)(36756003)(44832011)(478600001)(4326008)(2616005)(66946007)(66556008)(1076003)(6486002)(66476007)(86362001)(6666004)(186003)(38100700002)(38350700002)(4744005)(26005)(8676002)(5660300002)(52116002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NsqWIeHsbwVttBJv1DZJnDUReovDuqFvHfmkgysrjtK5RZO+WAtDyDtv+FsqsFN+LzZAs9+RE0o0N4WsYsmlsLKxwOCKsEHNAzNDA+zAaz6r9wL1417FX3BnHCpJg0JrkDF/+Z7S2JefwXAs/+STm53J9EQeCeW3/4nIIW064lQp3l8nmyEgFP44DnLECvVzdoZbiVlAh4psVi5yge265R3clellj0lshTE4wIL7kFTJF0+fG9YjGx9bYRcc6B9Lxscva/R7knxZZ+IJA7zDMBXZ9Kmj1YNv2qGNDxFOSdbFTNIYwafs+H2byd7/J5Iu0SFnjPzpm/KKInh5TPGF4Vc98TdOSkPxZ3buANQRg62hL+dteV8PgI+IxXaPgxDdxGInhN58VS7iuWnRIWBfekZNKYE2nIv3tZPrYpDKZi8PLfn591SZ+jiggrZhQw9JoWh3N8PBIeFXo0SpZs718FSCDv7rL5eehm1gvLgtwYZqO51M8f6gR6ZKv3OlFuQb9hihjihkLn1EfMwR7PjPiteQfa5+FnUyBp7SbfOzeLwr3+yiIIO58aH3ITIJ/GpLvKNPjeX9EiaPZbx+GrINbZJHpQD4LV0eAK4loculmtgfdIhfMemXMQdFDXaAZvXRzqODqGJ3dlDj1ht1VYNQ9/3kMfAZA3O6+DwC8fqfBMCpW/fh4VLsz3KTKhwCYnYiGwZAC8ATl00ZS56vdUGesBwtLCL5GQ4MrKLeWRff0SIQMFzWiVfqdIivanjsGLFPYbA7oEDeGzsOlitHrSY7KPYvRjnYTFldwyEB5Y5a5d6qi0P5STaObwoKe6e3dXjsdqVB7j1p6Hv0J5qIMXNnppsro/K5OcDnVzA4feOx0aOeLqRnVKq/aX4RiFL8tD0qajkxqWoNcVlDaARFfbme7qFMzBbyRv2XXQeM6SvZtX5YxAiGw8j7WLSpq4fd60s8EUnyeeKBiHBOfwFoEDVggZPmHe1rNtV/DFRjhMaBa1MdghlJUExRrIAfBIUQL9nCZpmimvJM+BlU6WeMedJNPpKTmzvnVYt7A+Mycqb2pXSX9uN4b7J6Rge02TgjHD3/m5zQeH7/96XQZFT+idIwljFAEOxYNTU40oURyLRZjRilWFGwLK62YcIR9UOoZluxHp9SEOOlq68Gu3gDRo/Wi/yztEQHLtS9bZOF/x1LdQoyQCJ3bentbI1eiHEAU2OLQU0t+9VuF/Kabl3qU5Sz1s37hWedK0OsPR0R/p8s/FalZamC8YG47tZYWgakB3zmrG0ZuRpiIf/zLniHPdlv5bFAus4mb4TilbLcDDRiLta7IHr+uWz6WOS+Xn0VLrrg X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39f5a1f5-e233-438d-3100-08d966f6d5ff X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2021 12:00:58.9813 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gCHKBDv81tUvfDhY4OP3nTTTRzwmRe/CWXPloFaGH5VE8X9NqwAqTgETAHx1AbfQU2X381pPrTxuvS4aZrbMrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7374 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean No one is calling this function from outside felix_switch.c. Signed-off-by: Vladimir Oltean Reviewed-by: Ramon Fried Tested-by: Michael Walle --- drivers/net/mscc_eswitch/felix_switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mscc_eswitch/felix_switch.c b/drivers/net/mscc_eswitch/felix_switch.c index f20e84e0f10c..75073880cf87 100644 --- a/drivers/net/mscc_eswitch/felix_switch.c +++ b/drivers/net/mscc_eswitch/felix_switch.c @@ -233,7 +233,7 @@ static void felix_start_pcs(struct udevice *dev, int port, } } -void felix_init(struct udevice *dev) +static void felix_init(struct udevice *dev) { struct dsa_pdata *pdata = dev_get_uclass_plat(dev); struct felix_priv *priv = dev_get_priv(dev); From patchwork Tue Aug 24 12:00:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 1520251 X-Patchwork-Delegate: rfried.dev@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=cUJTx8gl; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Gv74r2ngWz9sSs for ; Tue, 24 Aug 2021 22:01:48 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DD1A982DB6; Tue, 24 Aug 2021 14:01:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="cUJTx8gl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0FA3182DFE; Tue, 24 Aug 2021 14:01:11 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, MSGID_FROM_MTA_HEADER,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on060f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe07::60f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DF6F681F74 for ; Tue, 24 Aug 2021 14:01:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HS7k5oYIfRI4KefoF1y8Z6Z+q/rr85w1iPRWoIiUaCEsDpXMWWv26ZDXBI18KMR4YDBtCv0HbDmd4Z0XrE6giLigiHZJKVzVfvb5rGGSjVU/kaIWsw4lm/slemwKDKcLjXkt9wzP321QJCEB1n/nRTFUdrgwgW/MXRl6hbUy3hrWIQsOmK9cyV9GtI0b8K+4GIP5v4eLR9D+DW/1LaCJMKCvOszjhkgVs8c5dby36KEiyD6G4kmMUqDEbocCa3oqVUtJRQaxyfWI21nS3NtrqPGFFzV/jJ96BY/v6X9BR85jqUQ4YdAtHbxpbjYw4X6PmuZ+wNaJyoZlvaJQmxiy+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yt+BkHPw1pJipYhwRex4nPPWQ0IgfEFInNC5IRPtQgM=; b=CoNmBhXAiM2vW35Kzoit6JHqUu+Uvyl6dJm288wPS2NyK+yxz9xMI2CupUfplkSe2t7UwtsmrG8u51Xl02aB/Y5co/VsF5G0WJ9vdve+0bJiWk4DPPeKTRsaEeyU+OJ0jrXQ0505SD3kzO2lyK+I+rNRWsM91XfrOVMgn/cMDuzN5WxL3HBMXOPvgTjylk4enXYkX5eBfF0CbirT2f8oepSnh9dlpY+Ht93XfxCLl0MBGXGnI3otT8EIwshsObDhBNs3g97TffXvU5xU9LRZWgfvX3LtLnLau1GW1L/j97lVjMGTYCBkgcEJp8v0msJPiEkQwNQq3jBBkx5H600Gcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yt+BkHPw1pJipYhwRex4nPPWQ0IgfEFInNC5IRPtQgM=; b=cUJTx8gl1ZPqQlK2nOgJNXXDdhIHaKICFDlSJE+eA++TuqkJctRwyO2QQiFJ9V7N1Im0uwRb48KYJJ1vQwWwehVWUY3flvVWB0kpkxjC+zelbygi0pPyA1pFWMKsUXsbNcnR1G4b+LewQzNCBQ3GU9FlQg5ktoFm4Mf4caMGyS4= Authentication-Results: ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VE1PR04MB7374.eurprd04.prod.outlook.com (2603:10a6:800:1ac::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.22; Tue, 24 Aug 2021 12:01:00 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4436.025; Tue, 24 Aug 2021 12:01:00 +0000 From: Vladimir Oltean To: Joe Hershberger , Ramon Fried , u-boot@lists.denx.de Cc: Claudiu Manoil , Michael Walle , Priyanka Jain Subject: [PATCH v2 2/6] net: dsa: use "err" instead of "ret" in dsa_port_probe Date: Tue, 24 Aug 2021 15:00:39 +0300 Message-Id: <20210824120043.3823931-3-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210824120043.3823931-1-vladimir.oltean@nxp.com> References: <20210824120043.3823931-1-vladimir.oltean@nxp.com> X-ClientProxiedBy: PR3P192CA0010.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::15) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (188.25.144.60) by PR3P192CA0010.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Tue, 24 Aug 2021 12:00:59 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a2f74c6b-6841-459d-9300-08d966f6d693 X-MS-TrafficTypeDiagnostic: VE1PR04MB7374: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x+CoAdngfFV+eNU2MYLfDn+PamWyIGPPujqLCmpfGy6EHSkHRLcD8x445jcnFPfA8vn35M4R24KPzDLvqq4ogyffvOZ6a352Hplk4BQXbSV2dw7zqavUnzyhBx1xDBlYAJafdAky7AzXKE5s2/4uJaezpq1rOMPYYP/N0HTZ1Ym7s9yptoy1NqIUoGYe+K12k9CgYkUleDxGhCAU8kkvozKncxE3Vhc4BRgbOltuzPeOv3NnGUkZA4wz2nHVPX2sXKUzhPz4RM/XEmSeX795yXemh6yyPUOUBI6B04MXc1hpxD5XnOE1SZsnaf1BLcz4JLbXALpOPddURYB9KzpOskgJAK1kvNsMtOarQNnhuFDglBZsLue9Cc5hE682sd+j7f06XMaSFfs/K9JOi9nfEtjHWRF/zb+XSGYqfLvKVCHFn+tNcOj8VNhoG0WsPnvUKwFSk9MB8uPw3sCfc3NhMHOtlsqQz7LMVrXENOn+Eegsf0qOuheahRdyhiKD74xM/qS2pvRWAQzDIauT9fLOyLdlS9hNVHjWwv1v1PcjSlt5wTPcPxtWP2KHz+cvjqZQXzhKm65qGjsuGrtH3YKubjFV371IwWprrQx5NXvGCfgVJWVBsX+6HBI6DOI7rxSVx2dO3/2eVTAOU20B9AJvnkdBmqd6EE2xg+QQ9XlMOcmpzaIfSfyuQL+liV3n89eNEkfYgd0aszE8AF//cBUrlg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(396003)(376002)(39850400004)(346002)(110136005)(8936002)(54906003)(316002)(956004)(2906002)(6512007)(6506007)(83380400001)(36756003)(44832011)(478600001)(4326008)(2616005)(66946007)(66556008)(1076003)(6486002)(66476007)(86362001)(6666004)(186003)(38100700002)(38350700002)(26005)(8676002)(5660300002)(52116002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: o/R4GDJqOXzpEt+V/QDoaBTTBN+VvMBbI3LSq9vKUvg9qHYqSToHQqFP2tNUrYlBUicxlypHIu/NZgeLGQgVeG24glXNxpE75+MUwDSFRq88ZjU3MdaX7XK2NO7Lf46Q8tZSha+JeYJsEpjhCusA1hKOWBmTLIk4EJM074st2SffYlUbCdeteq/ZtxdNmPBh4kBkia86bR4mKxRODXN2o5o4BRjlx0TA10bfMwM7yTg3F8IeYqNhlGm5g2jV++TFgcR2XmKLYE4iDlUFAiI6VKFQ70+VCfkaq125TLGHv8R6YbvqKY2M0FOoJRrz0Xk51Sn7UnwJmBRT2qJKpKw0YzDAQiJbQ8Sh7zebMNPA9MVSfeqQ2iv+qDy7iI6y5bJbMs1i+K6B4pB6+GZeAQwZfG0QSO0FV0D+lBOMnzHWpQ24uVTQw5bYrmfzx5dc0AClvfsQREUeRf+Ng9KhkLhUids8DaDTUxEYxi+qhRCzwP6IZTGx+up7W8/8Z2sej5PEdjo3jmmekFbHEDBk00LW4OH6hhIXxKjzCwIOxsRLMAIpIiVG4NAR6GGTTruT25hhwdLiyYu7wQp2vbY24XDiZ7ibh8QUbs1Aot3ihIjPLmt07r0JqKMPe17zgkEsyMStQ80ssaLyxKeKswTc5JNt/nG2FXW8vpD5lOKasLw5sOSq7zSq930e10kKg+SZeTuxHX3rGCGqJ8N/2us0TjpmPpD2YPLUq8MThv49BfwhUCjsm2fbQjIYfpH6JAROvUsIzxv7buyozsggbDmWlzMcw1XzquizbjO1cTSFOikwfRBQVAbqIt9Arh/o1ouNoBN8t2EWoxdoNhYxDHskn2LEtoAH0TIst8+aPrh0OYl4jCADoICRHdOZ+jAyyy+aGdm15TUcxfZJvlRArb5VVgd1t7FOJjLBVyJWhhQ3nBFQNEmZITT8fClglxfSoPodu0s/gCtbs0wTrQZB6xp6VnAcP37FOhq3h4bHhQF78RbuPSbmo5fk4w+ShqyKawn+QxhYPazHOpqdUxaWgpD/8f7Bn1nrf+6GyjT4V6SalvD060DPXP0Sm4aQxtnQyGnMOtTMbXbLQrJNeWBeqQ6H5MI1YTSCe4Ck1jD2PCkXVZiQHrwseCIJA2lIDVLFMPEfxF/x/UaXsIzO0NHgsoF47yexblYjTUHd/h7OWl+c9eTxYbAI9K+/pmMjhoJ5XmOqk5LC7wnh2ibjr8O5CJ6tr4uNXzS90QqRl/wEJ8tZbWfz0iDSBtJoJB+G33gNe9nFojSDHdlc0b4y9Q1Gfbn/3nJ6E6S6jdTWTxQQp84OeBCTadLT+HM9Uzm+7Y3kr72PN+O+ X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2f74c6b-6841-459d-9300-08d966f6d693 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2021 12:00:59.9218 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E6AR17FnBOiTiZv/c4o4P+7pk2brgNzdflTvq2nHYA9MxPoZX0OweKknM+GW8HDh3E554Zq+2an2VlS5CeQ3Vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7374 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean DM DSA uses "err" for error code values, so use this consistently. Signed-off-by: Vladimir Oltean Reviewed-by: Ramon Fried Tested-by: Michael Walle --- net/dsa-uclass.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c index 694664d81bbb..f279ca7d2d6c 100644 --- a/net/dsa-uclass.c +++ b/net/dsa-uclass.c @@ -248,7 +248,7 @@ static int dsa_port_probe(struct udevice *pdev) struct dsa_port_pdata *port_pdata; struct dsa_priv *dsa_priv; struct udevice *master; - int ret; + int err; port_pdata = dev_get_parent_plat(pdev); dsa_priv = dev_get_uclass_priv(dev); @@ -268,9 +268,9 @@ static int dsa_port_probe(struct udevice *pdev) * TODO: we assume the master device is always there and doesn't get * removed during runtime. */ - ret = device_probe(master); - if (ret) - return ret; + err = device_probe(master); + if (err) + return err; /* * Inherit port's hwaddr from the DSA master, unless the port already From patchwork Tue Aug 24 12:00:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 1520254 X-Patchwork-Delegate: rfried.dev@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=avEtGLcX; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Gv75f4x57z9sSs for ; Tue, 24 Aug 2021 22:02:30 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3D28E82F2B; Tue, 24 Aug 2021 14:01:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="avEtGLcX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3659E81F74; Tue, 24 Aug 2021 14:01:14 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, MSGID_FROM_MTA_HEADER,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on062c.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe07::62c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B212A82D95 for ; Tue, 24 Aug 2021 14:01:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EYCX7AzoTx26zgEPkd+l1NbgQRoa3zYSMya6CG2skzf6aMuk755cxlfvvtUs6A7g8hCQ73rJM5+WQLMEv5jPJNgqgD5991NI4yxnnC2b2qe6lW58GlNXh0ti7ObpjIrYiM9UDpv2bilwNIssa13gBc/0z5Tq6kmaQdczgK9Xk3pqiHdHmCtspEcAUxSt/FTdkUmgj1S+PbGnCJ3tD79fuFmoUDYhp8TtvoIDPNYCm6q25lfPQhJgm7F8J2IY7Xdbn9CSzjvcfgBxi/oJIkIIkqmBYwLvB2eWp/tF1FiWGOrKpkaItUSn0fAh/vua9160NKU+X09bPoYowpYTCxb+wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YVF7HgPbUL2R8fxWueffX4DoYa2BcYvPKIiCChI0R8Y=; b=BeRIzf1Zs1bqyKWrfEkzTvzBH06Gu/gC8NfOMT1ny1KYDw8/rmSNifyVA2moWT+p96Io+R2z63G2DsdgTn2cqBkX5G8YauQMm0h5JihZp3L1BQZxjNyenqAzCYvxkDUKUIzeqRZrwO7rmVdd8SjNt/jg8YRyj/9qUlA4BUkOHaj8apAOcfXCjoCPyjO+j9f97DTIbAko7/0/Wc5eIkJ+Bdf9s1vYfHNSxBtb5R2i9ejoPbhWBCE3VuGxRnSOgMSU9Efl7AKN5/hV4xq9QkQ9QPlLhlXSa40EsovlFHvgL+LeyzoldPde3tqV9T4gt1+Lz4KSuxuMqKMWkO7tl6zYDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YVF7HgPbUL2R8fxWueffX4DoYa2BcYvPKIiCChI0R8Y=; b=avEtGLcXpio98oQJ62SOjrTUGfK+4e5aQoehJRT8rG1FORqQumdnaZLY3TPeTAWGLGSnpJmrw7tb2kvqhu7I9eg/w3bZiMwSr7mwDqRg5hncSqWNKzYXClR2AC9deZyI4wS3ZbyQgymGditluy6nZi2tLYClwQRMqhwk7EddqvM= Authentication-Results: ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VE1PR04MB7374.eurprd04.prod.outlook.com (2603:10a6:800:1ac::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.22; Tue, 24 Aug 2021 12:01:01 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4436.025; Tue, 24 Aug 2021 12:01:00 +0000 From: Vladimir Oltean To: Joe Hershberger , Ramon Fried , u-boot@lists.denx.de Cc: Claudiu Manoil , Michael Walle , Priyanka Jain Subject: [PATCH v2 3/6] net: dsa: refactor the code to set the port MAC address into a dedicated function Date: Tue, 24 Aug 2021 15:00:40 +0300 Message-Id: <20210824120043.3823931-4-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210824120043.3823931-1-vladimir.oltean@nxp.com> References: <20210824120043.3823931-1-vladimir.oltean@nxp.com> X-ClientProxiedBy: PR3P192CA0010.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::15) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (188.25.144.60) by PR3P192CA0010.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Tue, 24 Aug 2021 12:01:00 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88f2f9b3-3360-4ecb-807e-08d966f6d71e X-MS-TrafficTypeDiagnostic: VE1PR04MB7374: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I2VKgtaDq+JW9GTj7iXNBEgI41ua5sTD4eoYBtgu9fv4J4zTXvgMcVUl3ivkMMEAr0rUo+tIJi1wiLjT77jOZ5EqEs98bbo9ah+u2OtkFf8fr2mo/GDDmbUK/W/a77gZmYJMPw/fw02ZaWbg5nKJq4sM/jzY25HpdGz7xf6R8E15Frx/2Bc4LM37Qy46ljXaCnIC/iTKFD72hsIdlVzbS7SgKFzjypUY6aPwIkk2Mv9PmOt88/fwYekH3yqBnAZ+MQ/AF/DMastiIa1we2pIVOsOscXQSogY7/rUVhOTIt2f9JHbU9xI0pzK/++GMCGfLKbm2y7kIy3i/huvsESOoU9wbHDCdhIbRFBKYXC8JKE70aoVH57ucKlgFP3g16HdplUHyqRah31+tnqcLGguRKZXv5TJB3AYuHamzofh5uGYMIJ8dDl8mPuqv+EeX/ZMjx2NkaahGcwF49auZPf8xqTuY21JxKJzuUMJLLwUiKXDceKPxbQB3su5M0+MkrXsYx5+6kkyFHdVmBw+DhTqKfqMK9OwIr3AfXG3KaE6A7p+fragvZ4JXBELTrcivVxsr9qVWeDsX6aRj9CkFtxeXLh10s4HTn9UaoicxEBRPhghV+zNpVn11Zv69rff9ukF2nBrHxGm8B9ExAe/GtuFwvlYeciKr74j3q8Xn3bj7DJoff11FlMtknMDCNK/COJFLe5LY2YNbWGosnrKLNoDog== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(396003)(376002)(39850400004)(346002)(110136005)(8936002)(54906003)(316002)(956004)(2906002)(6512007)(6506007)(83380400001)(36756003)(44832011)(478600001)(4326008)(2616005)(66946007)(66556008)(1076003)(6486002)(66476007)(86362001)(6666004)(186003)(38100700002)(38350700002)(26005)(8676002)(5660300002)(52116002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ccnSvBTpy91cXUvqoArSV826/2bADpML9i/oeiW3JBW6HLnMXIewOy47HwJAsBfVcnQmnts7aZy/Nt/4OVTPxrgjPfatrj+uEatqPfkx+zlvQJNTTtKhQuQhZbHcATsqR97ljSWQWVtnSwRFss/97Om9tuG9w9Kyt6ZDODrbVo9q1pMU0M4q3sZiG5hpfEPeCMDQdGlT8OM3aj/QjuCjW/gcylgVKYpA3RGuw/Wf1DNMwbL/4x8QEV+dFhWbUq0mEBTfR+UelqYr0mGj7gHy6cfLczIOI4cumlcUN8g3Q+HXqGLIHy7KTHB7oHeAmpCk16ZCdx/fndyhvSRXc1lhtWvF9/+1tIQ7W/tQKjaiVvf+f09xJMDZtXgnoCWosoKhOL2mq+CV7W7Deasua7IdPmlkDxACxc2ZrTzWqJ+TgBifsEYq9GWFv866yCSfAgSyVFAj5YrPuo6oH0/1XY967XM91qS86hSxFlhr6w54YLnh622ZikoMzgb8PDlke3z/rxQtLqDoIpls11gXWQtBo6hHSoHLNo++F1WlKJXN54Z97n+16iXbweDPSVceFACU0XZIrfSA43bkF3GSDCIux2xM64bsAWjBRu+g6E8C34FTs0NIV6WasqoSg8xbsAkULtiTg6JwfSQx2uCoBVhtawBMEvJJgWzmJmXM64K9aeB+p8lHTU1AbJtuTrtRp4t4bIKi4N4sk26wIjlbm8LQ9dfVApdFJ/BwC9ZZxAbDIoAEGzkzTi1wkvQGRWlOXCdhJeUofxjm6kmQGP/xDPUr9dprB/9bHkvtGoCb07DGAiGCR0rMjBgJ2i5yaHtIUIgTRrG4KspsQeow8F4E49Jcoh2hg01m7z8DWhjT/dG0FD/qDLApqb322gUgBZy5lhgAnK3L/ufPgHcEerDWEkKaKWvuZb4wa/cECH81K5KyqepBeVGrHvVfGRFdAZfeLGkXaH1CB7a3jS1yL86/YTm91DC03V+6MWe6wt0P8WVy+nSoycgTVZ+eL2YpVLaZtUdTmfqidqbVnZ3pFCwSraglUNRrc4RR1Xzpta0r2pyB9t4+YQlGNH83vWzDBlH2eqDYV3Q0xpjrHvZQq8cWhpbW+9/xNFjV3GiDL5KsKc9QaqDmV9cab0LGK6mLs/vjj7EaDiCtQn3ktxqPEfiNTrK2iuOEg0fnf/17Al0ZHNkpSmC8TYR+GG0h5pqTtu9pm0wTHL4WBfnn4398jnS7ets76SnXjyaO6ggNaq8cRlEj+NQeXlkYxCX5K1HsjbP7xHvz3Yhw9S5NL/ybaMkMwipLU5s5yjtTlLq0O1gWufDmQ1dpHu6Uh4LNnSNjrGrSp/Bq X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88f2f9b3-3360-4ecb-807e-08d966f6d71e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2021 12:01:00.8193 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1oOq8OGtvmKYt96+Mh8Z1rjT3WcyY4212zpe0nnrvfF+CNAsc+KlF8owR1oBvR8DB7lbkpNO3CiZ0WdXkvG6ug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7374 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean This snippet of code has a bothering "if (...) return 0" in it which assumes it is the last piece of code running in dsa_port_probe(). This makes it difficult to add further code at the end of dsa_port_probe() which does not depend on MAC address stuff. So move the code to a dedicated function which returns void and let the code flow through. Signed-off-by: Vladimir Oltean Reviewed-by: Ramon Fried Tested-by: Michael Walle --- net/dsa-uclass.c | 50 +++++++++++++++++++++++++++--------------------- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c index f279ca7d2d6c..dbd8558b6486 100644 --- a/net/dsa-uclass.c +++ b/net/dsa-uclass.c @@ -240,11 +240,36 @@ static const struct eth_ops dsa_port_ops = { .free_pkt = dsa_port_free_pkt, }; -static int dsa_port_probe(struct udevice *pdev) +/* + * Inherit port's hwaddr from the DSA master, unless the port already has a + * unique MAC address specified in the environment. + */ +static void dsa_port_set_hwaddr(struct udevice *pdev, struct udevice *master) { - struct udevice *dev = dev_get_parent(pdev); struct eth_pdata *eth_pdata, *master_pdata; unsigned char env_enetaddr[ARP_HLEN]; + + eth_env_get_enetaddr_by_index("eth", dev_seq(pdev), env_enetaddr); + if (!is_zero_ethaddr(env_enetaddr)) { + /* individual port mac addrs require master to be promisc */ + struct eth_ops *eth_ops = eth_get_ops(master); + + if (eth_ops->set_promisc) + eth_ops->set_promisc(master, 1); + + return; + } + + master_pdata = dev_get_plat(master); + eth_pdata = dev_get_plat(pdev); + memcpy(eth_pdata->enetaddr, master_pdata->enetaddr, ARP_HLEN); + eth_env_set_enetaddr_by_index("eth", dev_seq(pdev), + master_pdata->enetaddr); +} + +static int dsa_port_probe(struct udevice *pdev) +{ + struct udevice *dev = dev_get_parent(pdev); struct dsa_port_pdata *port_pdata; struct dsa_priv *dsa_priv; struct udevice *master; @@ -272,26 +297,7 @@ static int dsa_port_probe(struct udevice *pdev) if (err) return err; - /* - * Inherit port's hwaddr from the DSA master, unless the port already - * has a unique MAC address specified in the environment. - */ - eth_env_get_enetaddr_by_index("eth", dev_seq(pdev), env_enetaddr); - if (!is_zero_ethaddr(env_enetaddr)) { - /* individual port mac addrs require master to be promisc */ - struct eth_ops *eth_ops = eth_get_ops(master); - - if (eth_ops->set_promisc) - eth_ops->set_promisc(master, 1); - - return 0; - } - - master_pdata = dev_get_plat(master); - eth_pdata = dev_get_plat(pdev); - memcpy(eth_pdata->enetaddr, master_pdata->enetaddr, ARP_HLEN); - eth_env_set_enetaddr_by_index("eth", dev_seq(pdev), - master_pdata->enetaddr); + dsa_port_set_hwaddr(pdev, master); return 0; } From patchwork Tue Aug 24 12:00:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 1520253 X-Patchwork-Delegate: rfried.dev@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=jmzrJMxP; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Gv75N1tQkz9sSs for ; Tue, 24 Aug 2021 22:02:16 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8505082EE0; Tue, 24 Aug 2021 14:01:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="jmzrJMxP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 291EF82EA1; Tue, 24 Aug 2021 14:01:13 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, MSGID_FROM_MTA_HEADER,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on0616.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe07::616]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7C2DE82DBA for ; Tue, 24 Aug 2021 14:01:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bH4JqDZlxmr3fVpF/67ZeWvbJ0KUx1G0CaABsYfcf+NLTgFfHRPHjgJp06xxMxTbgt8TqkHKFQMYHOPFSdefE0AtcXl5OYBWt3tas6y0XU955tskyMXGzE4lUbsCiJfcTpEhBOEfipr3FRWM3xA2UFVKMDEB5A9w4UX/O/vV7Ru1CxWuxysmEgi5oVgd8yRfKcNqbNBo57ccrWT7L6JUX/mvDeGB8mOBk8AnMAszeML9WTR1H7DC5oybI09IPLw3krB+2CBE+uxSGCeXdIxl+lyajXRTRyzYoypFrb3EIk6SZXXV+Xs++x1mwA+lz9/gFpU6YN7+8eZmAWmcGS2oOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PAVUnVuVUxjsTeFZzVO75nycimkRNkB+DFDE42C+zOA=; b=NpEsXhy6eY9pcSRgX9eOw+6QpNWfnvC7iViRc1BKmk9Ox9PvcAK5WCxFbQ5z37M0/Whs2QC1pAp9QOqfMhmK2XiEpyHrOZ6uNs4A2/Cu9H5s9uMYd0bEPMOnKzvx6oFSsdqsDYd02g/eQZ2If3XST0SH8fRqcRqyhpae1yO7t/hmIFVwQO78MpBBlOLjxloTclA50XyXyaVlRvrHcj9+KuTls9YXrju348qbiUBSBYurNBK6+/tBF9IO7C8dUs+rlexM0v9JYce6pbfR/afApJCxZrb7p87uUb0kajPaebVXA0lXjcUeuNysDEvo0b02rtSjbC+OBzR/gcY46B+KvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PAVUnVuVUxjsTeFZzVO75nycimkRNkB+DFDE42C+zOA=; b=jmzrJMxPfgs7MPrs/nqi6iMIPynNoOFE9s5bRxPOJURURRYYBfv6RbSRX7Lso58ZjZJE1YVr7st/VdoqmY0niX9xzAnNiw8cbeBHaF1oP9kqYh5588LPKYizXAXhRSpmbvpcYM2sLPjopIh4Wky5wooLJ5cdFdLJFnrD3OJnB6w= Authentication-Results: ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VE1PR04MB7374.eurprd04.prod.outlook.com (2603:10a6:800:1ac::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.22; Tue, 24 Aug 2021 12:01:01 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4436.025; Tue, 24 Aug 2021 12:01:01 +0000 From: Vladimir Oltean To: Joe Hershberger , Ramon Fried , u-boot@lists.denx.de Cc: Claudiu Manoil , Michael Walle , Priyanka Jain Subject: [PATCH v2 4/6] net: dsa: introduce a .port_probe() method in struct dsa_ops Date: Tue, 24 Aug 2021 15:00:41 +0300 Message-Id: <20210824120043.3823931-5-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210824120043.3823931-1-vladimir.oltean@nxp.com> References: <20210824120043.3823931-1-vladimir.oltean@nxp.com> X-ClientProxiedBy: PR3P192CA0010.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::15) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (188.25.144.60) by PR3P192CA0010.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Tue, 24 Aug 2021 12:01:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b9e8a04e-9ef4-4c30-3a2a-08d966f6d7a6 X-MS-TrafficTypeDiagnostic: VE1PR04MB7374: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PjzU08MlpZnZfNC3QeneOTF1Q56GIGSzalorAdhkMWYLUERHSbUl1loDURmEtSasHX363dU7cMHSXyAkI7qB3PDoKDEnQdtVQrnpl3i9xBgvgAcEilfS05vAXyBYDTFeFjdWyScpRhGR3bfByRSG9l2ubcrjJd1SvCoGEnpkhtX2bMBKbYIzCUsMJIU0M9vxNUaZoTZEiNAu2OEhUN4jTmlbmHzEoF5+2htCHnvleTnxHSH7ZCNUZXPnX1vzBT07qihHfqRhiWY5R7j8YW29olAhB6+FiuT08oWlFhE0NM+89U9+FOxxJwVJSYuY6lH3Z1r+Cg3DaM7evke2aVmUP/5B4ffL0GrtL6FmcS/g2b7DhPwJSYJ8aS1KYPzzMSrRIpdryu6vNSlz3483mgtBvNlupX61Q7bFazSMHZIPLyKs4jVfBIUCojIxRJWVnXx4Svzflk8Avljh9RpdAOahPOpAsEfAD/nd/xxhOx/mGe4bnV9Bj0+sG4Q4u6Cs/Eh88z4/CSp+Zn+s6ymT9aEFP1XynEb5IGxX9LqfRtE+DcxdYxl3XDjSrUJDVlgVF/SeHTkeyEFURxq+HN3Cz/Gd3SKk8US4nHeM0ycSIjgT77UaCDQJpKrA80wUMWY9EZm3v+E9vYyNkDtNQD9IJdGkkAR5/+PV0+Quw/JH5SHEr8jLHURm9UrNkoKvXuTCw8MQME96UuPO+7CqrWFLoWLTH0eX/sWV5XE+6E/3acfsifg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(396003)(376002)(39850400004)(346002)(110136005)(8936002)(54906003)(316002)(956004)(2906002)(6512007)(6506007)(83380400001)(36756003)(44832011)(478600001)(4326008)(2616005)(66946007)(66556008)(1076003)(6486002)(66476007)(86362001)(6666004)(186003)(38100700002)(38350700002)(26005)(8676002)(5660300002)(52116002)(142923001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 987h6IcdLeL0UO9OCrnmG7Dbt+nSxQzzbUl7TGZp2n4vz2LWR5DMCEKnAD3zhXBQavRT18wd24cw+2usiv5U7ECGfExtsd2Ov/9rwJ5oF5Y6GxTZdUBMELWVSu6lmYLlTtZPRMmc6Kpf3jios9kZf+f2a3TyYYk8fSF/9GJJUgl/6Ko0dthd3aa13FJogZdJvk9LfqZaCCWnfw04avITzY6ul9JO3kd/lZg1qxmTneoSJfaIET9ZP+apLkCU+pQjBcm0hOHoESpk/nAPw18nlr/H3FGmrFTayVovPacZVsUYhnc6H2Yz0oDUtXHa1AoP1F/7g65/NYTrs+/+Ki9Uq4gbr2MSHG1+27DTHsMTLBrvtU1fOS74VqsascATAepuXMxAE2wl7jD2Izz1rKrUBMlJqYYwvh23gbSJktTDTX76GN6CAP4d3Z/udAAq4znKt/gaAvyaYwUPjRkp6w3auW7QlfvJmatYf+khaoDpKRGt1Roh+o/E6CzoWw2GbobuoMAaNvaj8Z+SlhfyAj04hPi8KsmbGYbLzRdZtU3VyLkyc518bEaNVql+YU0l51vdiPWbgfJnsW54ew+e9lINJYfFkFyrp8Lmk32q0a8u0svNOI4wzliol41WHjFTxHy1WD0yDwlngioVEHcul9wy1AedAiMIQgO2uFl5y4lvdjo/9dMubITFqiMJIJosabP+zhpf7d3wAwwCSQImcyGnS3GdpaHNwdSXWqJ08Zn8G3Me6Ixv5MiDmPJ+bi0nwW+CQ4RayEh1bH6hq58JJ8cziSPy1jathX26sQGxKQK7PlXRFNGFiBrmMVfoMTcRMIXqNGZNBotpsTH29ww5tzpqQ5upBDhOxdtGQI2OgiMU2zomeFQscEl5+j0mPvEaD4j0ruBnvM4EdQdAdwQ1Px4HKY9/j5QhhoTSy+8jCno861dY18E4Oy3ZeOgVMTbqvX6k5hx8K9ZYXsLgd76j65xMNMfxJse9Qsuo3m3TMWURT+qgC2H+BqwzSTyNDdJmRMjN0ICwpA88+GUL8gABSpGQjceq/9BGXgeC16mULMBOaQkdtAxWUfR6NKRN/Cg2luX0Bg9aifraEby9r3jMF0vzIvUhoCv25s36qqMbL+OwngTUmZA5XAzfkeBnc8o89j6k4pukz+m6Y0ATDsxsgH+5PphxwMpxnV5Oq5u2bM/6OPkeu8ilptyyxNk4FoZr281O5KvUGR02T+r/6lE8gFxuaSNii23Yx7Y0iANzB2cO9fK6broC0iX2vOF0or5Ex4ddGhpQXNXVylOqRxoGSBTUXBpR9LCaAgIC2rkeWceXzvnLPfiNV92MJvmAG26AR21l X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9e8a04e-9ef4-4c30-3a2a-08d966f6d7a6 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2021 12:01:01.7078 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RaLbi/JmtwMmmsfXlD14OTUnQ3KWXQjsRUyEVoT7x7h1fkmwFVR1KLx0nC1RJmuAZVal/QiBwPVJYM/t2IQnhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7374 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Some drivers might want to execute code for each port at probe time, as opposed to executing code just-in-time for the port selected for networking. To cater to that use case, introduce a .port_probe() callback method into the DSA switch operations which is called for each available port, at the end of dsa_port_probe(). Signed-off-by: Vladimir Oltean Reviewed-by: Ramon Fried Tested-by: Michael Walle --- include/net/dsa.h | 5 ++++- net/dsa-uclass.c | 8 ++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/include/net/dsa.h b/include/net/dsa.h index 0f31a908c9d1..ab2a9dfbea2d 100644 --- a/include/net/dsa.h +++ b/include/net/dsa.h @@ -57,7 +57,8 @@ /** * struct dsa_ops - DSA operations * - * @port_enable: Initialize a switch port for I/O. + * @port_probe: Initialize a switch port. + * @port_enable: Enable I/O for a port. * @port_disable: Disable I/O for a port. * @xmit: Insert the DSA tag for transmission. * DSA drivers receive a copy of the packet with headroom and @@ -69,6 +70,8 @@ * master including any additional headers. */ struct dsa_ops { + int (*port_probe)(struct udevice *dev, int port, + struct phy_device *phy); int (*port_enable)(struct udevice *dev, int port, struct phy_device *phy); void (*port_disable)(struct udevice *dev, int port, diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c index dbd8558b6486..9b8ae1e82b92 100644 --- a/net/dsa-uclass.c +++ b/net/dsa-uclass.c @@ -270,6 +270,7 @@ static void dsa_port_set_hwaddr(struct udevice *pdev, struct udevice *master) static int dsa_port_probe(struct udevice *pdev) { struct udevice *dev = dev_get_parent(pdev); + struct dsa_ops *ops = dsa_get_ops(dev); struct dsa_port_pdata *port_pdata; struct dsa_priv *dsa_priv; struct udevice *master; @@ -299,6 +300,13 @@ static int dsa_port_probe(struct udevice *pdev) dsa_port_set_hwaddr(pdev, master); + if (ops->port_probe) { + err = ops->port_probe(dev, port_pdata->index, + port_pdata->phy); + if (err) + return err; + } + return 0; } From patchwork Tue Aug 24 12:00:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 1520255 X-Patchwork-Delegate: rfried.dev@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=Gdaq/ihx; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Gv75t6yr7z9sSs for ; Tue, 24 Aug 2021 22:02:42 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4396182F1A; Tue, 24 Aug 2021 14:02:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="Gdaq/ihx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 262A281E3D; Tue, 24 Aug 2021 14:01:16 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, MSGID_FROM_MTA_HEADER,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0609.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0e::609]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 02C1F82E08 for ; Tue, 24 Aug 2021 14:01:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nhQ8iNRQQZHEqGYserXH9vZ+iPw65W/AnkOFH226/y/QxlWaGxlvKFSNX65OHUr6eJa5MBqM33Ro1DriOYlNI/gkzhu6/WX/MQBlee2eu/IoMgt++24BBhHNgcY5a2lTfP9tsKax0jv954HoWWciohtQ+l9L5rQFhRFqUnoXYX7A6hx4Hfg8nNSUfoNmztHJPzVnsCGDYOWiDSXBAxUuxAA8KUgxLiMS44FCIecZp3jKeoaDgBNYsD0/a+bX70OEx0OPanWpaz+nJDJPcmupjf5H6xyAfCYAQ/IERiwxlGeBvCGpc34ozjwYqh2+FtKXoqtCzrd+CJuQ1ImEsydZZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m817TV3WyUq4D2R0zm/m8iEdLe88NGFju0D5c3ewkwE=; b=maFExKwJT456kuJ5ub2aH1J6MkmdNK2HJBstghuECJxSPycQrDAFl1oxDFJXB5NLW0X0ehaXOd0zIF4OL2zwkGr0xU33dduwSN5Uh1LI1YLFxbgT+jrEjXmqyYH88uJmfl3g7GFEfQbc8NcsfZlJGoe7UJUFSyyeIngNKZvMlJuAcocMVXUlKxnzNUuqJbc3+ah0eVZWqloayZW89n9CesXLy7Q/v+jobNmdy00/KkAmN11DpfGUKRNdwEnPU93pOf1QdcwaY0ESWnXgw7fK8BL9D+ANeVZDFmSpwYQ/rciPJxhJLe8PY3m4vtp8U5X2vIOQ+PaR4wTMHe8Q9k45bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m817TV3WyUq4D2R0zm/m8iEdLe88NGFju0D5c3ewkwE=; b=Gdaq/ihxiL3ERadJblOALCn6Eb6xjC4L/RoGjsszKWHrPX0CpzP+HBkxv/hglQhyKUIwBWeqYUlPXO6ebiRuDDVGnhiTBld0oJXmOTNwOkixJ2w99/b8nitQGJF6MGd6IOvvWJzBzXGrPjWI4x/NHT6GOLVJjXSRpHiT9jyBEhk= Authentication-Results: ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR0401MB2510.eurprd04.prod.outlook.com (2603:10a6:800:54::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.22; Tue, 24 Aug 2021 12:01:02 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4436.025; Tue, 24 Aug 2021 12:01:02 +0000 From: Vladimir Oltean To: Joe Hershberger , Ramon Fried , u-boot@lists.denx.de Cc: Claudiu Manoil , Michael Walle , Priyanka Jain Subject: [PATCH v2 5/6] net: dsa: felix: call phy_config at .port_probe() time Date: Tue, 24 Aug 2021 15:00:42 +0300 Message-Id: <20210824120043.3823931-6-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210824120043.3823931-1-vladimir.oltean@nxp.com> References: <20210824120043.3823931-1-vladimir.oltean@nxp.com> X-ClientProxiedBy: PR3P192CA0010.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::15) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (188.25.144.60) by PR3P192CA0010.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Tue, 24 Aug 2021 12:01:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7e932f7a-babe-46b4-bf57-08d966f6d833 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2510: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eNcHWa1w8kPieoC84x35tO3tLwtVia7Il+xgENLtq/Fp4qrL0b8CKcKNdRcnpfMTwAxus0xe/UXRgriUF2W+0xDPCyM+oWLSxxCx6EvheAHI0OzIW568jVik39qG4+ZxjcrfJ8uHW5k05a2lJ5UhYJ+MgJ4k+Tlpv4DIpz8Y2f4tj448ecVege248b+hXyQ9pzKfqfnVjifNzKfDWJ1h/DTLdpZU85T+JPZDUXNWu+f87sD6FtYb0khAUD4qlhjumZXlvyZn1DlUlO3VWujeg7/Ulf0WMH9I9k8cFOBiGTygBZa8s8Nc4WnNyT7lAmkdMwL+uo65YSx7qDFds/bzvlk5hKDSSw5odOQYsnKuKzJ4zFlk0hoFpJfoRge7taZytVczRthaL6xom2HC0tzMbojEY96wM3CVMU5ZUOfJXM+bQq3St5MRl0GaweL/g2lYB9xie4k1kYiCmn7O3YfaJog7eUovnqUv1KD7JKiUw6s40n5DO/jaDGz1/Zoqba+d6/1rLaGlUVZhpd6pStl+ZZKkp04+6XbKhEWhhH6MD/nYSWV0AhAcbpdyYhQ7oZ2RoYdyOBzScQhFmx0P865Ib1NO4OqbRx1YAIjL+2Od9lZUFjblsY7SKklYM/ciyYrcvlmJsZa99WxBEjYu5HnnQkSGL9d37BW2GXh5zcBWcnk33dlvbqVk3WbDVQAT0baSTdWpfc3I0Nqw28QP5xW7HOdBqZ7Kn+O6r1Y8kc7jAxgEefpzdjQb5g5C5BM6fHK03Vw/t8SO6rOQ4tQqUjW9J/J+FHtdKScQG0zzZPkeO/4GKi5NthdpyPhay4q7XG1V X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(366004)(39860400002)(396003)(136003)(36756003)(186003)(26005)(83380400001)(8676002)(66946007)(66476007)(6666004)(66556008)(86362001)(4326008)(316002)(966005)(5660300002)(478600001)(6486002)(8936002)(54906003)(38100700002)(38350700002)(2906002)(1076003)(6506007)(110136005)(6512007)(956004)(2616005)(52116002)(44832011)(142923001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NCJt0wr/ptu9zCM2+rVEHUpTofaTtILsNjr9RfI4ZlxiPVL6aSCF19uoO11/uHSgOliASicggDdCbB7kSREAXkBDxiV2fiyGpRbalxf2MqXPt/9IgRLfBGjPu9omViCHnIWQ6i799F+D5bhyeYaNcohfEd/xiJcLa2dvhmiyVdcCHlkgsAs7f25BegW5rhf7EM/ID4uwdj9otxO7YkYb+Ii0+P1FOq320JxsEZR5ySiIFD4vunB32eeVUucSVhxtYzaU0cGxWDYDwHiLvcooHjemlPmL0Wj/+wbuxeZdFR18gMx0vJvhhJtiJsRL2PyAcCwc2gXtLfof3+qYuymxvp2AjjfgN4WlzuzTmQ4VeZdIuWDa6m/Q/7RwRFXOBfAu7JBXXIZLn60q9sPbr+KMpgGSJmuR5d3bHsdptTL+5CUGSt6577XG1gITBOMkXcjDjIaOzwSK+XngeW1JJB944VbNWnn1/BbQejnwWZi9l3lrnEBCHgWtDkke9DyE7uoa3A7iFpbTgsBU+J4KEgTbzjpYfg9QkM4DDHvYOsxSOTICqj3Qr/kDYyxSyBJIUJPzAWqx2uhMGlRioqe+Iby9U03ubOk/bkk8xx2u5AjiqrVBMlaTa9RaZxinnCuQNmLfBpwJrz5PTqpf22Qw8M5Unlxni1lNfikwQueIjixPuvVRViCcN9SeO+JizrvQ3kT/err+Xa3ByYNhbDIJyfcvMK7QSr4gRU9fXjKwrEIM6yRJTSlSYmEna+eyy7uZtkyYLPAKUgrNoSfLaylKk2Gvc/nZk+nAaxxs1NVpgZozu4EtVJqkFz/aR1Xr7e7uYmzr70YYw1pnW/usIln8gODFaPnoTEbgTdqrriixjIuXQybli67GSbNsEVDCfZ7S5PHDO5tZWH0GFpi3/BA/tcECz0enzYLPewxXrQEZjP1YGMiLucEzteYK3fU+Ie7m9s8MfxdNM7C1kGk07LZM5ISsRAzprwtuiaSn7gRtmvayktAtEC4eVxlptqgT2iPA7vURN8AcWfCk+pxhKGmg9E9O489303j2ow/gHrD5cGLozlvPRuhPU9PHN56RsvKL1H+hj8Yo4j0cbggZncYBtGPRqxWFJFa9/+pI5cZfNG4hybk4buevsiTALu8EnB425HUoFJD0fTG2P+1skxwtm3qhPvFR7owwVK+Ly/p2nYNGu/DFJHtsSWN62yMc8VYJdTrKWffA+PzVbu/UECPbTgSyonNpNuTdvO3WjPxXy1Cno1DWL6ruWOGZFd2jd3whAZOXf0VHdhkgyISf4Qr6bemGEBr1nsThAy1NssozA9MFRxB8Y5szuBg2urcXzxn9z7AR X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e932f7a-babe-46b4-bf57-08d966f6d833 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2021 12:01:02.6352 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nB1HzgqWaKo4H0XdkQl1CjnWiq7oaHCFEpbWxeP8Dg0nWO4Zy/vb2Ecmg9TfsD30ezWl3OKm4sutIupzq7bB6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2510 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean It is an unfortunate reality that some PHY settings done by U-Boot persist even after the PHY is reset and taken over by Linux, and even more unfortunate that Linux has come to depend on things being set in a certain way. For example, on the NXP LS1028A-RDB, the felix switch ports are connected to a VSC8514 QSGMII PHY. Between the switch port PCS and the PHY, the U-Boot drivers enable in-band auto-negotiation which makes the copper-side negotiated speed and duplex be transmitted from the PHY to the MAC automatically. The PHY driver portion that does this is in vsc8514_config(): /* Enable Serdes Auto-negotiation */ phy_write(phydev, MDIO_DEVAD_NONE, PHY_EXT_PAGE_ACCESS, PHY_EXT_PAGE_ACCESS_EXTENDED3); val = phy_read(phydev, MDIO_DEVAD_NONE, MIIM_VSC8514_MAC_SERDES_CON); val = val | MIIM_VSC8574_MAC_SERDES_ANEG; phy_write(phydev, MDIO_DEVAD_NONE, MIIM_VSC8514_MAC_SERDES_CON, val); The point is that in-band autoneg should be turned on in both the PHY and the MAC, or off in both the PHY and the MAC, otherwise the QSGMII link will be broken. And because phy_config() is currently called at .port_enable() time, the result is that ports on which traffic has been sent in U-Boot will have in-band autoneg enabled, and the rest won't. It can be argued that the Linux kernel should not assume one way or another and just reinitialize everything according to what it expects, and that is completely fair. In fact, I've already started an attempt to remove this dependency, although admittedly I am making slow progress at it: https://patchwork.kernel.org/project/netdevbpf/cover/20210212172341.3489046-1-olteanv@gmail.com/ Nonetheless, the sad reality is that NXP also has, apart from kernel drivers, some user space networking (DPDK), and for some reason, the expectation there is that somebody else initializes the PHYs. The kernel can't do it because the device ownership doesn't belong to the kernel, so what remains is for the bootloader to do it (especially since other drivers generally call phy_config() at probe time). This is a really weak guarantee that might break at any time, but apparently that is enough for some. Since initializing the ports and PHYs at probe time does not break anything, we can just do that. Signed-off-by: Vladimir Oltean Reviewed-by: Ramon Fried Tested-by: Michael Walle --- drivers/net/mscc_eswitch/felix_switch.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/net/mscc_eswitch/felix_switch.c b/drivers/net/mscc_eswitch/felix_switch.c index 75073880cf87..c8ecf4f19442 100644 --- a/drivers/net/mscc_eswitch/felix_switch.c +++ b/drivers/net/mscc_eswitch/felix_switch.c @@ -317,10 +317,23 @@ static int felix_probe(struct udevice *dev) return 0; } +static int felix_port_probe(struct udevice *dev, int port, + struct phy_device *phy) +{ + int supported = PHY_GBIT_FEATURES | SUPPORTED_2500baseX_Full; + struct felix_priv *priv = dev_get_priv(dev); + + phy->supported &= supported; + phy->advertising &= supported; + + felix_start_pcs(dev, port, phy, &priv->imdio); + + return phy_config(phy); +} + static int felix_port_enable(struct udevice *dev, int port, struct phy_device *phy) { - int supported = PHY_GBIT_FEATURES | SUPPORTED_2500baseX_Full; struct felix_priv *priv = dev_get_priv(dev); void *base = priv->regs_base; @@ -339,12 +352,6 @@ static int felix_port_enable(struct udevice *dev, int port, FELIX_QSYS_SYSTEM_SW_PORT_LOSSY | FELIX_QSYS_SYSTEM_SW_PORT_SCH(1)); - felix_start_pcs(dev, port, phy, &priv->imdio); - - phy->supported &= supported; - phy->advertising &= supported; - phy_config(phy); - phy_startup(phy); return 0; @@ -392,6 +399,7 @@ static int felix_rcv(struct udevice *dev, int *pidx, void *packet, int length) } static const struct dsa_ops felix_dsa_ops = { + .port_probe = felix_port_probe, .port_enable = felix_port_enable, .port_disable = felix_port_disable, .xmit = felix_xmit, From patchwork Tue Aug 24 12:00:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 1520252 X-Patchwork-Delegate: rfried.dev@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=KP99r2MY; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Gv7562PDxz9sSs for ; Tue, 24 Aug 2021 22:02:02 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 72B4782EBB; Tue, 24 Aug 2021 14:01:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="KP99r2MY"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0B1A382CDE; Tue, 24 Aug 2021 14:01:15 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, MSGID_FROM_MTA_HEADER,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0609.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0e::609]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2C5BA82E1B for ; Tue, 24 Aug 2021 14:01:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JKrOpxGC/ScYssWKobr2YmpNSWm1k1bXEACvFh9pRVchLM9t4YC0L5wKjjuSbBYl6ssXS7XxQoh7Jv7KF1m+kQREdTdaNooubngetTm5D6HPrJOKD0oRv28rKITm1nwk8ZG7BT/NTCsHf3+CUBi9/22vC5vbNj9inN76990lLP3fVinZXU9WnOxOg9l7ge6F5zJN78Cz1zDaiFaQPUtybUIC3jA7xN8dscSsiqVQZ7qRs+CBqvhkRq+rTKxmyBqHM1E4ad6quSzI3TbmGv6q0ETsO5I0ELt274lg5BISwkGyp194o7fnuwsTSPcrSTbXXiGPR7puyktAcTFpGCZOFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KkJy+E1PLozMf1obvPLwjC1B4xVB6QIIdyNrWEa/rWg=; b=gRzAHikshT0IoBzUWnDTc9A1qX8ruhRKZ4IzV1AGBdg4/TCwQrGh5dstfPFntNYf0yBrABE9q3lmSGJU6HGcYL+7b6M3KFlf7Z4bU/YbHNjRqAU4h5GgX0Oah7M9NAL72FNPIQ7p6hQDKb0t98Oskhd8dCsWZaNKikJiVku2axp0si16sgNVGCzJtrFYwvmcr436Qa9/6GqL7HnxzKWVjkxwkrBk3IHtkEYZxeLrsPJn4jEWBOytjdwtAo0zm0AONUS+cMU4ja/WWzYorXy3wcUcrK5kBgg9X3TUoc8zMnaIJ7shkidrcdsVGbL09hFYsXiPo3EHYpBI5E7DQqmMLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KkJy+E1PLozMf1obvPLwjC1B4xVB6QIIdyNrWEa/rWg=; b=KP99r2MYENZ/JRy7l3OgjeINv8yJTM4TzSmAVeGgbDy/kPQz5xY6irmrq3LeVbS3CnOX0Cp9vKEKyCITl5he1WFbpoXbzAz05lOnaV3zzNX6HcHSd0yMuXXRdpQMa0rvaZC8aGGHffTl04M+HjOCg8pKyvzkZUx9vtAePKR79dE= Authentication-Results: ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR0401MB2510.eurprd04.prod.outlook.com (2603:10a6:800:54::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.22; Tue, 24 Aug 2021 12:01:03 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4436.025; Tue, 24 Aug 2021 12:01:03 +0000 From: Vladimir Oltean To: Joe Hershberger , Ramon Fried , u-boot@lists.denx.de Cc: Claudiu Manoil , Michael Walle , Priyanka Jain Subject: [PATCH v2 6/6] net: dsa: felix: propagate the error code from phy_startup() Date: Tue, 24 Aug 2021 15:00:43 +0300 Message-Id: <20210824120043.3823931-7-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210824120043.3823931-1-vladimir.oltean@nxp.com> References: <20210824120043.3823931-1-vladimir.oltean@nxp.com> X-ClientProxiedBy: PR3P192CA0010.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::15) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (188.25.144.60) by PR3P192CA0010.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Tue, 24 Aug 2021 12:01:02 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f7e0903-f6f9-491c-21f8-08d966f6d8bf X-MS-TrafficTypeDiagnostic: VI1PR0401MB2510: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1360; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q1g/L8Tndtg3wzWTeaiO0l8Z5sBiMkCWD94Lqoag4/WjILjwkthTlj+EixhQgy2daxeNQqIXRtT6Y7HykUpcPuDnPqjNDNbji9EkYUfJvQT18HJiJgtbs3DH1w02niXRDvWa0vBIi59Wp45cNL6X570yKQPQSZoJlBupLIWKf4kotAmJgl4qRC3SZvC8Vzh8oNVmqr5vvowuBHiM4vRGsRuEjgxa/1xLUF4o+PhOVVDze4kKxP4L3RL/eQfkPmG1YJ14ff9JhuVsDOH2BrqplesddeWAf/fdNDXaAh/sCu2QL794RSSVuLiLAZSwEnQIXx6w3eKbzsWMd5y+vaxnGLm58UHFzoUQ8/G0szVb9/L+PmjzqySqL1XyAaxgp87SprcUHgH0zmzLuv+MC7piDngWuM5b5vlwjhwNW5N4rVNVwTdOcDRTZrE0v3T8Eg9y5TrJHvPkByiU3AygSmdSY5e5wrAfUCZxX3nf9ZVY7wyVyMRgXDG96Kw9FyW/pSlGRGw1JJSITVHrAPKP0G2XjsHPNNM/grZSEspfHUL5Crg8fgqdaE4lR01SUjee9Nja7jdnHkLFoqTEk2UanwUiOzqmSxhAW0I3R5gFYyUMXenSLbnk/VaHWe/3KC6/lBjmJqexl+6lnSUj4gGXJ1VZ6gmyL8sO7a3JgULCRg8WD1OL4XFvMOUDOU0jZ48S2kd3fQlCYyk23xNABlxsXlVsSA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(366004)(39860400002)(396003)(136003)(36756003)(186003)(26005)(4744005)(83380400001)(8676002)(66946007)(66476007)(6666004)(66556008)(86362001)(4326008)(316002)(5660300002)(478600001)(6486002)(8936002)(54906003)(38100700002)(38350700002)(2906002)(1076003)(6506007)(110136005)(6512007)(956004)(2616005)(52116002)(44832011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rED4jx0iH8IT+qShuvQXJ63PlQoUBfoRfoR1CtLQURUtcGJHlA8fvuN+xXqJzeyXVqNo03aV5yZLRJPO/SDG5jUFHjUZOS6EkhCkmLssYlrteS4+QoYXubnz7Vc3qLkyxBzsZfCuP86o5SxbZduPTTNlIuTQUTgimeul1mkg5dPv+lBnkv+KytzRZE7NRKYaGgjePLIYETU6iF1Y3tjmqJ/wWBSvM/PX8df+oKiiEFUk+iBtN2OnJcsUXEZj6mF9IqGtKdKKWITP7TLmiAFmAdBDzh73gFIJRlelYi9sgCPrGpoZOwtWsBaqU1k/fqoyQ0rqADHQPmRMOiEiJixmDiN5qYo+Kb//msMg9TjJXsvY4K4X4sxQqQSSfylBH7E6NcyhWqdncrh2C5xaMqmaEPpYkv7wz/T03Nfa/rB51aR+de0IuaNJd2jnZcOwXDoKDnn2u8+KCU/JKC82nvgjZ5nkqvQvQHju4/p4ftwwHus6AcA98390aPZZ94qB47OvNRSJeS5p6U7yIH7X3q4lq5LJJtons2SOy2XxHNUws6GNqzIjtfsY5U3TiLXPfqxq6lf++XOn2PesA0ylThk8orD7Juvbv3SWSdUDPnzRLAaqsJeFS8CcsGEGCTOvHiJnB3Bb7h/S3TS3GYn4F8vl/5sxEVIPSOJvzJ62poLVs3ToVuvU1elvoInnZNPrCrHGjIpSnS3BCtWVBrUgl77TGcVRq0FQOnNpNjCHyjNhXPkaf2KkCQnPl3oq7pXedSCvDw9KkUkYkZ9qi0W9kLffGOWvHiSDiOfhHjgKikzbalIdb0lswXnfElxEXVMfsdsULhEjz5yUZYYpWoaw2P8q78eIeScEC2j8qLAtsjNYiM7yZ7Jg5gft1DKU5s6mizOTlXTweU04/XTpEw12F2zbOrIFTY7VuerOuksa8zz7Fu77Ym/IKHoD/vfUnjLh7ZhfGcBdsHRAWek8rfPs5as8OEV75cm04ED3oNOQBrmZl4wCekaa6bVHEdF2xKIh2LHfGW/ntUQClTGi9sGvJXgScrOMKuKKKmVNOQEaqaLRG4p1J3/BdIFz2zspfEywGcP97IIz07fetpnSov7/7qA27Khbi2CfclKvSG9rBPqg+13SUrZdjGjIt4H3CqhuW1EH9aZQrr4V3SkQWbEaxDjdzRFEvB0r6zwGIFKqg1iDdqk3T1+NVXN4Mw2vZlz+wN+TFPJQflRxkyyan8HSGv/dDC4uzQzhZJXX739tFSm06STZW1FJLZRHpM0BaohfotiDK5Wf6cbpfnOtEeuzEO6UyX+NFEpJtiSXyyb+jjgsNFoiKbxKQZA1Nz2HZn86erR5 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f7e0903-f6f9-491c-21f8-08d966f6d8bf X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2021 12:01:03.5617 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tr+/5JeIs/fv07wA0hwYOLsDSM3NZfVSNtjuidQeKQq4SbFupQmnHDWSGSQ3pNpVoJ2sMm1fiyhnzP2F6/0gKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2510 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Make sure that the link status returned by phy_startup() is propagated to the .start() method of struct eth_ops. Signed-off-by: Vladimir Oltean Reviewed-by: Ramon Fried Tested-by: Michael Walle --- drivers/net/mscc_eswitch/felix_switch.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/mscc_eswitch/felix_switch.c b/drivers/net/mscc_eswitch/felix_switch.c index c8ecf4f19442..6aa79784460d 100644 --- a/drivers/net/mscc_eswitch/felix_switch.c +++ b/drivers/net/mscc_eswitch/felix_switch.c @@ -352,9 +352,7 @@ static int felix_port_enable(struct udevice *dev, int port, FELIX_QSYS_SYSTEM_SW_PORT_LOSSY | FELIX_QSYS_SYSTEM_SW_PORT_SCH(1)); - phy_startup(phy); - - return 0; + return phy_startup(phy); } static void felix_port_disable(struct udevice *dev, int pidx,