mbox series

[U-Boot,v3,0/3] Most rockchip platform based boards use a key to instruct

Message ID 1507705170-10619-1-git-send-email-andy.yan@rock-chips.com
Headers show
Series Most rockchip platform based boards use a key to instruct | expand

Message

Andy Yan Oct. 11, 2017, 6:59 a.m. UTC
the board enter download firmware mode, some boards use a
adc to detect the key status, and some use a gpio.

This series try to implement all the download mode related
functions on the base of Dr. Philipp's patch[0].

[0]https://lists.denx.de/pipermail/u-boot/2017-October/309060.html

Changes in v3:
- add support for rk3188
- rebase on Dr. Philipp's series

Changes in v2:
- correct the rk322x boot mode register address
- make the help text more clear
- implement the back to bootrom download mode check in c,
  thanks for Dr. Philipp Tomsich's suggestion.
- more document
- move adc key detect as the default

Andy Yan (3):
  rockchip: make boot_mode related codes reused across all platforms
  rockchip: add support for enter to bootrom download mode
  rockchip: check download key before bootup

 arch/arm/include/asm/arch-rockchip/boot_mode.h |  6 ++
 arch/arm/mach-rockchip/Kconfig                 | 16 ++++++
 arch/arm/mach-rockchip/Makefile                |  6 ++
 arch/arm/mach-rockchip/boot_mode.c             | 76 ++++++++++++++++++++++++++
 arch/arm/mach-rockchip/bootrom.c               | 47 +++++++++++++++-
 arch/arm/mach-rockchip/rk3036-board.c          | 24 --------
 arch/arm/mach-rockchip/rk3188-board.c          |  1 +
 arch/arm/mach-rockchip/rk322x-board.c          | 24 --------
 arch/arm/mach-rockchip/rk3288-board.c          | 25 ---------
 arch/arm/mach-rockchip/rk3399-board.c          | 14 +++++
 10 files changed, 164 insertions(+), 75 deletions(-)
 create mode 100644 arch/arm/mach-rockchip/boot_mode.c
 create mode 100644 arch/arm/mach-rockchip/rk3399-board.c

Comments

Andy Yan Nov. 17, 2017, 10:09 a.m. UTC | #1
Hi Philipp:

     Please remember to take this series if they are looks ok for you. 
And if you have questions about them, please let me know.


On 2017年10月11日 14:59, Andy Yan wrote:
> the board enter download firmware mode, some boards use a
> adc to detect the key status, and some use a gpio.
>
> This series try to implement all the download mode related
> functions on the base of Dr. Philipp's patch[0].
>
> [0]https://lists.denx.de/pipermail/u-boot/2017-October/309060.html
>
> Changes in v3:
> - add support for rk3188
> - rebase on Dr. Philipp's series
>
> Changes in v2:
> - correct the rk322x boot mode register address
> - make the help text more clear
> - implement the back to bootrom download mode check in c,
>    thanks for Dr. Philipp Tomsich's suggestion.
> - more document
> - move adc key detect as the default
>
> Andy Yan (3):
>    rockchip: make boot_mode related codes reused across all platforms
>    rockchip: add support for enter to bootrom download mode
>    rockchip: check download key before bootup
>
>   arch/arm/include/asm/arch-rockchip/boot_mode.h |  6 ++
>   arch/arm/mach-rockchip/Kconfig                 | 16 ++++++
>   arch/arm/mach-rockchip/Makefile                |  6 ++
>   arch/arm/mach-rockchip/boot_mode.c             | 76 ++++++++++++++++++++++++++
>   arch/arm/mach-rockchip/bootrom.c               | 47 +++++++++++++++-
>   arch/arm/mach-rockchip/rk3036-board.c          | 24 --------
>   arch/arm/mach-rockchip/rk3188-board.c          |  1 +
>   arch/arm/mach-rockchip/rk322x-board.c          | 24 --------
>   arch/arm/mach-rockchip/rk3288-board.c          | 25 ---------
>   arch/arm/mach-rockchip/rk3399-board.c          | 14 +++++
>   10 files changed, 164 insertions(+), 75 deletions(-)
>   create mode 100644 arch/arm/mach-rockchip/boot_mode.c
>   create mode 100644 arch/arm/mach-rockchip/rk3399-board.c
>
Philipp Tomsich Nov. 17, 2017, 10:19 a.m. UTC | #2
Andy,

Thanks for the reminder.
I had this on my list as one of the next ones to be merged.

Cheers,
Philipp.

> On 17 Nov 2017, at 11:09, Andy Yan <andy.yan@rock-chips.com> wrote:
> 
> Hi Philipp:
> 
>     Please remember to take this series if they are looks ok for you. And if you have questions about them, please let me know.
> 
> 
> On 2017年10月11日 14:59, Andy Yan wrote:
>> the board enter download firmware mode, some boards use a
>> adc to detect the key status, and some use a gpio.
>> 
>> This series try to implement all the download mode related
>> functions on the base of Dr. Philipp's patch[0].
>> 
>> [0]https://lists.denx.de/pipermail/u-boot/2017-October/309060.html
>> 
>> Changes in v3:
>> - add support for rk3188
>> - rebase on Dr. Philipp's series
>> 
>> Changes in v2:
>> - correct the rk322x boot mode register address
>> - make the help text more clear
>> - implement the back to bootrom download mode check in c,
>>   thanks for Dr. Philipp Tomsich's suggestion.
>> - more document
>> - move adc key detect as the default
>> 
>> Andy Yan (3):
>>   rockchip: make boot_mode related codes reused across all platforms
>>   rockchip: add support for enter to bootrom download mode
>>   rockchip: check download key before bootup
>> 
>>  arch/arm/include/asm/arch-rockchip/boot_mode.h |  6 ++
>>  arch/arm/mach-rockchip/Kconfig                 | 16 ++++++
>>  arch/arm/mach-rockchip/Makefile                |  6 ++
>>  arch/arm/mach-rockchip/boot_mode.c             | 76 ++++++++++++++++++++++++++
>>  arch/arm/mach-rockchip/bootrom.c               | 47 +++++++++++++++-
>>  arch/arm/mach-rockchip/rk3036-board.c          | 24 --------
>>  arch/arm/mach-rockchip/rk3188-board.c          |  1 +
>>  arch/arm/mach-rockchip/rk322x-board.c          | 24 --------
>>  arch/arm/mach-rockchip/rk3288-board.c          | 25 ---------
>>  arch/arm/mach-rockchip/rk3399-board.c          | 14 +++++
>>  10 files changed, 164 insertions(+), 75 deletions(-)
>>  create mode 100644 arch/arm/mach-rockchip/boot_mode.c
>>  create mode 100644 arch/arm/mach-rockchip/rk3399-board.c
>> 
> 
>