Message ID | 20230201143431.863784-2-frieder@fris.de |
---|---|
State | Rejected |
Headers | show |
Series | Enable backup switch mode on RTCs via devicetree | expand |
On Wed, 01 Feb 2023 15:34:23 +0100, Frieder Schrempf wrote: > From: Frieder Schrempf <frieder.schrempf@kontron.de> > > The RV3028 driver uses properties that are not covered by the > trivial-rtc bindings. Use custom bindings for it. > > Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> > --- > .../bindings/rtc/microcrystal,rv3028.yaml | 56 +++++++++++++++++++ > .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 - > 2 files changed, 56 insertions(+), 2 deletions(-) > create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/rtc/microcrystal,rv3028.example.dts:23.20-29.15: Warning (i2c_bus_reg): /example-0/i2c/rtc@51: I2C bus unit address format error, expected "52" doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230201143431.863784-2-frieder@fris.de The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 01/02/2023 15:34, Frieder Schrempf wrote: > From: Frieder Schrempf <frieder.schrempf@kontron.de> > > The RV3028 driver uses properties that are not covered by the > trivial-rtc bindings. Use custom bindings for it. > > Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> > --- > .../bindings/rtc/microcrystal,rv3028.yaml | 56 +++++++++++++++++++ > .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 - > 2 files changed, 56 insertions(+), 2 deletions(-) > create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > new file mode 100644 > index 000000000000..4667ba86fd0c > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/microcrystal,rv3028.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip RV-3028 RTC > + > +allOf: > + - $ref: "rtc.yaml#" Drop quotes > + > +maintainers: > + - Alexandre Belloni <alexandre.belloni@bootlin.com> > + > +properties: > + compatible: > + const: microcrystal,rv3028 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + start-year: true This should be dropped as well and then... > + > + trickle-resistor-ohms: > + enum: > + - 3000 > + - 5000 > + - 9000 > + - 15000 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false ...switch to unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc@51 { Rob's pointed missing testing. But more important - please rebase your patches on current tree. Looks like all the changes are already done... Best regards, Krzysztof
On 02.02.23 10:10, Krzysztof Kozlowski wrote: > On 01/02/2023 15:34, Frieder Schrempf wrote: >> From: Frieder Schrempf <frieder.schrempf@kontron.de> >> >> The RV3028 driver uses properties that are not covered by the >> trivial-rtc bindings. Use custom bindings for it. >> >> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> >> --- >> .../bindings/rtc/microcrystal,rv3028.yaml | 56 +++++++++++++++++++ >> .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 - >> 2 files changed, 56 insertions(+), 2 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml >> >> diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml >> new file mode 100644 >> index 000000000000..4667ba86fd0c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml >> @@ -0,0 +1,56 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: https://eur04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Frtc%2Fmicrocrystal%2Crv3028.yaml%23&data=05%7C01%7Cfrieder.schrempf%40kontron.de%7Ca99c626bce484657aee508db04fd470f%7C8c9d3c973fd941c8a2b1646f3942daf1%7C0%7C0%7C638109258107205830%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=z8nsgRaxC3AcIoXteA7Xj7EpCKrA%2FkRPyrYeS1fig8I%3D&reserved=0 >> +$schema: https://eur04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cfrieder.schrempf%40kontron.de%7Ca99c626bce484657aee508db04fd470f%7C8c9d3c973fd941c8a2b1646f3942daf1%7C0%7C0%7C638109258107205830%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=1RPGw%2FEf7UUNrJZPAHDw7BHnuroLg1oVR4xLq2%2FgIHU%3D&reserved=0 >> + >> +title: Microchip RV-3028 RTC >> + >> +allOf: >> + - $ref: "rtc.yaml#" > > Drop quotes > >> + >> +maintainers: >> + - Alexandre Belloni <alexandre.belloni@bootlin.com> >> + >> +properties: >> + compatible: >> + const: microcrystal,rv3028 >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + start-year: true > > This should be dropped as well and then... > >> + >> + trickle-resistor-ohms: >> + enum: >> + - 3000 >> + - 5000 >> + - 9000 >> + - 15000 >> + >> +required: >> + - compatible >> + - reg >> + >> +additionalProperties: false > > ...switch to unevaluatedProperties: false > >> + >> +examples: >> + - | >> + #include <dt-bindings/interrupt-controller/irq.h> >> + i2c { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + rtc@51 { > > Rob's pointed missing testing. > > But more important - please rebase your patches on current tree. Looks > like all the changes are already done... Oops, I need to remember to check patchwork/linux-next. Thanks anyway!
diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml new file mode 100644 index 000000000000..4667ba86fd0c --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/microcrystal,rv3028.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Microchip RV-3028 RTC + +allOf: + - $ref: "rtc.yaml#" + +maintainers: + - Alexandre Belloni <alexandre.belloni@bootlin.com> + +properties: + compatible: + const: microcrystal,rv3028 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + start-year: true + + trickle-resistor-ohms: + enum: + - 3000 + - 5000 + - 9000 + - 15000 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + rtc@51 { + compatible = "microcrystal,rv3028"; + reg = <0x52>; + pinctrl-0 = <&rtc_nint_pins>; + interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>; + trickle-resistor-ohms = <3000>; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml index d9fc120c61cc..84cce1f0ca0c 100644 --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml @@ -48,8 +48,6 @@ properties: # Intersil ISL12022 Real-time Clock - isil,isl12022 # Real Time Clock Module with I2C-Bus - - microcrystal,rv3028 - # Real Time Clock Module with I2C-Bus - microcrystal,rv3029 # Real Time Clock - microcrystal,rv8523