diff mbox series

[4/7] rtc: Move BSM defines to separate header for DT usage

Message ID 20230201143431.863784-5-frieder@fris.de
State Rejected
Headers show
Series Enable backup switch mode on RTCs via devicetree | expand

Commit Message

Frieder Schrempf Feb. 1, 2023, 2:34 p.m. UTC 
From: Frieder Schrempf <frieder.schrempf@kontron.de>

To be able to use the BSM defines in the devicetree, move the defines
to a separate header within the dt-bindings directory.

Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
 include/dt-bindings/rtc/rtc.h | 11 +++++++++++
 include/uapi/linux/rtc.h      |  6 +-----
 2 files changed, 12 insertions(+), 5 deletions(-)
 create mode 100644 include/dt-bindings/rtc/rtc.h

Comments

kernel test robot Feb. 2, 2023, 11:22 p.m. UTC | #1 
Hi Frieder,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on arm/for-next arm/fixes arm64/for-next/core kvmarm/next rockchip/for-next shawnguo/for-next soc/for-next xilinx-xlnx/master linus/master v6.2-rc6]
[cannot apply to abelloni/rtc-next next-20230202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Frieder-Schrempf/dt-bindings-rtc-Move-RV3028-to-separate-binding-file/20230201-224450
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20230201143431.863784-5-frieder%40fris.de
patch subject: [PATCH 4/7] rtc: Move BSM defines to separate header for DT usage
config: x86_64-randconfig-a004 (https://download.01.org/0day-ci/archive/20230203/202302030706.gBkl14ay-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/2dfe054992e73c8da87d242a35a30d969d87b1a0
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Frieder-Schrempf/dt-bindings-rtc-Move-RV3028-to-separate-binding-file/20230201-224450
        git checkout 2dfe054992e73c8da87d242a35a30d969d87b1a0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from <command-line>:
>> ./usr/include/linux/rtc.h:15:10: fatal error: dt-bindings/rtc/rtc.h: No such file or directory
      15 | #include <dt-bindings/rtc/rtc.h>
         |          ^~~~~~~~~~~~~~~~~~~~~~~
   compilation terminated.
diff mbox series

Patch

diff --git a/include/dt-bindings/rtc/rtc.h b/include/dt-bindings/rtc/rtc.h
new file mode 100644
index 000000000000..b0cc06d368c0
--- /dev/null
+++ b/include/dt-bindings/rtc/rtc.h
@@ -0,0 +1,11 @@ 
+/* SPDX-License-Identifier: GPL-2.0 OR MIT */
+
+#ifndef _DT_BINDINGS_RTC_H
+#define _DT_BINDINGS_RTC_H
+
+#define RTC_BSM_DISABLED	0
+#define RTC_BSM_DIRECT		1
+#define RTC_BSM_LEVEL		2
+#define RTC_BSM_STANDBY		3
+
+#endif /* _DT_BINDINGS_RTC_H */
diff --git a/include/uapi/linux/rtc.h b/include/uapi/linux/rtc.h
index 97aca4503a6a..9e78c17b5733 100644
--- a/include/uapi/linux/rtc.h
+++ b/include/uapi/linux/rtc.h
@@ -12,6 +12,7 @@ 
 #ifndef _UAPI_LINUX_RTC_H_
 #define _UAPI_LINUX_RTC_H_
 
+#include <dt-bindings/rtc/rtc.h>
 #include <linux/const.h>
 #include <linux/ioctl.h>
 #include <linux/types.h>
@@ -141,11 +142,6 @@  struct rtc_param {
 #define RTC_PARAM_CORRECTION		1
 #define RTC_PARAM_BACKUP_SWITCH_MODE	2
 
-#define RTC_BSM_DISABLED	0
-#define RTC_BSM_DIRECT		1
-#define RTC_BSM_LEVEL		2
-#define RTC_BSM_STANDBY		3
-
 #define RTC_MAX_FREQ	8192