| Message ID | 20230906093210.339585-9-den@openvz.org |
|---|---|
| State | New |
| Headers | show |
| Series | qemu-nbd: Restore "qemu-nbd -v --fork" output | expand |
On Wed, Sep 06, 2023 at 11:32:10AM +0200, Denis V. Lunev wrote: > Just a formatting, no functional changes. > > Signed-off-by: Denis V. Lunev <den@openvz.org> > CC: Eric Blake <eblake@redhat.com> > CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> > --- > Do not really sure that this patch is mandatory, just stabs my eye. Feel free > to drop if this is too useless. > > qemu-nbd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/qemu-nbd.c b/qemu-nbd.c > index b9c74ce77c..8eb1d1f40b 100644 > --- a/qemu-nbd.c > +++ b/qemu-nbd.c > @@ -581,7 +581,8 @@ int main(int argc, char **argv) > pthread_t client_thread; > const char *fmt = NULL; > Error *local_err = NULL; > - BlockdevDetectZeroesOptions detect_zeroes = BLOCKDEV_DETECT_ZEROES_OPTIONS_OFF; > + BlockdevDetectZeroesOptions detect_zeroes = > + BLOCKDEV_DETECT_ZEROES_OPTIONS_OFF; check-patch allows code up to 90 columngs although it does advise staying under 80. You fixed the long line by keeping the wrapped portion right-flushed to 80 columns; I think more typical tree-wide is to just indent by four spaces (at least, that's what emacs suggests I do). But me changing what you wrote would a complete rewrite, so I'm reluctant to include it in my upcoming pull request, although I'm not ruling out a later cleanup (perhaps if it touches more than one stylistic thing at once). I'm queuing 1-7 through my NBD tree, and running another round of iotests before sending the pull request this week.
diff --git a/qemu-nbd.c b/qemu-nbd.c index b9c74ce77c..8eb1d1f40b 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -581,7 +581,8 @@ int main(int argc, char **argv) pthread_t client_thread; const char *fmt = NULL; Error *local_err = NULL; - BlockdevDetectZeroesOptions detect_zeroes = BLOCKDEV_DETECT_ZEROES_OPTIONS_OFF; + BlockdevDetectZeroesOptions detect_zeroes = + BLOCKDEV_DETECT_ZEROES_OPTIONS_OFF; QDict *options = NULL; const char *export_name = NULL; /* defaults to "" later for server mode */ const char *export_description = NULL;
Just a formatting, no functional changes. Signed-off-by: Denis V. Lunev <den@openvz.org> CC: Eric Blake <eblake@redhat.com> CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> --- Do not really sure that this patch is mandatory, just stabs my eye. Feel free to drop if this is too useless. qemu-nbd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)