| Message ID | 20230906093210.339585-2-den@openvz.org |
|---|---|
| State | New |
| Headers | show |
| Series | qemu-nbd: Restore "qemu-nbd -v --fork" output | expand |
On Wed, Sep 06, 2023 at 11:32:03AM +0200, Denis V. Lunev wrote: > This error is happened when we are not able to close the pipe to the s/is happened when/happens if/ > parent (to trace errors in the child process) and assign stderr to > /dev/null as required by the daemonizing convention. > > Signed-off-by: Denis V. Lunev <den@openvz.org> > Suggested-by: Eric Blake <eblake@redhat.com> > CC: Eric Blake <eblake@redhat.com> > CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> > --- > qemu-nbd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qemu-nbd.c b/qemu-nbd.c > index aaccaa3318..4575e4291e 100644 > --- a/qemu-nbd.c > +++ b/qemu-nbd.c > @@ -324,7 +324,7 @@ static void *nbd_client_thread(void *arg) > } else { > /* Close stderr so that the qemu-nbd process exits. */ > if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) { > - error_report("Could not set stderr to /dev/null: %s", > + error_report("Could not release pipe to parent: %s", > strerror(errno)); > exit(EXIT_FAILURE); > } > @@ -1181,7 +1181,7 @@ int main(int argc, char **argv) > > if (fork_process) { > if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) { > - error_report("Could not set stderr to /dev/null: %s", > + error_report("Could not release pipe to parent: %s", > strerror(errno)); > exit(EXIT_FAILURE); > } > -- > 2.34.1 > Reviewed-by: Eric Blake <eblake@redhat.com>
diff --git a/qemu-nbd.c b/qemu-nbd.c index aaccaa3318..4575e4291e 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -324,7 +324,7 @@ static void *nbd_client_thread(void *arg) } else { /* Close stderr so that the qemu-nbd process exits. */ if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) { - error_report("Could not set stderr to /dev/null: %s", + error_report("Could not release pipe to parent: %s", strerror(errno)); exit(EXIT_FAILURE); } @@ -1181,7 +1181,7 @@ int main(int argc, char **argv) if (fork_process) { if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) { - error_report("Could not set stderr to /dev/null: %s", + error_report("Could not release pipe to parent: %s", strerror(errno)); exit(EXIT_FAILURE); }
This error is happened when we are not able to close the pipe to the parent (to trace errors in the child process) and assign stderr to /dev/null as required by the daemonizing convention. Signed-off-by: Denis V. Lunev <den@openvz.org> Suggested-by: Eric Blake <eblake@redhat.com> CC: Eric Blake <eblake@redhat.com> CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> --- qemu-nbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)