| Message ID | 20230906093210.339585-8-den@openvz.org |
|---|---|
| State | New |
| Headers | show |
| Series | qemu-nbd: Restore "qemu-nbd -v --fork" output | expand |
On Wed, Sep 06, 2023 at 11:32:09AM +0200, Denis V. Lunev wrote: > Signed-off-by: Denis V. Lunev <den@openvz.org> > CC: Eric Blake <eblake@redhat.com> > CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> > --- > docs/tools/qemu-nbd.rst | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/docs/tools/qemu-nbd.rst b/docs/tools/qemu-nbd.rst > index faf6349ea5..5c48ee7345 100644 > --- a/docs/tools/qemu-nbd.rst > +++ b/docs/tools/qemu-nbd.rst > @@ -197,7 +197,9 @@ driver options if :option:`--image-opts` is specified. > > .. option:: -v, --verbose > > - Display extra debugging information. > + Display extra debugging information. This option also keeps opened original > + *STDERR* stream if ``qemu-nbd`` process is daemonized due to other options > + like :option:`--fork` or :option:`-c`. As a native speaker, I find the following a bit easier to parse: This option also keeps the original *STDERR* stream open if ... I can make that touchup as part of queuing the series. Reviewed-by: Eric Blake <eblake@redhat.com>
On 9/8/23 00:01, Eric Blake wrote: > On Wed, Sep 06, 2023 at 11:32:09AM +0200, Denis V. Lunev wrote: >> Signed-off-by: Denis V. Lunev <den@openvz.org> >> CC: Eric Blake <eblake@redhat.com> >> CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> >> --- >> docs/tools/qemu-nbd.rst | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/docs/tools/qemu-nbd.rst b/docs/tools/qemu-nbd.rst >> index faf6349ea5..5c48ee7345 100644 >> --- a/docs/tools/qemu-nbd.rst >> +++ b/docs/tools/qemu-nbd.rst >> @@ -197,7 +197,9 @@ driver options if :option:`--image-opts` is specified. >> >> .. option:: -v, --verbose >> >> - Display extra debugging information. >> + Display extra debugging information. This option also keeps opened original >> + *STDERR* stream if ``qemu-nbd`` process is daemonized due to other options >> + like :option:`--fork` or :option:`-c`. > As a native speaker, I find the following a bit easier to parse: > > This option also keeps the original *STDERR* stream open if ... > > I can make that touchup as part of queuing the series. > > Reviewed-by: Eric Blake <eblake@redhat.com> > That would be great, thanks!
diff --git a/docs/tools/qemu-nbd.rst b/docs/tools/qemu-nbd.rst index faf6349ea5..5c48ee7345 100644 --- a/docs/tools/qemu-nbd.rst +++ b/docs/tools/qemu-nbd.rst @@ -197,7 +197,9 @@ driver options if :option:`--image-opts` is specified. .. option:: -v, --verbose - Display extra debugging information. + Display extra debugging information. This option also keeps opened original + *STDERR* stream if ``qemu-nbd`` process is daemonized due to other options + like :option:`--fork` or :option:`-c`. .. option:: -h, --help
Signed-off-by: Denis V. Lunev <den@openvz.org> CC: Eric Blake <eblake@redhat.com> CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> --- docs/tools/qemu-nbd.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)