diff mbox series

[30/30] meson: always log qemu-iotests verbosely

Message ID 20221209112409.184703-31-pbonzini@redhat.com
State New
Headers show
Series Meson changes for QEMU 8.0 | expand

Commit Message

Paolo Bonzini Dec. 9, 2022, 11:24 a.m. UTC
---
 tests/qemu-iotests/meson.build | 1 +
 1 file changed, 1 insertion(+)

Comments

Marc-André Lureau Dec. 12, 2022, 2:02 p.m. UTC | #1
Hi

On Fri, Dec 9, 2022 at 3:29 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>

Sounds fine, but I like silence too. Could you give a bit of motivation details?
thanks!

> ---
>  tests/qemu-iotests/meson.build | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
> index 583468c5b9b3..3d8637c8f2b6 100644
> --- a/tests/qemu-iotests/meson.build
> +++ b/tests/qemu-iotests/meson.build
> @@ -43,5 +43,6 @@ foreach format, speed: qemu_iotests_formats
>         protocol: 'tap',
>         suite: suites,
>         timeout: 0,
> +       verbose: true,
>         is_parallel: false)
>  endforeach
> --
> 2.38.1
>
>
Paolo Bonzini Dec. 12, 2022, 4:48 p.m. UTC | #2
On 12/12/22 15:02, Marc-André Lureau wrote:
> Sounds fine, but I like silence too. Could you give a bit of motivation details?
> thanks!

One qemu-iotests TAP testcase is comparable to a test() invocation 
elsewhere (in terms of both runtime and kind of test).  This makes it 
useful to see the last logged test.

Paolo
Peter Maydell Dec. 12, 2022, 4:55 p.m. UTC | #3
On Fri, 9 Dec 2022 at 11:44, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> ---
>  tests/qemu-iotests/meson.build | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
> index 583468c5b9b3..3d8637c8f2b6 100644
> --- a/tests/qemu-iotests/meson.build
> +++ b/tests/qemu-iotests/meson.build
> @@ -43,5 +43,6 @@ foreach format, speed: qemu_iotests_formats
>         protocol: 'tap',
>         suite: suites,
>         timeout: 0,
> +       verbose: true,
>         is_parallel: false)
>  endforeach

How much does this increase the size of a build-and-test logfile by?
I know the gitlab CI has a size limit on that these days, so if this
noticeably increases the total log size we might want to check how
close we are to the limit...

thanks
-- PMM
Paolo Bonzini Dec. 12, 2022, 9:36 p.m. UTC | #4
On 12/12/22 17:55, Peter Maydell wrote:
> On Fri, 9 Dec 2022 at 11:44, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> ---
>>   tests/qemu-iotests/meson.build | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
>> index 583468c5b9b3..3d8637c8f2b6 100644
>> --- a/tests/qemu-iotests/meson.build
>> +++ b/tests/qemu-iotests/meson.build
>> @@ -43,5 +43,6 @@ foreach format, speed: qemu_iotests_formats
>>          protocol: 'tap',
>>          suite: suites,
>>          timeout: 0,
>> +       verbose: true,
>>          is_parallel: false)
>>   endforeach
> 
> How much does this increase the size of a build-and-test logfile by?
> I know the gitlab CI has a size limit on that these days, so if this
> noticeably increases the total log size we might want to check how
> close we are to the limit...

~300 lines, so probably around 20-30 kilobytes.

Paolo
diff mbox series

Patch

diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
index 583468c5b9b3..3d8637c8f2b6 100644
--- a/tests/qemu-iotests/meson.build
+++ b/tests/qemu-iotests/meson.build
@@ -43,5 +43,6 @@  foreach format, speed: qemu_iotests_formats
        protocol: 'tap',
        suite: suites,
        timeout: 0,
+       verbose: true,
        is_parallel: false)
 endforeach