| Message ID | 20221209112409.184703-15-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Meson changes for QEMU 8.0 | expand |
On 9/12/22 12:23, Paolo Bonzini wrote: > Some warnings are hardcoded in QEMU_CFLAGS and not tested. There is > no particular reason to single out these five, as many more -W flags are > present on all the supported compilers. For homogeneity when moving > the detection to meson, make them use the same warn_flags infrastructure. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > configure | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Fri, Dec 09, 2022 at 12:23:53PM +0100, Paolo Bonzini wrote: > Some warnings are hardcoded in QEMU_CFLAGS and not tested. There is > no particular reason to single out these five, as many more -W flags are > present on all the supported compilers. For homogeneity when moving > the detection to meson, make them use the same warn_flags infrastructure. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > configure | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel
diff --git a/configure b/configure index 113db838a16f..9c5393a25de7 100755 --- a/configure +++ b/configure @@ -378,8 +378,6 @@ sdl2_config="${SDL2_CONFIG-${cross_prefix}sdl2-config}" # 2s-complement style results. (Both clang and gcc agree that it # provides these semantics.) QEMU_CFLAGS="-fno-strict-aliasing -fno-common -fwrapv" -QEMU_CFLAGS="-Wundef -Wwrite-strings -Wmissing-prototypes $QEMU_CFLAGS" -QEMU_CFLAGS="-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS" QEMU_CFLAGS="-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE $QEMU_CFLAGS" QEMU_LDFLAGS= @@ -1161,6 +1159,11 @@ fi # just silently disable some features, so it's too error prone. warn_flags= +add_to warn_flags -Wundef +add_to warn_flags -Wwrite-strings +add_to warn_flags -Wmissing-prototypes +add_to warn_flags -Wstrict-prototypes +add_to warn_flags -Wredundant-decls add_to warn_flags -Wold-style-declaration add_to warn_flags -Wold-style-definition add_to warn_flags -Wtype-limits
Some warnings are hardcoded in QEMU_CFLAGS and not tested. There is no particular reason to single out these five, as many more -W flags are present on all the supported compilers. For homogeneity when moving the detection to meson, make them use the same warn_flags infrastructure. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- configure | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)