mbox series

[QEMU,v3,0/4] Introduce Xilinx Versal CANFD

Message ID 20221207021322.16165-1-vikram.garhwal@amd.com
Headers show
Series Introduce Xilinx Versal CANFD | expand

Message

Vikram Garhwal Dec. 7, 2022, 2:13 a.m. UTC 
Hi,
This patch implements CANFD controller for xlnx-versal-virt machine. There are
two controllers CANFD0@0xFF06_0000 and CANFD1@0xFF07_0000 are connected to the
machine.

Also, added basic qtests for data exchange between both the controllers in
various supported configs.

Changelog:
v2->v3:
    Corrected reg2frame().
    Added assert to prevent out of bound cases.
    Replace tx_id link list with GSList and removed sorting function.
    Replaced PTIMER_POLICY_LEGACY with proper timer policies.
    Corrected minor code format issues.

v1->v2
    Update xlnx-versal-virt.rst with CANFD examples and add this in 03/05 patch.
    Addressed comments for patch 02/05 and 03/05.
    Add reviewed-by tags for patch 01/05, 04/05 and 05/05.
    Change commit message for patch 02/05.
    Add SPDX license for Qtest.

Regards,
Vikram

Vikram Garhwal (4):
  MAINTAINERS: Include canfd tests under Xilinx CAN
  hw/net/can: Introduce Xilinx Versal CANFD controller
  xlnx-versal: Connect Xilinx VERSAL CANFD controllers
  tests/qtest: Introduce tests for Xilinx VERSAL CANFD controller

 MAINTAINERS                          |    2 +-
 docs/system/arm/xlnx-versal-virt.rst |   31 +
 hw/arm/xlnx-versal-virt.c            |   48 +
 hw/arm/xlnx-versal.c                 |   37 +
 hw/net/can/meson.build               |    1 +
 hw/net/can/trace-events              |    7 +
 hw/net/can/xlnx-versal-canfd.c       | 2121 ++++++++++++++++++++++++++
 include/hw/arm/xlnx-versal.h         |   12 +
 include/hw/net/xlnx-versal-canfd.h   |   90 ++
 tests/qtest/meson.build              |    1 +
 tests/qtest/xlnx-canfd-test.c        |  422 +++++
 11 files changed, 2771 insertions(+), 1 deletion(-)
 create mode 100644 hw/net/can/xlnx-versal-canfd.c
 create mode 100644 include/hw/net/xlnx-versal-canfd.h
 create mode 100644 tests/qtest/xlnx-canfd-test.c

Comments

Peter Maydell Dec. 19, 2022, 3:29 p.m. UTC | #1 
On Wed, 7 Dec 2022 at 02:13, Vikram Garhwal <vikram.garhwal@amd.com> wrote:
>
> Hi,
> This patch implements CANFD controller for xlnx-versal-virt machine. There are
> two controllers CANFD0@0xFF06_0000 and CANFD1@0xFF07_0000 are connected to the
> machine.
>
> Also, added basic qtests for data exchange between both the controllers in
> various supported configs.
>
> Changelog:
> v2->v3:
>     Corrected reg2frame().
>     Added assert to prevent out of bound cases.
>     Replace tx_id link list with GSList and removed sorting function.
>     Replaced PTIMER_POLICY_LEGACY with proper timer policies.
>     Corrected minor code format issues.
>
> v1->v2
>     Update xlnx-versal-virt.rst with CANFD examples and add this in 03/05 patch.
>     Addressed comments for patch 02/05 and 03/05.
>     Add reviewed-by tags for patch 01/05, 04/05 and 05/05.
>     Change commit message for patch 02/05.
>     Add SPDX license for Qtest.
>
> Regards,
> Vikram
>
> Vikram Garhwal (4):
>   MAINTAINERS: Include canfd tests under Xilinx CAN
>   hw/net/can: Introduce Xilinx Versal CANFD controller
>   xlnx-versal: Connect Xilinx VERSAL CANFD controllers
>   tests/qtest: Introduce tests for Xilinx VERSAL CANFD controller

Hi -- this patch cover letter lists 4 patches, but the thread
has 5 patches, as you can see in the archive:
 https://lore.kernel.org/qemu-devel/20221207021322.16165-1-vikram.garhwal@amd.com/
Is the extra patch 3 intended ?

thanks
-- PMM