Message ID | 20200728195935.155604-12-saeedm@mellanox.com |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.a=rsa-sha256 header.s=selector1 header.b=ho2OAxt8; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BGSGd5qL4z9s1x for <patchwork-incoming-netdev@ozlabs.org>; Wed, 29 Jul 2020 06:00:57 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729352AbgG1UA5 (ORCPT <rfc822;patchwork-incoming-netdev@ozlabs.org>); Tue, 28 Jul 2020 16:00:57 -0400 Received: from mail-eopbgr00066.outbound.protection.outlook.com ([40.107.0.66]:1413 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729300AbgG1UA4 (ORCPT <rfc822;netdev@vger.kernel.org>); Tue, 28 Jul 2020 16:00:56 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hAhKcylsJCsfHdfDF49bPCNliInZsOgGme+MLIgn64jclxfICb/GcUbVDDLOm+SQ+62/ZPpUrnL/EZTqBV3o62IA9+9Lls7uGFHRjqv0qcDDCBXpj7E/lWjCQxvQU1P/n2JtIj0KVsxRmkSYe5AAa6np/VgRsNJblq8DecB/LDx0di3yYkK257Ql4FG2LXpI/wNjwFL/vPWSh8KKH+Y8pvFQl53bvODWi/XKEiGHIJdPCgnNSDJahXGWCqA3gG8x6eSAmrANu1JCaeXQA5OcbveSuAd/BnHYi3TNrYUVsLI5DQViAAq3LhinNLRxRlWepkqnkE0LnR9kQnlhJqgTdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PB6A7BOwlbghfua3HcZpWWj9Vo6t8AgAXCfLrMfdU6M=; b=byKSsi9SWf7X0DAeDaSk1VrUMSQlsPzhrVvz4ceHKbXBskB4bC4O1JomNAIXbUuaeB66MAwk3waNB1mMtGtEVBqw754SRrRZQlM4s4v4NN+iYN5wtK7ds4oeFIVDqym2MR0eHjLrZ3bjED/cUQFPzkrLbnH3Ma/Yv5DvNUioYJJLp4YPU3NrhoR9SdH7KAv/bMHMzNq6C8swRAvAGvopQ4huquGFvGCloUIwrMb5EXZVAqissTA8cGHCQCPEAQQLRi13CIdjMQb7DW9DDlrxlZd98LJXh8kR+I1Qk9+VXQ7RPniw9N8PtTandvxb9TC2kJecwPPek/6fE5OhFq8r/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PB6A7BOwlbghfua3HcZpWWj9Vo6t8AgAXCfLrMfdU6M=; b=ho2OAxt8XvWk2Oh9XT9gbVZeSwVBFPScUIprl8HdCjrasl+eNWkv9XXdZWmN7lRO1q5gD5nVlXEzxJBCyOyd7CFxYNwMKBqXlavQMbwT7c1KByth51I6SbJ4K15qaMgwZCCx/xylc9PGV/ukymW3jn+veBfq46KFr5hrPfncLbw= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=mellanox.com; Received: from VI1PR05MB5102.eurprd05.prod.outlook.com (2603:10a6:803:5e::23) by VI1PR0501MB2592.eurprd05.prod.outlook.com (2603:10a6:800:6f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Tue, 28 Jul 2020 20:00:52 +0000 Received: from VI1PR05MB5102.eurprd05.prod.outlook.com ([fe80::508a:d074:ad3a:3529]) by VI1PR05MB5102.eurprd05.prod.outlook.com ([fe80::508a:d074:ad3a:3529%5]) with mapi id 15.20.3216.034; Tue, 28 Jul 2020 20:00:51 +0000 From: Saeed Mahameed <saeedm@mellanox.com> To: "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org> Cc: netdev@vger.kernel.org, Alaa Hleihel <alaa@mellanox.com>, Roi Dayan <roid@mellanox.com>, Vlad Buslov <vladbu@mellanox.com>, Saeed Mahameed <saeedm@mellanox.com> Subject: [net V2 11/11] net/mlx5e: Fix kernel crash when setting vf VLANID on a VF dev Date: Tue, 28 Jul 2020 12:59:35 -0700 Message-Id: <20200728195935.155604-12-saeedm@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200728195935.155604-1-saeedm@mellanox.com> References: <20200728195935.155604-1-saeedm@mellanox.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: BYAPR07CA0058.namprd07.prod.outlook.com (2603:10b6:a03:60::35) To VI1PR05MB5102.eurprd05.prod.outlook.com (2603:10a6:803:5e::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from smtp.office365.com (73.15.39.150) by BYAPR07CA0058.namprd07.prod.outlook.com (2603:10b6:a03:60::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23 via Frontend Transport; Tue, 28 Jul 2020 20:00:48 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [73.15.39.150] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 84305557-ad00-42d7-76f0-08d83330ed38 X-MS-TrafficTypeDiagnostic: VI1PR0501MB2592: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: <VI1PR0501MB259221BD539CB33B3459D574BE730@VI1PR0501MB2592.eurprd05.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:475; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OzDZPycnfHxeJB33Vvrb8buRuxLuQMU3fyBBfTUIgcCjmi1aVD5xHggaa3wOK/nvXTFyRPiELYpu7Nc6LHcRnnycVODSaZF87pEtkum4ZqWFAOc18gOvotAnctzcGZauBCVPMMJfRMQNYXBmKtk6M8wcte6mCjZack61MPxutRk/gGWg4XlNJs5Hd4E+IwAWHPdSIyxT5rSi8KoSh8PydXu+8ScSByJbQ/9sV6ShFDFpNK2Ov+BD4Q3b/f/ley5/ICu2BJv3iAA0Ey0SopNWm9NZAkMpIB3r0IybiOMBljfj8zPwWFP6J1MA+Y9Hwk82salPJibgR77nFtOM/S3zA4gwZo8FLIx0HvBKNSYeraprTjOttmC/6xv5kUYqKWT9 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR05MB5102.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(186003)(6486002)(8676002)(83380400001)(498600001)(6506007)(54906003)(110136005)(107886003)(86362001)(36756003)(16526019)(26005)(1076003)(66556008)(52116002)(6666004)(66476007)(4326008)(66946007)(956004)(8936002)(2616005)(5660300002)(2906002)(6512007)(54420400002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: TMz2UrfqWnmkYimyx9bhyLwFcoOtHcmcBXwEdzHvQ0Lb0F81AHzGUznGsOeZcSgrF4GwCLwWCCpEnAHVapmfeyzjtuhyBpdIPQljzABO1Qn1jOkPBALc+iqSdjFFwEEVRdhybefgLr6PvzlomorVFhZN04TruY2uQRiLYaNrKGqUd2uCzCrx7Hu7/b5LGbH4WT6EmXum/KFVq6op1AN8KbdzfH+r7wXuxTP29qqtzYU/bOkRx8sCGmxOl3hHk6t1qSm1P+IUyrMitqc2YXYInBQq6D54x4N3Bxw0WXOHt8c63RbO2SlJ1O8JGwcsNiTBSOn4tI5Vfdvky4v0c1RaeCiZCljfoasgRBUpAU0ewn6fvTAWxYEoVKtBsaApZH5+P/HELXaLo1wHxhv1XfQ15UKSzF+k/y5xSTea4wBZi3XdVV9wXuYkjwXVhs02WFNUARIUR6RZoOt4OdMW1SGxa8TicRGnQG56idg7CevoK28= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84305557-ad00-42d7-76f0-08d83330ed38 X-MS-Exchange-CrossTenant-AuthSource: VI1PR05MB5102.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2020 20:00:51.6170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6X6FSwyWObGKxvjtuyGk/bl7BlVGuxpYQS+ey+w2iZo8E/RAQJE/wmZKCUgi+ojGiGCK0y7IUbxacrpDzjh+5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2592 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
Series |
[net,V2,01/11] net/mlx5: E-switch, Destroy TSAR when fail to enable the mode
|
expand
|
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c index 71d01143c4556..43005caff09e1 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c @@ -1887,8 +1887,6 @@ int __mlx5_eswitch_set_vport_vlan(struct mlx5_eswitch *esw, struct mlx5_vport *evport = mlx5_eswitch_get_vport(esw, vport); int err = 0; - if (!ESW_ALLOWED(esw)) - return -EPERM; if (IS_ERR(evport)) return PTR_ERR(evport); if (vlan > 4095 || qos > 7) @@ -1916,6 +1914,9 @@ int mlx5_eswitch_set_vport_vlan(struct mlx5_eswitch *esw, u8 set_flags = 0; int err; + if (!ESW_ALLOWED(esw)) + return -EPERM; + if (vlan || qos) set_flags = SET_VLAN_STRIP | SET_VLAN_INSERT;