| Message ID | 1548172784-27414-3-git-send-email-linuxram@us.ibm.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | KVM: PPC: Paravirtualize KVM to support Ultravisor | expand |
On Tue, Jan 22, 2019 at 07:59:33AM -0800, Ram Pai wrote: > This file contains the definitions of all ultracalls. "will contain", perhaps? > Signed-off-by: Ram Pai <linuxram@us.ibm.com> > --- > arch/powerpc/include/asm/ucall-api.h | 5 +++++ > arch/powerpc/include/uapi/asm/uapi_uvcall.h | 10 ++++++++++ This is the wrong place for these definitions. The "u" in uapi stands for "user", and this directory is for the definition of the API that the kernel provides to userspace. This file should just go in the normal arch/powerpc/include/asm directory, and it shouldn't have "uapi" in its name. Paul.
diff --git a/arch/powerpc/include/asm/ucall-api.h b/arch/powerpc/include/asm/ucall-api.h new file mode 100644 index 0000000..3833b55 --- /dev/null +++ b/arch/powerpc/include/asm/ucall-api.h @@ -0,0 +1,5 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_POWERPC_UCALL_API_H +#define _ASM_POWERPC_UCALL_API_H +#include <uapi/asm/uapi_uvcall.h> +#endif /* _ASM_POWERPC_UCALL_API_H */ diff --git a/arch/powerpc/include/uapi/asm/uapi_uvcall.h b/arch/powerpc/include/uapi/asm/uapi_uvcall.h new file mode 100644 index 0000000..7e213a1 --- /dev/null +++ b/arch/powerpc/include/uapi/asm/uapi_uvcall.h @@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Ultravisor calls. + * + * Copyright 2018, IBM Corporation. + * + */ +#ifndef UAPI_UC_H +#define UAPI_UC_H +#endif /* #ifndef UAPI_UC_H */
This file contains the definitions of all ultracalls. Signed-off-by: Ram Pai <linuxram@us.ibm.com> --- arch/powerpc/include/asm/ucall-api.h | 5 +++++ arch/powerpc/include/uapi/asm/uapi_uvcall.h | 10 ++++++++++ 2 files changed, 15 insertions(+) create mode 100644 arch/powerpc/include/asm/ucall-api.h create mode 100644 arch/powerpc/include/uapi/asm/uapi_uvcall.h