[7/12] fix diagnostic quoting/spelling in libgcc

Message ID	a3045a65-8f6a-970b-1de1-c140fd670bfc@gmail.com
State	New
Headers	show Return-Path: <gcc-patches-return-500692-incoming=patchwork.ozlabs.org@gcc.gnu.org> DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=KiMo8++YuDIBMr1a/lcu/62lNCzf0K3KGUINnMkX6GicYL+fnM le+wbi7BXUeZOkSofDUftmDbno7zKe1vFdNeylx3/nV0HrobcgbYqlz9d7qtQ4vR AqkiedlxRcEq+sFVPRJK40HpCupE5IYdwBK+yPOObwsRyhxaUfiXfFUzA= Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk Sender: gcc-patches-owner@gcc.gnu.org To: gcc-patches <gcc-patches@gcc.gnu.org> From: Martin Sebor <msebor@gmail.com> Subject: [PATCH 7/12] fix diagnostic quoting/spelling in libgcc Message-ID: <a3045a65-8f6a-970b-1de1-c140fd670bfc@gmail.com> Date: Tue, 14 May 2019 15:32:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------4F17871A2F9B54192945F8EE"
Series	detect quoting and punctuation problems in diagnostics \| expand [0/12] detect quoting and punctuation problems in diagnostics [1/12] implement -Wformat-diag to detect quoting and spelling issues in GCC diagnostics [2/12] fix diagnostic quoting/spelling in ada [3/12] fix diagnostic quoting/spelling in Brig [4/12] fix diagnostic quoting/spelling in the C front-end [5/12] fix diagnostic quoting/spelling in c-family [6/12] fix diagnostic quoting/spelling in C++ [7/12] fix diagnostic quoting/spelling in libgcc [8/12] fix diagnostic quoting/spelling in the middle-end [9/12] adjust tests to quoting/spelling diagnostics fixes [10/12] fix diagnostic quoting/spelling in D [11/12] fix diagnostic quoting/spelling issues in i386 back-end [12/12] fix diagnostic quoting/spelling issues in ObjC

Message ID

a3045a65-8f6a-970b-1de1-c140fd670bfc@gmail.com

State

New

Headers

DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id
	:list-unsubscribe:list-archive:list-post:list-help:sender:to
	:from:subject:message-id:date:mime-version:content-type; q=dns;
	s=default; b=KiMo8++YuDIBMr1a/lcu/62lNCzf0K3KGUINnMkX6GicYL+fnM
	le+wbi7BXUeZOkSofDUftmDbno7zKe1vFdNeylx3/nV0HrobcgbYqlz9d7qtQ4vR
	AqkiedlxRcEq+sFVPRJK40HpCupE5IYdwBK+yPOObwsRyhxaUfiXfFUzA=
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
Sender: gcc-patches-owner@gcc.gnu.org
To: gcc-patches <gcc-patches@gcc.gnu.org>
From: Martin Sebor <msebor@gmail.com>
Subject: [PATCH 7/12] fix diagnostic quoting/spelling in libgcc
Message-ID: <a3045a65-8f6a-970b-1de1-c140fd670bfc@gmail.com>
Date: Tue, 14 May 2019 15:32:34 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:60.0) Gecko/20100101 Thunderbird/60.3.1
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="------------4F17871A2F9B54192945F8EE"

Series

detect quoting and punctuation problems in diagnostics | expand

Comments

Jeff Law May 16, 2019, 7:17 p.m. UTC | #1

On 5/14/19 3:32 PM, Martin Sebor wrote:
> The attached patch fixes quoting, spelling, and other formatting
> issues in diagnostics issued from files in the libgcc directory
> and pointed out by the -Wformat-diag warning.
> 
> Martin
> 
> gcc-wformat-diag-libgcc.diff
> 
> libgcc/ChangeLog:
> 
> 	* libgcov-util.c (read_gcda_file): Remove trailing newline.
OK
jeff

libgcc/ChangeLog:

	* libgcov-util.c (read_gcda_file): Remove trailing newline.

diff --git a/libgcc/libgcov-util.c b/libgcc/libgcov-util.c
index ae0dd017204..62f4fe38233 100644
--- a/libgcc/libgcov-util.c
+++ b/libgcc/libgcov-util.c
@@ -332,7 +332,7 @@  read_gcda_file (const char *filename)
         {
           if (((mask & 0xff) != 0xff))
             {
-              warning (0, "%s:tag `%x' is invalid\n", filename, tag);
+              warning (0, "%s:tag %qx is invalid", filename, tag);
               break;
             }
           tag_depth--;
@@ -347,7 +347,7 @@  read_gcda_file (const char *filename)
           if (depth && depth < tag_depth)
             {
               if (!GCOV_TAG_IS_SUBTAG (tags[depth - 1], tag))
-                warning (0, "%s:tag `%x' is incorrectly nested\n",
+                warning (0, "%s:tag %qx is incorrectly nested",
                          filename, tag);
             }
           depth = tag_depth;
@@ -362,18 +362,18 @@  read_gcda_file (const char *filename)
 
           actual_length = gcov_position () - base;
           if (actual_length > length)
-            warning (0, "%s:record size mismatch %lu bytes overread\n",
+            warning (0, "%s:record size mismatch %lu bytes overread",
                      filename, actual_length - length);
           else if (length > actual_length)
-            warning (0, "%s:record size mismatch %lu bytes unread\n",
+            warning (0, "%s:record size mismatch %lu bytes unread",
                      filename, length - actual_length);
        }
 
       gcov_sync (base, length);
       if ((error = gcov_is_error ()))
         {
-          warning (0, error < 0 ? "%s:counter overflow at %lu\n" :
-                                  "%s:read error at %lu\n", filename,
+          warning (0, error < 0 ? "%s:counter overflow at %lu" :
+                                  "%s:read error at %lu", filename,
                    (long unsigned) gcov_position ());
           break;
         }

[7/12] fix diagnostic quoting/spelling in libgcc

Commit Message

Comments

Patch