[3/12] fix diagnostic quoting/spelling in Brig

Message ID	c4299dad-f27b-46e0-f3b9-3953fbe52efc@gmail.com
State	New
Headers	show Return-Path: <gcc-patches-return-500689-incoming=patchwork.ozlabs.org@gcc.gnu.org> DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=Lrz04mkpqD0Rjy/Q5swldJt2aP9KN+38lX1AXGzopbj7xx7A0t 84gfu03Gp+ZLvmS8DMUCLOf6oPRqxMVj8ts8Tl2IrwYmmwJohvy8osBCom848pDH ZyfPVabGK2XpTzZDKig/zxaU4lnO+J18HWhn9SpzFWTk3pKPrYIIgGmqg= Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk Sender: gcc-patches-owner@gcc.gnu.org To: gcc-patches <gcc-patches@gcc.gnu.org> From: Martin Sebor <msebor@gmail.com> Subject: [PATCH 3/12] fix diagnostic quoting/spelling in Brig Message-ID: <c4299dad-f27b-46e0-f3b9-3953fbe52efc@gmail.com> Date: Tue, 14 May 2019 15:32:04 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------404A063FF786E729F20C8D51"
Series	detect quoting and punctuation problems in diagnostics \| expand [0/12] detect quoting and punctuation problems in diagnostics [1/12] implement -Wformat-diag to detect quoting and spelling issues in GCC diagnostics [2/12] fix diagnostic quoting/spelling in ada [3/12] fix diagnostic quoting/spelling in Brig [4/12] fix diagnostic quoting/spelling in the C front-end [5/12] fix diagnostic quoting/spelling in c-family [6/12] fix diagnostic quoting/spelling in C++ [7/12] fix diagnostic quoting/spelling in libgcc [8/12] fix diagnostic quoting/spelling in the middle-end [9/12] adjust tests to quoting/spelling diagnostics fixes [10/12] fix diagnostic quoting/spelling in D [11/12] fix diagnostic quoting/spelling issues in i386 back-end [12/12] fix diagnostic quoting/spelling issues in ObjC

Message ID

c4299dad-f27b-46e0-f3b9-3953fbe52efc@gmail.com

State

New

Headers

DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id
	:list-unsubscribe:list-archive:list-post:list-help:sender:to
	:from:subject:message-id:date:mime-version:content-type; q=dns;
	s=default; b=Lrz04mkpqD0Rjy/Q5swldJt2aP9KN+38lX1AXGzopbj7xx7A0t
	84gfu03Gp+ZLvmS8DMUCLOf6oPRqxMVj8ts8Tl2IrwYmmwJohvy8osBCom848pDH
	ZyfPVabGK2XpTzZDKig/zxaU4lnO+J18HWhn9SpzFWTk3pKPrYIIgGmqg=
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
Sender: gcc-patches-owner@gcc.gnu.org
To: gcc-patches <gcc-patches@gcc.gnu.org>
From: Martin Sebor <msebor@gmail.com>
Subject: [PATCH 3/12] fix diagnostic quoting/spelling in Brig
Message-ID: <c4299dad-f27b-46e0-f3b9-3953fbe52efc@gmail.com>
Date: Tue, 14 May 2019 15:32:04 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:60.0) Gecko/20100101 Thunderbird/60.3.1
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="------------404A063FF786E729F20C8D51"

Series

detect quoting and punctuation problems in diagnostics | expand

Comments

Jeff Law May 16, 2019, 7:12 p.m. UTC | #1

On 5/14/19 3:32 PM, Martin Sebor wrote:
> The attached patch fixes quoting, spelling, and other formatting
> issues in diagnostics issued by the Brig front end and pointed
> out by the -Wformat-diag warning.
> 
> Martin
> 
> gcc-wformat-diag-brig.diff
> 
> gcc/brig/ChangeLog:
> 
> 	* brigfrontend/brig-control-handler.cc
> 	(brig_directive_control_handler::operator): Remove trailing newline
> 	from a diagnostic.
> 	* brigfrontend/brig-module-handler.cc
> 	(brig_directive_module_handler::operator): Remove a duplicated space
> 	from a diagnostic.
OK.
Jeff

gcc/brig/ChangeLog:

	* brigfrontend/brig-control-handler.cc
	(brig_directive_control_handler::operator): Remove trailing newline
	from a diagnostic.
	* brigfrontend/brig-module-handler.cc
	(brig_directive_module_handler::operator): Remove a duplicated space
	from a diagnostic.

diff --git a/gcc/brig/brigfrontend/brig-control-handler.cc b/gcc/brig/brigfrontend/brig-control-handler.cc
index 38039315c7c..4374c469a39 100644
--- a/gcc/brig/brigfrontend/brig-control-handler.cc
+++ b/gcc/brig/brigfrontend/brig-control-handler.cc
@@ -102,7 +102,7 @@  brig_directive_control_handler::operator () (const BrigBase *base)
       /* Unimplemented.  */
       break;
     default:
-      sorry ("Unsupported control directive %x.\n", inst->control);
+      sorry ("Unsupported control directive %x.", inst->control);
     }
   return base->byteCount;
 }
diff --git a/gcc/brig/brigfrontend/brig-module-handler.cc b/gcc/brig/brigfrontend/brig-module-handler.cc
index 58a65d65574..e1551b93812 100644
--- a/gcc/brig/brigfrontend/brig-module-handler.cc
+++ b/gcc/brig/brigfrontend/brig-module-handler.cc
@@ -28,10 +28,10 @@  brig_directive_module_handler::operator () (const BrigBase *base)
   const BrigDirectiveModule* mod = (const BrigDirectiveModule*)base;
   m_parent.m_module_name = m_parent.get_string (mod->name).substr (1);
   if (mod->hsailMajor != 1 || mod->hsailMinor != 0)
-    fatal_error (UNKNOWN_LOCATION, PHSA_ERROR_PREFIX_INCOMPATIBLE_MODULE " "
+    fatal_error (UNKNOWN_LOCATION, PHSA_ERROR_PREFIX_INCOMPATIBLE_MODULE
 		 "HSAIL version not supported. HSAIL 1.0 required.");
   if (mod->machineModel != BRIG_MACHINE_LARGE)
-    fatal_error (UNKNOWN_LOCATION, PHSA_ERROR_PREFIX_INCOMPATIBLE_MODULE " "
+    fatal_error (UNKNOWN_LOCATION, PHSA_ERROR_PREFIX_INCOMPATIBLE_MODULE
 		 "Only HSA 'large' machine model supported.");
   /* Do not check for the profile as the runtime conformance suite tests
      with 'full' profile BRIGs even though they don't use any full profile

[3/12] fix diagnostic quoting/spelling in Brig

Commit Message

Comments

Patch