From patchwork Tue May 14 21:32:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Sebor X-Patchwork-Id: 1099740 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-500692-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="CU3FZjLL"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="JIW1+v02"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 453WC23LdHz9sDn for ; Wed, 15 May 2019 07:33:34 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=KiMo8++YuDIBMr1a/lcu/62lNCzf0K3KGUINnMkX6GicYL+fnM le+wbi7BXUeZOkSofDUftmDbno7zKe1vFdNeylx3/nV0HrobcgbYqlz9d7qtQ4vR AqkiedlxRcEq+sFVPRJK40HpCupE5IYdwBK+yPOObwsRyhxaUfiXfFUzA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=uPKTjoz7wAAB1GKPPQk82QMru1Q=; b=CU3FZjLL+s8lwpB/CUqd uXj8iwdLIGRUW4Bv1pm4DoycTyuiScDKUuFxcAAbI5r37+d3xJAF/vgB82wG1ZNN R6HkJQ6MJGCBHNrBXtn8wHMFwpwHAS+857Jlhi7Aj/AiC3kbL5yCNOQy5OU4GBCm sY2LdJkqRWn32brh9+9KEqM= Received: (qmail 40363 invoked by alias); 14 May 2019 21:32:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 40277 invoked by uid 89); 14 May 2019 21:32:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.7 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=unread X-HELO: mail-qt1-f178.google.com Received: from mail-qt1-f178.google.com (HELO mail-qt1-f178.google.com) (209.85.160.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 May 2019 21:32:38 +0000 Received: by mail-qt1-f178.google.com with SMTP id a39so899947qtk.2 for ; Tue, 14 May 2019 14:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language; bh=KTYC74Uaj7kKe0827AjVsBRgS/D2pkZfwD40OnrFKtk=; b=JIW1+v02kg8y+oww125ZXdtS7Bbv9QJxIVS+ko3pxfJl2URyFNSfj/CGETsvETj4qO TUsOqKxaVupynAWHkHRftpj9I9UQo8ioLJzer/a6eyJ6UBWvq0jZjheAeuYCLFdGLUeI GCF0PisrZdIY8O23xm4Y4APEzEi5O7O/951lUneyhbgunuAqjj4FApTA2vianWn7GFn7 lGPrSStP0nj1FkTKDqtLRSTgNU4bw1ib30ccAPJ9AWcQ2M4c62kDEA+QuZ+WVC/mc+w5 eAy+QmyxgtMDL6dm5mliP+vO5FUFbdsA4oyezJsxPoygw7tFKgT7a2RLyXpKmVHhnF4O Mc5w== Received: from [192.168.0.41] (97-118-125-210.hlrn.qwest.net. [97.118.125.210]) by smtp.gmail.com with ESMTPSA id d16sm103137qtd.73.2019.05.14.14.32.35 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 14 May 2019 14:32:35 -0700 (PDT) To: gcc-patches From: Martin Sebor Subject: [PATCH 7/12] fix diagnostic quoting/spelling in libgcc Message-ID: Date: Tue, 14 May 2019 15:32:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 X-IsSubscribed: yes The attached patch fixes quoting, spelling, and other formatting issues in diagnostics issued from files in the libgcc directory and pointed out by the -Wformat-diag warning. Martin libgcc/ChangeLog: * libgcov-util.c (read_gcda_file): Remove trailing newline. diff --git a/libgcc/libgcov-util.c b/libgcc/libgcov-util.c index ae0dd017204..62f4fe38233 100644 --- a/libgcc/libgcov-util.c +++ b/libgcc/libgcov-util.c @@ -332,7 +332,7 @@ read_gcda_file (const char *filename) { if (((mask & 0xff) != 0xff)) { - warning (0, "%s:tag `%x' is invalid\n", filename, tag); + warning (0, "%s:tag %qx is invalid", filename, tag); break; } tag_depth--; @@ -347,7 +347,7 @@ read_gcda_file (const char *filename) if (depth && depth < tag_depth) { if (!GCOV_TAG_IS_SUBTAG (tags[depth - 1], tag)) - warning (0, "%s:tag `%x' is incorrectly nested\n", + warning (0, "%s:tag %qx is incorrectly nested", filename, tag); } depth = tag_depth; @@ -362,18 +362,18 @@ read_gcda_file (const char *filename) actual_length = gcov_position () - base; if (actual_length > length) - warning (0, "%s:record size mismatch %lu bytes overread\n", + warning (0, "%s:record size mismatch %lu bytes overread", filename, actual_length - length); else if (length > actual_length) - warning (0, "%s:record size mismatch %lu bytes unread\n", + warning (0, "%s:record size mismatch %lu bytes unread", filename, length - actual_length); } gcov_sync (base, length); if ((error = gcov_is_error ())) { - warning (0, error < 0 ? "%s:counter overflow at %lu\n" : - "%s:read error at %lu\n", filename, + warning (0, error < 0 ? "%s:counter overflow at %lu" : + "%s:read error at %lu", filename, (long unsigned) gcov_position ()); break; }