| Message ID | 91a4cac133cb7244903e872b9e63fbbd57fbd68c.1701768028.git.ysato@users.sourceforge.jp |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Device Tree support for SH7751 based board | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hi Sato-san, On Tue, Dec 5, 2023 at 10:46 AM Yoshinori Sato <ysato@users.sourceforge.jp> wrote: > Add SH7750 TMU entry. > > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> Thanks for your patch! > --- a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml > +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml > @@ -21,6 +21,7 @@ properties: > compatible: > items: > - enum: > + - renesas,tmu-sh7750 # SH7750 Please preserve alphabetical sort order. > - renesas,tmu-r8a7740 # R-Mobile A1 > - renesas,tmu-r8a774a1 # RZ/G2M > - renesas,tmu-r8a774b1 # RZ/G2N The rest LGTM. Gr{oetje,eeting}s, Geert
On 05/12/2023 10:45, Yoshinori Sato wrote: > diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml > index a67e427a9e7e..925c2a691b25 100644 > --- a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml > +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml > @@ -21,6 +21,7 @@ properties: > compatible: > items: > - enum: > + - renesas,tmu-sh7750 # SH7750 Please keep alphabetical order. > - renesas,tmu-r8a7740 # R-Mobile A1 > - renesas,tmu-r8a774a1 # RZ/G2M > - renesas,tmu-r8a774b1 # RZ/G2N > @@ -46,7 +47,14 @@ properties: > > interrupts: > minItems: 2 > - maxItems: 3 > + maxItems: 4 You need to constrain in allOf:if:then: existing and new variants. Old did not have 4 interrupts. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml index a67e427a9e7e..925c2a691b25 100644 --- a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml @@ -21,6 +21,7 @@ properties: compatible: items: - enum: + - renesas,tmu-sh7750 # SH7750 - renesas,tmu-r8a7740 # R-Mobile A1 - renesas,tmu-r8a774a1 # RZ/G2M - renesas,tmu-r8a774b1 # RZ/G2N @@ -46,7 +47,14 @@ properties: interrupts: minItems: 2 - maxItems: 3 + maxItems: 4 + + interrupt-names: + items: + - const: tuni0 + - const: tuni1 + - const: tuni2 + - const: ticpi2 clocks: maxItems: 1 @@ -84,6 +92,7 @@ if: - renesas,tmu-r8a7740 - renesas,tmu-r8a7778 - renesas,tmu-r8a7779 + - renesas,tmu-sh7750 then: required: - resets
Add SH7750 TMU entry. Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> --- .../devicetree/bindings/timer/renesas,tmu.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)