diff mbox series

[DO,NOT,MERGE,v5,04/37] dt-bindings: interrupt-controller: Add header for Renesas SH3/4 INTC.

Message ID 7b00e02e77d8c9fec4f5ecb5176e28837c87b062.1701768028.git.ysato@users.sourceforge.jp
State Changes Requested
Headers show
Series Device Tree support for SH7751 based board | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success

Commit Message

Yoshinori Sato Dec. 5, 2023, 9:45 a.m. UTC 
Renesas SH7751 Interrupt controller priority register define.

Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
---
 .../interrupt-controller/sh7751-intc.h        | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 include/dt-bindings/interrupt-controller/sh7751-intc.h

Comments

Krzysztof Kozlowski Dec. 5, 2023, 4:01 p.m. UTC | #1 
On 05/12/2023 10:45, Yoshinori Sato wrote:
> Renesas SH7751 Interrupt controller priority register define.
> 
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
>  .../interrupt-controller/sh7751-intc.h        | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 include/dt-bindings/interrupt-controller/sh7751-intc.h

Still missing vendor prefix. This applies to all your bindings.

> 
> diff --git a/include/dt-bindings/interrupt-controller/sh7751-intc.h b/include/dt-bindings/interrupt-controller/sh7751-intc.h
> new file mode 100644
> index 000000000000..5783ec72d70f
> --- /dev/null
> +++ b/include/dt-bindings/interrupt-controller/sh7751-intc.h
> @@ -0,0 +1,21 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> + *
> + * SH3/4 INTC EVT - IRQ conversion
> + */
> +
> +#ifndef __DT_BINDINGS_RENESAS_SH7751_INTC
> +#define __DT_BINDINGS_RENESAS_SH7751_INTC
> +
> +#define evt2irq(evt)		((evt) >> 5)

Still not a binding.

> +
> +#define IPRA			0
> +#define IPRB			4
> +#define IPRC			8
> +#define IPRD			12
> +#define INTPRI00		256
> +#define IPR_B12			12
> +#define IPR_B8			8
> +#define IPR_B4			4
> +#define IPR_B0			0

Neither these. Your commit msg says these are register values, so not
bindings.


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/include/dt-bindings/interrupt-controller/sh7751-intc.h b/include/dt-bindings/interrupt-controller/sh7751-intc.h
new file mode 100644
index 000000000000..5783ec72d70f
--- /dev/null
+++ b/include/dt-bindings/interrupt-controller/sh7751-intc.h
@@ -0,0 +1,21 @@ 
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+ *
+ * SH3/4 INTC EVT - IRQ conversion
+ */
+
+#ifndef __DT_BINDINGS_RENESAS_SH7751_INTC
+#define __DT_BINDINGS_RENESAS_SH7751_INTC
+
+#define evt2irq(evt)		((evt) >> 5)
+
+#define IPRA			0
+#define IPRB			4
+#define IPRC			8
+#define IPRD			12
+#define INTPRI00		256
+#define IPR_B12			12
+#define IPR_B8			8
+#define IPR_B4			4
+#define IPR_B0			0
+
+#endif