| Message ID | eae889ce783ef15ffa62e2af3f2d2ef0e8e079dd.1706448055.git.yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package: fix unmet dependencies (branch yem/misc-fixes) | expand |
On Sun, 28 Jan 2024 14:20:54 +0100 "Yann E. MORIN" <yann.morin.1998@free.fr> wrote: > Currently, the comment about availability is between the package main > symbol and its suboptions, breaking the threading in menuconfig. > > Invert the order, and move the comment last. Also enclose the suboptions > between an if-block, as it is more customary. > > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> > --- > package/petitboot/Config.in | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) Applied to master, thanks. Thomas
diff --git a/package/petitboot/Config.in b/package/petitboot/Config.in index 93ed3642c3..f931ab91cd 100644 --- a/package/petitboot/Config.in +++ b/package/petitboot/Config.in @@ -19,17 +19,20 @@ config BR2_PACKAGE_PETITBOOT http://www.kernel.org/pub/linux/kernel/people/geoff/petitboot/petitboot.html +if BR2_PACKAGE_PETITBOOT + +config BR2_PACKAGE_PETITBOOT_GETTY_PORT + string "TTY port(s)" + default "console" + help + Specify a space-separated list of ports to run the petitboot + UI on. Wildcards are allowed. Example: "hvc* ttys0 ttyS*" + +endif # BR2_PACKAGE_PETITBOOT + comment "petitboot needs a toolchain w/ wchar, dynamic library, threads, udev /dev management" depends on BR2_PACKAGE_KEXEC_ARCH_SUPPORTS depends on BR2_USE_MMU depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS || \ !BR2_TOOLCHAIN_HAS_THREADS || \ !BR2_PACKAGE_HAS_UDEV - -config BR2_PACKAGE_PETITBOOT_GETTY_PORT - string "TTY port(s)" - default "console" - depends on BR2_PACKAGE_PETITBOOT - help - Specify a space-separated list of ports to run the petitboot - UI on. Wildcards are allowed. Example: "hvc* ttys0 ttyS*"
Currently, the comment about availability is between the package main symbol and its suboptions, breaking the threading in menuconfig. Invert the order, and move the comment last. Also enclose the suboptions between an if-block, as it is more customary. Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> --- package/petitboot/Config.in | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-)