diff mbox series

[07/10] package/python-ml-dtypes: propagate dependencies from numpy, pybind

Message ID 3afcc982685e876ac9b2ae54f86164647040ab85.1706448055.git.yann.morin.1998@free.fr
State Not Applicable
Headers show
Series package: fix unmet dependencies (branch yem/misc-fixes) | expand

Commit Message

Yann E. MORIN Jan. 28, 2024, 1:20 p.m. UTC
Commit ebe47e7605c6 (package/python-ml-dtypes: new package) forgot to
account for all the dependencies from python-pybind and python-numpy,
causing unmet dependencies warnings (unfortunately, not errors), such
as:

    $ KCONFIG_SEED=0x85C244F4 make randconfig
    WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_NUMPY
      Depends on [n]: BR2_PACKAGE_PYTHON3 [=y] && BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS [=y] && BR2_INSTALL_LIBSTDCPP [=n] && (BR2_TOOLCHAIN_USES_GLIBC [=y] || BR2_TOOLCHAIN_USES_MUSL [=n]) && BR2_TOOLCHAIN_GCC_AT_LEAST_9 [=y]
      Selected by [y]:
      - BR2_PACKAGE_PYTHON_ML_DTYPES [=y] && BR2_PACKAGE_PYTHON3 [=y] && BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS [=y] && (BR2_TOOLCHAIN_USES_GLIBC [=y] || BR2_TOOLCHAIN_USES_MUSL [=n]) && BR2_TOOLCHAIN_GCC_AT_LEAST_9 [=y] && BR2_HOST_GCC_AT_LEAST_9 [=y]

    WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_PYBIND
      Depends on [n]: BR2_PACKAGE_PYTHON3 [=y] && BR2_INSTALL_LIBSTDCPP [=n]
      Selected by [y]:
      - BR2_PACKAGE_PYTHON_ML_DTYPES [=y] && BR2_PACKAGE_PYTHON3 [=y] && BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS [=y] && (BR2_TOOLCHAIN_USES_GLIBC [=y] || BR2_TOOLCHAIN_USES_MUSL [=n]) && BR2_TOOLCHAIN_GCC_AT_LEAST_9 [=y] && BR2_HOST_GCC_AT_LEAST_9 [=y]

Propagate the C++ dependency from both numpy and pybind.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Julien Olivain <ju.o@free.fr>
---
 package/python-ml-dtypes/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Feb. 7, 2024, 2:26 p.m. UTC | #1
On Sun, 28 Jan 2024 14:20:56 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Commit ebe47e7605c6 (package/python-ml-dtypes: new package) forgot to
> account for all the dependencies from python-pybind and python-numpy,
> causing unmet dependencies warnings (unfortunately, not errors), such
> as:
> 
>     $ KCONFIG_SEED=0x85C244F4 make randconfig
>     WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_NUMPY
>       Depends on [n]: BR2_PACKAGE_PYTHON3 [=y] && BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS [=y] && BR2_INSTALL_LIBSTDCPP [=n] && (BR2_TOOLCHAIN_USES_GLIBC [=y] || BR2_TOOLCHAIN_USES_MUSL [=n]) && BR2_TOOLCHAIN_GCC_AT_LEAST_9 [=y]
>       Selected by [y]:
>       - BR2_PACKAGE_PYTHON_ML_DTYPES [=y] && BR2_PACKAGE_PYTHON3 [=y] && BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS [=y] && (BR2_TOOLCHAIN_USES_GLIBC [=y] || BR2_TOOLCHAIN_USES_MUSL [=n]) && BR2_TOOLCHAIN_GCC_AT_LEAST_9 [=y] && BR2_HOST_GCC_AT_LEAST_9 [=y]
> 
>     WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_PYBIND
>       Depends on [n]: BR2_PACKAGE_PYTHON3 [=y] && BR2_INSTALL_LIBSTDCPP [=n]
>       Selected by [y]:
>       - BR2_PACKAGE_PYTHON_ML_DTYPES [=y] && BR2_PACKAGE_PYTHON3 [=y] && BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS [=y] && (BR2_TOOLCHAIN_USES_GLIBC [=y] || BR2_TOOLCHAIN_USES_MUSL [=n]) && BR2_TOOLCHAIN_GCC_AT_LEAST_9 [=y] && BR2_HOST_GCC_AT_LEAST_9 [=y]
> 
> Propagate the C++ dependency from both numpy and pybind.
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Julien Olivain <ju.o@free.fr>
> ---
>  package/python-ml-dtypes/Config.in | 1 +
>  1 file changed, 1 insertion(+)

This has already been fixed by
650c2b83b515bf6941189b837d87819a901ec901, which also added the
Config.in comment.

Thomas
diff mbox series

Patch

diff --git a/package/python-ml-dtypes/Config.in b/package/python-ml-dtypes/Config.in
index 72506896df..b0b67e0a9c 100644
--- a/package/python-ml-dtypes/Config.in
+++ b/package/python-ml-dtypes/Config.in
@@ -4,6 +4,7 @@  config BR2_PACKAGE_PYTHON_ML_DTYPES
 	depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL # python-numpy
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_9 # python-numpy
 	depends on BR2_HOST_GCC_AT_LEAST_9 # host-python-numpy
+	depends on BR2_INSTALL_LIBSTDCPP # python-numpy, python-pybind
 	select BR2_PACKAGE_PYTHON_NUMPY
 	select BR2_PACKAGE_PYTHON_PYBIND
 	help