| Message ID | CAPDLWs99Xx5ncxuCuFErsGzOnbs1br3VDcCFZooozWrHU+B=SQ@mail.gmail.com |
|---|---|
| State | Superseded |
| Commit | 209760 |
| Headers | show |
Hello Kaiwan, Am 03.01.2013 08:51, schrieb Kaiwan Billimoria: > Add perf tools support: this is the kernel patch to be applied to the > kernel for kernel compile to go through; it basically adds a typedef. > > Signed-off-by: Kaiwan Billimoria <kaiwan.billimoria@gmail.com> [SNIPP] your subject is a little bit to long. The first line shout idealy not longer than 50 characters be. The second line is always empty. After that there is more space for explanations. All your other patches are named the same, that can't be right. :) Why don't you use git-email? This make it a lot easier to send patches.
Hi Carsten, Thanks for your inputs. I don't have git send-email working, yet... So, will resend the 3rd patch (3/3) with a shorter subject line. Also, AFAIK, the Sub line has the phrase [PATCH n/3]; where n is 0, 1, 2 & 3, thus subject is unique (this is how git generated them). If this is not sufficient, pl let me know.. Thanks, Kaiwan. On Thu, Jan 3, 2013 at 2:03 PM, Carsten Schoenert <c.schoenert@gmail.com> wrote: > Hello Kaiwan, > > Am 03.01.2013 08:51, schrieb Kaiwan Billimoria: >> Add perf tools support: this is the kernel patch to be applied to the >> kernel for kernel compile to go through; it basically adds a typedef. >> >> Signed-off-by: Kaiwan Billimoria <kaiwan.billimoria@gmail.com> > > [SNIPP] > your subject is a little bit to long. > The first line shout idealy not longer than 50 characters be. The second > line is always empty. > After that there is more space for explanations. > > All your other patches are named the same, that can't be right. :) > > Why don't you use git-email? This make it a lot easier to send patches. > > -- > Regards > Carsten Schoenert >
Dear Kaiwan Billimoria, On Thu, 3 Jan 2013 15:37:09 +0530, Kaiwan Billimoria wrote: > Also, AFAIK, the Sub line has the phrase [PATCH n/3]; where n is 0, 1, > 2 & 3, thus subject is unique (this is how git generated them). If > this is not sufficient, pl let me know.. This is not sufficient. Everything between [...] is ignored when the patch is applied. Each of your patches should have a different commit message. That said, there is no reason for those 3 patches to be separate. If you apply patch 1 alone, you have a config option that does nothing. If you apply patches 1 and 2, then things break because it will try to apply perf.patch which does not exist. So basically, you should merge all your patches. Thomas
Dear Kaiwan Billimoria, On Thu, 3 Jan 2013 15:37:09 +0530, Kaiwan Billimoria wrote: > Thanks for your inputs. > I don't have git send-email working, yet... Another reason to use git send-email is that your patches have been line-wrapped by your e-mail client, so they are basically impossible to apply without manual fixes. Thomas
diff --git a/linux/perf.patch b/linux/perf.patch new file mode 100644 index 0000000..0fba468 --- /dev/null +++ b/linux/perf.patch @@ -0,0 +1,26 @@ +--- linux-3.2.21.orig//tools/perf/util/gelf.h 2013-01-01 16:01:11.736902336 +0530 ++++ linux-3.2.21/tools/perf/util/gelf.h 2013-01-01 16:03:58.076895032 +0530 +@@ -0,0 +1,10 @@ ++#ifndef __GELF_NHDR__ ++#include <libelf.h> ++#include <gelf.h> ++ ++#if __LIBELF64 ++typedef Elf64_Nhdr GElf_Nhdr; ++#else ++typedef Elf32_Nhdr GElf_Nhdr; ++#endif ++#endif +Index: linux-3.2.21/tools/perf/util/symbol.h +====================================================== +--- linux-3.2.21.orig//tools/perf/util/symbol.h 2013-01-01 16:01:11.836902336 +0530 ++++ linux-3.2.21/tools/perf/util/symbol.h 2013-01-01 16:03:58.176895032 +0530 +@@ -7,6 +7,7 @@ + #include "map.h" + #include <linux/list.h> + #include <linux/rbtree.h> ++#include "gelf.h" + #include <stdio.h> +
Add perf tools support: this is the kernel patch to be applied to the kernel for kernel compile to go through; it basically adds a typedef. Signed-off-by: Kaiwan Billimoria <kaiwan.billimoria@gmail.com> --- linux/perf.patch | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 linux/perf.patch + #ifdef HAVE_CPLUS_DEMANGLE +