| Message ID | 20231227182429.1215185-1-mail@sebastianbauer.info |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/3] Revert "package/libcamera-apps: bump to version 1.3.0" | expand |
Sebastien, All, On 2023-12-27 19:24 +0100, Sebastian Bauer spake thusly: > This reverts commit c9645fd29bf38b5a960aed3eeac36975d64a400a. > > Building libcamera-apps 1.3.0 with current libcamera 0.1.0 fails because > some of the symbols like controls::AeFlickerMode are not recognized. > According to my research, they have been introduced after libcamera 0.1.0 > but there is no release version of libcamera newer than 0.1.0 available > to which we could bump. > > Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info> Applied to master, thanks. Regards, Yann E. MORIN. > --- > package/libcamera-apps/libcamera-apps.hash | 2 +- > package/libcamera-apps/libcamera-apps.mk | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/libcamera-apps/libcamera-apps.hash b/package/libcamera-apps/libcamera-apps.hash > index 281aab88be..1437a0e8fa 100644 > --- a/package/libcamera-apps/libcamera-apps.hash > +++ b/package/libcamera-apps/libcamera-apps.hash > @@ -1,3 +1,3 @@ > # Locally computed > -sha256 92ff51e2aa4cd7165a8f5131df57cb0967a259bc74e4a47d7fb9dcfd65e45e25 libcamera-apps-1.3.0.tar.gz > +sha256 e6b74a0ba10a962f1930199d7dd828c8d9ee370dfe1fdfd8ae2638df744f1344 libcamera-apps-1.2.1.tar.gz > sha256 36dfed86bdef661a0a14ec1a1cc84c771d5a06b6f9b92e9ebb610ba711bd528a license.txt > diff --git a/package/libcamera-apps/libcamera-apps.mk b/package/libcamera-apps/libcamera-apps.mk > index d60e58e7e4..2a217f095f 100644 > --- a/package/libcamera-apps/libcamera-apps.mk > +++ b/package/libcamera-apps/libcamera-apps.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > > -LIBCAMERA_APPS_VERSION = 1.3.0 > +LIBCAMERA_APPS_VERSION = 1.2.1 > LIBCAMERA_APPS_SITE = $(call github,raspberrypi,libcamera-apps,v$(LIBCAMERA_APPS_VERSION)) > LIBCAMERA_APPS_LICENSE = BSD-2-Clause > LIBCAMERA_APPS_LICENSE_FILES = license.txt > -- > 2.43.0 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
>>>>> "Sebastian" == Sebastian Bauer <mail@sebastianbauer.info> writes: > This reverts commit c9645fd29bf38b5a960aed3eeac36975d64a400a. > Building libcamera-apps 1.3.0 with current libcamera 0.1.0 fails because > some of the symbols like controls::AeFlickerMode are not recognized. > According to my research, they have been introduced after libcamera 0.1.0 > but there is no release version of libcamera newer than 0.1.0 available > to which we could bump. > Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info> Committed to 2023.11.x, thanks.
>>>>> "Sebastian" == Sebastian Bauer <mail@sebastianbauer.info> writes: > This reverts commit c9645fd29bf38b5a960aed3eeac36975d64a400a. > Building libcamera-apps 1.3.0 with current libcamera 0.1.0 fails because > some of the symbols like controls::AeFlickerMode are not recognized. > According to my research, they have been introduced after libcamera 0.1.0 > but there is no release version of libcamera newer than 0.1.0 available > to which we could bump. > Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info> FYI, there is now a libcamera 0.2.0 release: https://git.linuxtv.org/libcamera.git/commit/?id=89227a428a82e724548399d35c98ea89566f9045
Am 2024-01-10 16:30, schrieb Peter Korsgaard: >>>>>> "Sebastian" == Sebastian Bauer <mail@sebastianbauer.info> writes: > > This reverts commit c9645fd29bf38b5a960aed3eeac36975d64a400a. > > Building libcamera-apps 1.3.0 with current libcamera 0.1.0 fails > because > > some of the symbols like controls::AeFlickerMode are not recognized. > > According to my research, they have been introduced after libcamera > 0.1.0 > > but there is no release version of libcamera newer than 0.1.0 > available > > to which we could bump. > > > Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info> > > FYI, there is now a libcamera 0.2.0 release: > > https://git.linuxtv.org/libcamera.git/commit/?id=89227a428a82e724548399d35c98ea89566f9045 Thanks for the hint. I would bump libcamera to 0.2.0 after testing, but I think it should happen together with libcamera-apps (now called rpicam-apps). IMO, patch 3/3 should to applied first to master to gradually switch. Note that it appears that Raspberry Pi foundation seems to maintains an own fork of libcamera (https://github.com/raspberrypi/libcamera), which may explain the previous libcamera-apps breakage. I'm not really sure how to to deal with that in context of buildroot. Bye Sebastian
Quoting Sebastian Bauer (2024-01-10 21:57:28) > Am 2024-01-10 16:30, schrieb Peter Korsgaard: > >>>>>> "Sebastian" == Sebastian Bauer <mail@sebastianbauer.info> writes: > > > This reverts commit c9645fd29bf38b5a960aed3eeac36975d64a400a. > > > Building libcamera-apps 1.3.0 with current libcamera 0.1.0 fails > > because > > > some of the symbols like controls::AeFlickerMode are not recognized. > > > According to my research, they have been introduced after libcamera > > 0.1.0 > > > but there is no release version of libcamera newer than 0.1.0 > > available > > > to which we could bump. > > > > > Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info> > > > > FYI, there is now a libcamera 0.2.0 release: > > > > https://git.linuxtv.org/libcamera.git/commit/?id=89227a428a82e724548399d35c98ea89566f9045 > > Thanks for the hint. I would bump libcamera to 0.2.0 after testing, but > I think it should happen together with libcamera-apps (now called > rpicam-apps). IMO, patch 3/3 should to applied first to master to > gradually switch. The controls::AeFlickerMode issue would already be resolved by moving to 0.2, however unfortunately another issue then creeps in ... > Note that it appears that Raspberry Pi foundation seems to maintains an > own fork of libcamera (https://github.com/raspberrypi/libcamera), which > may explain the previous libcamera-apps breakage. I'm not really sure > how to to deal with that in context of buildroot. Their fork has the Pi5 support. This brings in some additional pixel formats, which are not yet upstream in the linux kernel. We talked to RPi earlier, so we're all working to resolve this, but it may take a couple of weeks still. We'll do anything I can to accelerate at least the pixelformat issue which would fix this breakage sooner. The goal is to get Pi5 support upstream of course. Raspberry Pi are actively working on upstreaming the core Pi5 kernel support, so it will get there - but they haven't been able to send things out yet. Along side that - the ISP support will be posted as soon as possible. That would then introduce the new pixelformats, which we can then bring into libcamera. Ultimately, it's unfortunate, but Raspberry Pi have 'released' a version of rpicam-apps which will not work with the current libcamera mainline tree. This gives them a working system for Pi5. And that's up to them, as they have full control over Raspberry Pi OS ... but causes pain for everyone else. I don't know how to handle that 'now' though, except perhaps wait for the upstreaming to make more progress. -- Kieran
Quoting Kieran Bingham (2024-01-11 16:03:36) > Quoting Sebastian Bauer (2024-01-10 21:57:28) > > Am 2024-01-10 16:30, schrieb Peter Korsgaard: > > >>>>>> "Sebastian" == Sebastian Bauer <mail@sebastianbauer.info> writes: > > > > This reverts commit c9645fd29bf38b5a960aed3eeac36975d64a400a. > > > > Building libcamera-apps 1.3.0 with current libcamera 0.1.0 fails > > > because > > > > some of the symbols like controls::AeFlickerMode are not recognized. > > > > According to my research, they have been introduced after libcamera > > > 0.1.0 > > > > but there is no release version of libcamera newer than 0.1.0 > > > available > > > > to which we could bump. > > > > > > > Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info> > > > > > > FYI, there is now a libcamera 0.2.0 release: > > > > > > https://git.linuxtv.org/libcamera.git/commit/?id=89227a428a82e724548399d35c98ea89566f9045 > > > > Thanks for the hint. I would bump libcamera to 0.2.0 after testing, but > > I think it should happen together with libcamera-apps (now called > > rpicam-apps). IMO, patch 3/3 should to applied first to master to > > gradually switch. > > The controls::AeFlickerMode issue would already be resolved by moving to > 0.2, however unfortunately another issue then creeps in ... > > > Note that it appears that Raspberry Pi foundation seems to maintains an > > own fork of libcamera (https://github.com/raspberrypi/libcamera), which > > may explain the previous libcamera-apps breakage. I'm not really sure > > how to to deal with that in context of buildroot. > > Their fork has the Pi5 support. This brings in some additional pixel > formats, which are not yet upstream in the linux kernel. We talked to > RPi earlier, so we're all working to resolve this, but it may take a > couple of weeks still. > > We'll do anything I can to accelerate at least the pixelformat issue > which would fix this breakage sooner. > > The goal is to get Pi5 support upstream of course. Raspberry Pi are > actively working on upstreaming the core Pi5 kernel support, so it will > get there - but they haven't been able to send things out yet. > > Along side that - the ISP support will be posted as soon as possible. > That would then introduce the new pixelformats, which we can then bring > into libcamera. > > Ultimately, it's unfortunate, but Raspberry Pi have 'released' a version > of rpicam-apps which will not work with the current libcamera mainline > tree. This gives them a working system for Pi5. And that's up to them, > as they have full control over Raspberry Pi OS ... but causes pain for > everyone else. I don't know how to handle that 'now' though, except > perhaps wait for the upstreaming to make more progress. Actually, to be clearer. I would suggest updating to libcamera-0.2, and then make sure rpicam-apps (or libcamera-apps, if it's that far back) is pinned to whatever version /does/ compile successfully against libcamera-0.2 to be able to continue supporting Pi4. Then rpicam-apps should only be updated when the Pi5 support is completed, or at least unblocked. -- Kieran
Am 2024-01-11 17:05, schrieb Kieran Bingham: > Actually, to be clearer. I would suggest updating to libcamera-0.2, and > then make sure rpicam-apps (or libcamera-apps, if it's that far back) > is > pinned to whatever version /does/ compile successfully against > libcamera-0.2 to be able to continue supporting Pi4. Sounds good to me. I can try to come up with something, unless someone would like to steps forward. We are using this RPi4 setting with cameras in some courses at the HTW Berlin in the programme Computer Engineering, and I ideally would like to base everything on plain Buildroot. Thanks a lot for your clarification. Bye Sebastian
On 15/01/24 21:54, Sebastian Bauer wrote: >> Actually, to be clearer. I would suggest updating to libcamera-0.2, and >> then make sure rpicam-apps (or libcamera-apps, if it's that far back) >> is >> pinned to whatever version /does/ compile successfully against >> libcamera-0.2 to be able to continue supporting Pi4. > > Sounds good to me. I can try to come up with something, unless someone > would like to steps forward. Hi, We are using Buildroot 2024.02.1 LTS. Seems libcamera-apps v1.2.1 package build failing with the dependency libcamera v0.2.0. I also couldn't find any related patches/fix to resolve this in patchwork. Is anybody facing this? Help is appreciated. I noticed BR 2023.11.3 (released on March 26th) still using libcamera v0.1.0 though.
diff --git a/package/libcamera-apps/libcamera-apps.hash b/package/libcamera-apps/libcamera-apps.hash index 281aab88be..1437a0e8fa 100644 --- a/package/libcamera-apps/libcamera-apps.hash +++ b/package/libcamera-apps/libcamera-apps.hash @@ -1,3 +1,3 @@ # Locally computed -sha256 92ff51e2aa4cd7165a8f5131df57cb0967a259bc74e4a47d7fb9dcfd65e45e25 libcamera-apps-1.3.0.tar.gz +sha256 e6b74a0ba10a962f1930199d7dd828c8d9ee370dfe1fdfd8ae2638df744f1344 libcamera-apps-1.2.1.tar.gz sha256 36dfed86bdef661a0a14ec1a1cc84c771d5a06b6f9b92e9ebb610ba711bd528a license.txt diff --git a/package/libcamera-apps/libcamera-apps.mk b/package/libcamera-apps/libcamera-apps.mk index d60e58e7e4..2a217f095f 100644 --- a/package/libcamera-apps/libcamera-apps.mk +++ b/package/libcamera-apps/libcamera-apps.mk @@ -4,7 +4,7 @@ # ################################################################################ -LIBCAMERA_APPS_VERSION = 1.3.0 +LIBCAMERA_APPS_VERSION = 1.2.1 LIBCAMERA_APPS_SITE = $(call github,raspberrypi,libcamera-apps,v$(LIBCAMERA_APPS_VERSION)) LIBCAMERA_APPS_LICENSE = BSD-2-Clause LIBCAMERA_APPS_LICENSE_FILES = license.txt
This reverts commit c9645fd29bf38b5a960aed3eeac36975d64a400a. Building libcamera-apps 1.3.0 with current libcamera 0.1.0 fails because some of the symbols like controls::AeFlickerMode are not recognized. According to my research, they have been introduced after libcamera 0.1.0 but there is no release version of libcamera newer than 0.1.0 available to which we could bump. Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info> --- package/libcamera-apps/libcamera-apps.hash | 2 +- package/libcamera-apps/libcamera-apps.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)