diff mbox series

[v1,2/4] package/libcamera: disable python bindings by default

Message ID 20231109212901.5596-2-ps.report@gmx.net
State Accepted
Headers show
Series [v1,1/4] package/libcamera: pipeline option 'raspberrypi' changed to 'rpi/vc4' | expand

Commit Message

Peter Seiderer Nov. 9, 2023, 9:28 p.m. UTC
Disable python binding option (introduced with upstream commit [1] (since
version v0.0.1) by default.

[1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=8aa02271fd716ed046970a0b1f89176963303f50

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/libcamera/libcamera.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Yann E. MORIN Dec. 27, 2023, 10:25 p.m. UTC | #1
Peter, All,

On 2023-11-09 22:28 +0100, Peter Seiderer spake thusly:
> Disable python binding option (introduced with upstream commit [1] (since
> version v0.0.1) by default.

Since there i s no way to enabled them with this change, they are not
"disabled *by default*"; they are just "disabled".

So I dropped the "y default" part of the title and the commit log.

Applied to master, thanks.

Regards,
Yann E. MORIN.

> [1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=8aa02271fd716ed046970a0b1f89176963303f50
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  package/libcamera/libcamera.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
> index c1c8bb7b33..8b33b9e708 100644
> --- a/package/libcamera/libcamera.mk
> +++ b/package/libcamera/libcamera.mk
> @@ -19,6 +19,7 @@ LIBCAMERA_CONF_OPTS = \
>  	-Dandroid=disabled \
>  	-Ddocumentation=disabled \
>  	-Dtest=false \
> +	-Dpycamera=disabled \
>  	-Dwerror=false
>  LIBCAMERA_INSTALL_STAGING = YES
>  LIBCAMERA_LICENSE = \
> -- 
> 2.42.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Peter Korsgaard Jan. 10, 2024, 3:39 p.m. UTC | #2
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Peter, All,
 > On 2023-11-09 22:28 +0100, Peter Seiderer spake thusly:
 >> Disable python binding option (introduced with upstream commit [1] (since
 >> version v0.0.1) by default.

 > Since there i s no way to enabled them with this change, they are not
 > "disabled *by default*"; they are just "disabled".

 > So I dropped the "y default" part of the title and the commit log.

 > Applied to master, thanks.

Committed to 2023.02.x and 2023.11.x, thanks.
diff mbox series

Patch

diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
index c1c8bb7b33..8b33b9e708 100644
--- a/package/libcamera/libcamera.mk
+++ b/package/libcamera/libcamera.mk
@@ -19,6 +19,7 @@  LIBCAMERA_CONF_OPTS = \
 	-Dandroid=disabled \
 	-Ddocumentation=disabled \
 	-Dtest=false \
+	-Dpycamera=disabled \
 	-Dwerror=false
 LIBCAMERA_INSTALL_STAGING = YES
 LIBCAMERA_LICENSE = \