| Message ID | 20221020141412.346992-3-tobias@waldekranz.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/kmemd: new package | expand |
Hello Tobias, On Thu, 20 Oct 2022 16:14:10 +0200 Tobias Waldekranz <tobias@waldekranz.com> wrote: > Since 3145adfb69ba, libbpf depends on Linux headers >= 4.13. This > requirement renders the explicit list of supported architectures, > previously added in f693354c30bd overly restrictive, as the syscall > number for bpf(2) has been defined since Linux 3.18. > > f693354c30bd was introduced to fix a build issue where a toolchain > using very old kernel headers (3.13) failed to build libbpf for ARM. > > Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> > --- > package/libbpf/Config.in | 11 ----------- > 1 file changed, 11 deletions(-) It is not easy to check if the bpf syscall was indeed wired up in all architectures we support, but let's assume it's the case as of 4.13 :-) I have applied, with a slightly improved commit log: package/libbpf: remove architecture restrictions Since Buildroot commit 3145adfb69ba ("package/libbpf: needs headers >= 4.13"), libbpf depends on Linux headers >= 4.13. This requirement renders the explicit list of supported architectures, previously added in f693354c30bd overly restrictive, as the syscall number for bpf(2) has been defined since Linux 3.18. Commit f693354c30bd ("package/libbpf: add BR2_PACKAGE_LIBBPF_ARCH_SUPPORTS") was introduced to fix a build issue where a toolchain using very old kernel headers (3.13) failed to build libbpf for ARM, but these architecture dependencies are no longer needed due to the bump on the kernel headers version requirement. Thanks a lot! Thomas
diff --git a/package/libbpf/Config.in b/package/libbpf/Config.in index b3d6e44c6a..1465366c9e 100644 --- a/package/libbpf/Config.in +++ b/package/libbpf/Config.in @@ -1,15 +1,5 @@ -config BR2_PACKAGE_LIBBPF_ARCH_SUPPORTS - bool - # see src/bpf.c - default y if BR2_arc - default y if BR2_aarch64 || BR2_aarch64_be - default y if BR2_i386 || BR2_x86_64 - default y if BR2_sparc || BR2_sparc64 - default y if BR2_s390x - config BR2_PACKAGE_LIBBPF bool "libbpf" - depends on BR2_PACKAGE_LIBBPF_ARCH_SUPPORTS depends on BR2_TOOLCHAIN_HAS_SYNC_4 depends on BR2_USE_WCHAR # elfutils depends on !BR2_STATIC_LIBS # elfutils @@ -27,7 +17,6 @@ config BR2_PACKAGE_LIBBPF https://github.com/libbpf/libbpf comment "libbpf needs a uClibc or glibc toolchain w/ wchar, dynamic library, threads, headers >= 4.13" - depends on BR2_PACKAGE_LIBBPF_ARCH_SUPPORTS depends on BR2_TOOLCHAIN_HAS_SYNC_4 depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS \ || !BR2_TOOLCHAIN_HAS_THREADS \
Since 3145adfb69ba, libbpf depends on Linux headers >= 4.13. This requirement renders the explicit list of supported architectures, previously added in f693354c30bd overly restrictive, as the syscall number for bpf(2) has been defined since Linux 3.18. f693354c30bd was introduced to fix a build issue where a toolchain using very old kernel headers (3.13) failed to build libbpf for ARM. Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> --- package/libbpf/Config.in | 11 ----------- 1 file changed, 11 deletions(-)