Message ID | 20210515070141.396977-1-bernd.kuhls@t-online.de |
---|---|
State | Accepted |
Headers | show |
Series | [PATCH/next,v2,1/1] package/libbluray: add optional support for libudfread | expand |
Bernd, All, On 2021-05-15 09:01 +0200, Bernd Kuhls spake thusly: > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> In fact, this is fixing a hidden optional dependency, so I've applied to master. Thanks! Regards, Yann E. MORIN. > --- > v2: rebased, removed patch which is included in current upstream release > > package/libbluray/libbluray.mk | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/package/libbluray/libbluray.mk b/package/libbluray/libbluray.mk > index 5c5f603dd8..233797f38d 100644 > --- a/package/libbluray/libbluray.mk > +++ b/package/libbluray/libbluray.mk > @@ -19,6 +19,10 @@ ifeq ($(BR2_PACKAGE_LIBICONV),y) > LIBBLURAY_DEPENDENCIES += libiconv > endif > > +ifeq ($(BR2_PACKAGE_LIBUDFREAD),y) > +LIBBLURAY_DEPENDENCIES += libudfread > +endif > + > ifeq ($(BR2_PACKAGE_FREETYPE),y) > LIBBLURAY_DEPENDENCIES += freetype > LIBBLURAY_CONF_OPTS += --with-freetype > -- > 2.29.2 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Am Sat, 15 May 2021 18:15:29 +0200 schrieb Yann E. MORIN: > Bernd, All, > > On 2021-05-15 09:01 +0200, Bernd Kuhls spake thusly: >> Signed-off-by: Bernd Kuhls >> <bernd.kuhls@t-online.de> > > In fact, this is fixing a hidden optional dependency, so I've applied to > master. Thanks! Hi Yann, this is a bad idea because libbluray-1.2.1 contains a bug detecting libudfread so I sent the patch for the -next branch which contains the bump to the fixed libbluray version 1.3.0. My original patch from February also contained a backported patch to fix the problem for libbluray-1.2.1: http://patchwork.ozlabs.org/project/ buildroot/patch/20210221172307.289368-1-bernd.kuhls@t-online.de/ So for the master branch, which is broken atm w.r.t. to the detection of udfread by libbluray, we have three choices: - revert this commit - apply the full patch http://patchwork.ozlabs.org/project/buildroot/ patch/20210221172307.289368-1-bernd.kuhls@t-online.de/ - bump libbluray to 1.3.0 Regards, Bernd PS: @Yann: I did not sent this mail CC to you because all mails I try to send are bouncing for years now: <yann.morin.1998@free.fr>: host mx1.free.fr[212.27.48.7] said: 451 too many errors from your ip (194.25.134.83), please visit http://postmaster.free.fr/ (in reply to DATA command)
Bernd, All, On 2021-05-15 22:40 +0200, Bernd Kuhls spake thusly: > Am Sat, 15 May 2021 18:15:29 +0200 schrieb Yann E. MORIN: > > > Bernd, All, > > > > On 2021-05-15 09:01 +0200, Bernd Kuhls spake thusly: > >> Signed-off-by: Bernd Kuhls > >> <bernd.kuhls@t-online.de> > > > > In fact, this is fixing a hidden optional dependency, so I've applied to > > master. Thanks! > > Hi Yann, > > this is a bad idea because libbluray-1.2.1 contains a bug detecting > libudfread so I sent the patch for the -next branch which contains the > bump to the fixed libbluray version 1.3.0. Ah, I was afraid of that. But then, what guarantees, on master, that libudfread is never built before libbluray? > My original patch from February also contained a backported patch to fix > the problem for libbluray-1.2.1: http://patchwork.ozlabs.org/project/ > buildroot/patch/20210221172307.289368-1-bernd.kuhls@t-online.de/ Ah, yes, I remember that patch, now. OK, so the bug is that, even if libudfread is present, libbluray will not find it, because it is not looking for the correct name. > So for the master branch, which is broken atm w.r.t. to the detection of In fact, it is not more broken than before: libbluray was never going to detect libudfread becasue it is not looking for the correct name. > udfread by libbluray, we have three choices: > > - revert this commit Right, I will do that, and apply it to next. > - apply the full patch http://patchwork.ozlabs.org/project/buildroot/ > patch/20210221172307.289368-1-bernd.kuhls@t-online.de/ > - bump libbluray to 1.3.0 Thanks for the heads up! :-) > Regards, Bernd > > PS: @Yann: > I did not sent this mail CC to you because all mails I try to send are > bouncing for years now: > > <yann.morin.1998@free.fr>: host mx1.free.fr[212.27.48.7] said: 451 too > many > errors from your ip (194.25.134.83), please visit > http://postmaster.free.fr/ (in reply to DATA command) This error means just that: the MX server for free.fr has detected too many errors from your IP (presumably someone at your ISP caused some black list to include that IP...) I have no lever on how free.fr or t-online manage their servers... :-/ Regards, Yann E. MORIN. > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Bernd, All, On 2021-05-15 09:01 +0200, Bernd Kuhls spake thusly: > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> Applied to next, thanks. Regards, Yann E. MORIN. > --- > v2: rebased, removed patch which is included in current upstream release > > package/libbluray/libbluray.mk | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/package/libbluray/libbluray.mk b/package/libbluray/libbluray.mk > index 5c5f603dd8..233797f38d 100644 > --- a/package/libbluray/libbluray.mk > +++ b/package/libbluray/libbluray.mk > @@ -19,6 +19,10 @@ ifeq ($(BR2_PACKAGE_LIBICONV),y) > LIBBLURAY_DEPENDENCIES += libiconv > endif > > +ifeq ($(BR2_PACKAGE_LIBUDFREAD),y) > +LIBBLURAY_DEPENDENCIES += libudfread > +endif > + > ifeq ($(BR2_PACKAGE_FREETYPE),y) > LIBBLURAY_DEPENDENCIES += freetype > LIBBLURAY_CONF_OPTS += --with-freetype > -- > 2.29.2 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
diff --git a/package/libbluray/libbluray.mk b/package/libbluray/libbluray.mk index 5c5f603dd8..233797f38d 100644 --- a/package/libbluray/libbluray.mk +++ b/package/libbluray/libbluray.mk @@ -19,6 +19,10 @@ ifeq ($(BR2_PACKAGE_LIBICONV),y) LIBBLURAY_DEPENDENCIES += libiconv endif +ifeq ($(BR2_PACKAGE_LIBUDFREAD),y) +LIBBLURAY_DEPENDENCIES += libudfread +endif + ifeq ($(BR2_PACKAGE_FREETYPE),y) LIBBLURAY_DEPENDENCIES += freetype LIBBLURAY_CONF_OPTS += --with-freetype
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- v2: rebased, removed patch which is included in current upstream release package/libbluray/libbluray.mk | 4 ++++ 1 file changed, 4 insertions(+)