| Message ID | 20200825210143.293881-2-thomas.petazzoni@bootlin.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] package/assimp: workaround m68k build issues | expand |
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes: > Since the bump of assimp to 5.0.1, we have build failures on mips64el, > due to relocations being truncated. The issue seems to be quite > similar to the one on m68k coldfire, as both m68k and MIPS have this > -mxgot gcc option to switch to using a GOT that has no size limit (but > causes less efficient code to be produced). > Here as well, the overall relevance of assimp on mips64(el) platforms > being probably very limited, the incentive to search for a better > solution is pretty limited. > Fixes: > http://autobuild.buildroot.net/results/7df487d5117b2ee440a07dbff9cae1b181566748/ > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Committed to 2020.05.x, thanks.
diff --git a/package/assimp/assimp.mk b/package/assimp/assimp.mk index e8620c859a..e1b9a23499 100644 --- a/package/assimp/assimp.mk +++ b/package/assimp/assimp.mk @@ -17,6 +17,13 @@ ifeq ($(BR2_m68k),y) ASSIMP_CXXFLAGS += -mxgot -O0 endif +# just like m68k coldfire, mips64 also has some limitations on the GOT +# size for large libraries, which can be overcome by passing +# -mxgot. Solves "relocation truncated to fit: R_MIPS_CALL16" issues. +ifeq ($(BR2_mips64)$(BR2_mips64el),y) +ASSIMP_CXXFLAGS += -mxgot +endif + # workaround SuperH compiler failure when static linking (i.e -fPIC is # not passed) in gcc versions 5.x or older. The -Os optimization level # causes a "unable to find a register to spill in class
Since the bump of assimp to 5.0.1, we have build failures on mips64el, due to relocations being truncated. The issue seems to be quite similar to the one on m68k coldfire, as both m68k and MIPS have this -mxgot gcc option to switch to using a GOT that has no size limit (but causes less efficient code to be produced). Here as well, the overall relevance of assimp on mips64(el) platforms being probably very limited, the incentive to search for a better solution is pretty limited. Fixes: http://autobuild.buildroot.net/results/7df487d5117b2ee440a07dbff9cae1b181566748/ Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- package/assimp/assimp.mk | 7 +++++++ 1 file changed, 7 insertions(+)