[1/2] package/assimp: workaround m68k build issues

On m68k coldfire, we already pass -mxgot, but since the bump to assimp
5.0.1, this is no longer sufficient, and we have failures such as:

/tmp/ccqmJLil.s: Assembler messages:
/tmp/ccqmJLil.s:307948: Error: value -43420 out of range
/tmp/ccqmJLil.s:307985: Error: value -38606 out of range
/tmp/ccqmJLil.s:308010: Error: value -38626 out of range
/tmp/ccqmJLil.s:308056: Error: value -33280 out of range

Since these issues only arise when building with -O2, let's disable
the optimization for this package on m68k. The very relative relevance
of assimp on m68k coldfire makes the research of a better solution not
really useful (for the record, assimp is a "library to import various
well-known 3D model formats in a uniform manner").

Fixes:

  http://autobuild.buildroot.net/results/a7d4fb2653b0f1be4d036ee46a44e72da0ed4376/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/assimp/assimp.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Thomas, All,

On 2020-08-25 23:01 +0200, Thomas Petazzoni spake thusly:
> On m68k coldfire, we already pass -mxgot, but since the bump to assimp
> 5.0.1, this is no longer sufficient, and we have failures such as:
> 
> /tmp/ccqmJLil.s: Assembler messages:
> /tmp/ccqmJLil.s:307948: Error: value -43420 out of range
> /tmp/ccqmJLil.s:307985: Error: value -38606 out of range
> /tmp/ccqmJLil.s:308010: Error: value -38626 out of range
> /tmp/ccqmJLil.s:308056: Error: value -33280 out of range
> 
> Since these issues only arise when building with -O2, let's disable
> the optimization for this package on m68k. The very relative relevance
> of assimp on m68k coldfire makes the research of a better solution not
> really useful (for the record, assimp is a "library to import various
> well-known 3D model formats in a uniform manner").
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/a7d4fb2653b0f1be4d036ee46a44e72da0ed4376/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Both applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/assimp/assimp.mk | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/assimp/assimp.mk b/package/assimp/assimp.mk
> index 4aeb2963a9..e8620c859a 100644
> --- a/package/assimp/assimp.mk
> +++ b/package/assimp/assimp.mk
> @@ -10,9 +10,11 @@ ASSIMP_LICENSE = BSD-3-Clause
>  ASSIMP_LICENSE_FILES = LICENSE
>  ASSIMP_INSTALL_STAGING = YES
>  
> -# relocation truncated to fit: R_68K_GOT16O
> +# relocation truncated to fit: R_68K_GOT16O. We also need to disable
> +# optimizations to not run into "Error: value -43420 out of range"
> +# assembler issues.
>  ifeq ($(BR2_m68k),y)
> -ASSIMP_CXXFLAGS += -mxgot
> +ASSIMP_CXXFLAGS += -mxgot -O0
>  endif
>  
>  # workaround SuperH compiler failure when static linking (i.e -fPIC is
> -- 
> 2.26.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On m68k coldfire, we already pass -mxgot, but since the bump to assimp
 > 5.0.1, this is no longer sufficient, and we have failures such as:

 > /tmp/ccqmJLil.s: Assembler messages:
 > /tmp/ccqmJLil.s:307948: Error: value -43420 out of range
 > /tmp/ccqmJLil.s:307985: Error: value -38606 out of range
 > /tmp/ccqmJLil.s:308010: Error: value -38626 out of range
 > /tmp/ccqmJLil.s:308056: Error: value -33280 out of range

 > Since these issues only arise when building with -O2, let's disable
 > the optimization for this package on m68k. The very relative relevance
 > of assimp on m68k coldfire makes the research of a better solution not
 > really useful (for the record, assimp is a "library to import various
 > well-known 3D model formats in a uniform manner").

 > Fixes:

 >   http://autobuild.buildroot.net/results/a7d4fb2653b0f1be4d036ee46a44e72da0ed4376/

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2020.05.x, thanks.