| Message ID | 20200510154347.5711-1-mark@dibsco.co.uk |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/3] toolchain/toolchain-buildroot: enable uclibc for riscv64 | expand |
Hi Mark, Le 10/05/2020 à 17:43, Mark Corbin a écrit : > We can enable uclibc for RISC-V 64 bit now that it has been > bumped from v1.0.32 to v1.0.34. > > Uclibc has had basic support for RISC-V 64 bit since v1.0.31, but > shared library and TLS/NPTL support has only been available since > v1.0.33. > > This update has been tested using qemu_riscv64_virt_defconfig and > the Buildroot host QEMU. Since uclibc-ng is the default libc in Buildroot, enabling riscv64 change implicitly the libc used by qemu_riscv64_virt_defconfig. Before this patch qemu_riscv64_virt_defconfig used glibc, after it use uclibc-ng (like other defconfig does). Maybe add a commit before this one enabling explicitly glibc in qemu_riscv64_virt_defconfig, then add this commit and finally a third commit switching qemu_riscv64_virt_defconfig from glibc to uclibc-ng. Anyway it's good to see new architecture supported in uclibc-ng. Best regards, Romain > > Signed-off-by: Mark Corbin <mark@dibsco.co.uk> > --- > Changes v1 -> v2: > - use BR2_RISCV_64 instead of (BR2_riscv && BR2_ARCH_IS_64) > (Thomas P) > --- > package/uclibc/Config.in | 1 + > toolchain/toolchain-buildroot/Config.in | 13 +++++++------ > 2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in > index de2885bc92..f4d4f06462 100644 > --- a/package/uclibc/Config.in > +++ b/package/uclibc/Config.in > @@ -101,6 +101,7 @@ config BR2_UCLIBC_TARGET_ARCH > default "mips" if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el > default "or1k" if BR2_or1k > default "powerpc" if BR2_powerpc > + default "riscv64" if BR2_RISCV_64 > default "sh" if BR2_sh > default "sparc" if BR2_sparc > default "xtensa" if BR2_xtensa > diff --git a/toolchain/toolchain-buildroot/Config.in b/toolchain/toolchain-buildroot/Config.in > index 8c33b2b4dd..3b2da333a2 100644 > --- a/toolchain/toolchain-buildroot/Config.in > +++ b/toolchain/toolchain-buildroot/Config.in > @@ -27,12 +27,13 @@ choice > > config BR2_TOOLCHAIN_BUILDROOT_UCLIBC > bool "uClibc-ng" > - depends on BR2_aarch64 || BR2_aarch64_be || BR2_arcle || BR2_arceb || \ > - BR2_arm || BR2_armeb || \ > - BR2_i386 || BR2_m68k || BR2_microblaze || \ > - BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \ > - BR2_or1k || BR2_powerpc || BR2_sh2a || BR2_sh4 || \ > - BR2_sh4eb || BR2_sparc || BR2_xtensa || BR2_x86_64 > + depends on BR2_aarch64 || BR2_aarch64_be || BR2_arcle || BR2_arceb || \ > + BR2_arm || BR2_armeb || \ > + BR2_i386 || BR2_m68k || BR2_microblaze || \ > + BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \ > + BR2_or1k || BR2_powerpc || BR2_RISCV_64 || \ > + BR2_sh2a || BR2_sh4 || BR2_sh4eb || BR2_sparc || \ > + BR2_xtensa || BR2_x86_64 > select BR2_TOOLCHAIN_USES_UCLIBC > help > This option selects uClibc-ng as the C library for the >
Le 13/07/2020 à 23:50, Romain Naour a écrit : > Hi Mark, > > Le 10/05/2020 à 17:43, Mark Corbin a écrit : >> We can enable uclibc for RISC-V 64 bit now that it has been >> bumped from v1.0.32 to v1.0.34. >> >> Uclibc has had basic support for RISC-V 64 bit since v1.0.31, but >> shared library and TLS/NPTL support has only been available since >> v1.0.33. >> >> This update has been tested using qemu_riscv64_virt_defconfig and >> the Buildroot host QEMU. > > Since uclibc-ng is the default libc in Buildroot, enabling riscv64 change > implicitly the libc used by qemu_riscv64_virt_defconfig. > > Before this patch qemu_riscv64_virt_defconfig used glibc, after it use uclibc-ng > (like other defconfig does). > > Maybe add a commit before this one enabling explicitly glibc in > qemu_riscv64_virt_defconfig, then add this commit and finally a third commit > switching qemu_riscv64_virt_defconfig from glibc to uclibc-ng. Same for hifive_unleashed_defconfig. Best regards, Romain > > Anyway it's good to see new architecture supported in uclibc-ng. > > Best regards, > Romain > >> >> Signed-off-by: Mark Corbin <mark@dibsco.co.uk> >> --- >> Changes v1 -> v2: >> - use BR2_RISCV_64 instead of (BR2_riscv && BR2_ARCH_IS_64) >> (Thomas P) >> --- >> package/uclibc/Config.in | 1 + >> toolchain/toolchain-buildroot/Config.in | 13 +++++++------ >> 2 files changed, 8 insertions(+), 6 deletions(-) >> >> diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in >> index de2885bc92..f4d4f06462 100644 >> --- a/package/uclibc/Config.in >> +++ b/package/uclibc/Config.in >> @@ -101,6 +101,7 @@ config BR2_UCLIBC_TARGET_ARCH >> default "mips" if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el >> default "or1k" if BR2_or1k >> default "powerpc" if BR2_powerpc >> + default "riscv64" if BR2_RISCV_64 >> default "sh" if BR2_sh >> default "sparc" if BR2_sparc >> default "xtensa" if BR2_xtensa >> diff --git a/toolchain/toolchain-buildroot/Config.in b/toolchain/toolchain-buildroot/Config.in >> index 8c33b2b4dd..3b2da333a2 100644 >> --- a/toolchain/toolchain-buildroot/Config.in >> +++ b/toolchain/toolchain-buildroot/Config.in >> @@ -27,12 +27,13 @@ choice >> >> config BR2_TOOLCHAIN_BUILDROOT_UCLIBC >> bool "uClibc-ng" >> - depends on BR2_aarch64 || BR2_aarch64_be || BR2_arcle || BR2_arceb || \ >> - BR2_arm || BR2_armeb || \ >> - BR2_i386 || BR2_m68k || BR2_microblaze || \ >> - BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \ >> - BR2_or1k || BR2_powerpc || BR2_sh2a || BR2_sh4 || \ >> - BR2_sh4eb || BR2_sparc || BR2_xtensa || BR2_x86_64 >> + depends on BR2_aarch64 || BR2_aarch64_be || BR2_arcle || BR2_arceb || \ >> + BR2_arm || BR2_armeb || \ >> + BR2_i386 || BR2_m68k || BR2_microblaze || \ >> + BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \ >> + BR2_or1k || BR2_powerpc || BR2_RISCV_64 || \ >> + BR2_sh2a || BR2_sh4 || BR2_sh4eb || BR2_sparc || \ >> + BR2_xtensa || BR2_x86_64 >> select BR2_TOOLCHAIN_USES_UCLIBC >> help >> This option selects uClibc-ng as the C library for the >> >
On Sun, 10 May 2020 16:43:45 +0100 Mark Corbin <mark@dibsco.co.uk> wrote: > We can enable uclibc for RISC-V 64 bit now that it has been > bumped from v1.0.32 to v1.0.34. > > Uclibc has had basic support for RISC-V 64 bit since v1.0.31, but > shared library and TLS/NPTL support has only been available since > v1.0.33. > > This update has been tested using qemu_riscv64_virt_defconfig and > the Buildroot host QEMU. > > Signed-off-by: Mark Corbin <mark@dibsco.co.uk> > --- > Changes v1 -> v2: > - use BR2_RISCV_64 instead of (BR2_riscv && BR2_ARCH_IS_64) > (Thomas P) > --- > package/uclibc/Config.in | 1 + > toolchain/toolchain-buildroot/Config.in | 13 +++++++------ > 2 files changed, 8 insertions(+), 6 deletions(-) Applied to master, thanks. Romain: in the end, I didn't change the existing defconfigs. We usually don't change/check them when we update gcc, glibc or binutils for example. The compiler/C library is pretty much independent from the specific board, so I didn't think it was worth changing the HiFive Unleashed board to use glibc. Thomas
diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in index de2885bc92..f4d4f06462 100644 --- a/package/uclibc/Config.in +++ b/package/uclibc/Config.in @@ -101,6 +101,7 @@ config BR2_UCLIBC_TARGET_ARCH default "mips" if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el default "or1k" if BR2_or1k default "powerpc" if BR2_powerpc + default "riscv64" if BR2_RISCV_64 default "sh" if BR2_sh default "sparc" if BR2_sparc default "xtensa" if BR2_xtensa diff --git a/toolchain/toolchain-buildroot/Config.in b/toolchain/toolchain-buildroot/Config.in index 8c33b2b4dd..3b2da333a2 100644 --- a/toolchain/toolchain-buildroot/Config.in +++ b/toolchain/toolchain-buildroot/Config.in @@ -27,12 +27,13 @@ choice config BR2_TOOLCHAIN_BUILDROOT_UCLIBC bool "uClibc-ng" - depends on BR2_aarch64 || BR2_aarch64_be || BR2_arcle || BR2_arceb || \ - BR2_arm || BR2_armeb || \ - BR2_i386 || BR2_m68k || BR2_microblaze || \ - BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \ - BR2_or1k || BR2_powerpc || BR2_sh2a || BR2_sh4 || \ - BR2_sh4eb || BR2_sparc || BR2_xtensa || BR2_x86_64 + depends on BR2_aarch64 || BR2_aarch64_be || BR2_arcle || BR2_arceb || \ + BR2_arm || BR2_armeb || \ + BR2_i386 || BR2_m68k || BR2_microblaze || \ + BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \ + BR2_or1k || BR2_powerpc || BR2_RISCV_64 || \ + BR2_sh2a || BR2_sh4 || BR2_sh4eb || BR2_sparc || \ + BR2_xtensa || BR2_x86_64 select BR2_TOOLCHAIN_USES_UCLIBC help This option selects uClibc-ng as the C library for the
We can enable uclibc for RISC-V 64 bit now that it has been bumped from v1.0.32 to v1.0.34. Uclibc has had basic support for RISC-V 64 bit since v1.0.31, but shared library and TLS/NPTL support has only been available since v1.0.33. This update has been tested using qemu_riscv64_virt_defconfig and the Buildroot host QEMU. Signed-off-by: Mark Corbin <mark@dibsco.co.uk> --- Changes v1 -> v2: - use BR2_RISCV_64 instead of (BR2_riscv && BR2_ARCH_IS_64) (Thomas P) --- package/uclibc/Config.in | 1 + toolchain/toolchain-buildroot/Config.in | 13 +++++++------ 2 files changed, 8 insertions(+), 6 deletions(-)