| Message ID | 20200510154347.5711-2-mark@dibsco.co.uk |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/3] toolchain/toolchain-buildroot: enable uclibc for riscv64 | expand |
Le 10/05/2020 à 17:43, Mark Corbin a écrit : > Add a RISC-V 64-bit autobuild configuration for the internal > toolchain with uclibc. > > Signed-off-by: Mark Corbin <mark@dibsco.co.uk> > --- > Changes v1 -> v2: > - acknowledge that this only adds a uclibc autobuilder configuration > and not a generic one (Thomas P) > --- > .../config-fragments/autobuild/br-riscv64-full-internal.config | 2 ++ > 1 file changed, 2 insertions(+) > create mode 100644 support/config-fragments/autobuild/br-riscv64-full-internal.config > > diff --git a/support/config-fragments/autobuild/br-riscv64-full-internal.config b/support/config-fragments/autobuild/br-riscv64-full-internal.config > new file mode 100644 > index 0000000000..c729eb55e9 > --- /dev/null > +++ b/support/config-fragments/autobuild/br-riscv64-full-internal.config > @@ -0,0 +1,2 @@ > +BR2_riscv=y > +BR2_TOOLCHAIN_BUILDROOT_CXX=y > With the first patch fixed: Reviewed-by: Romain Naour <romain.naour@gmail.com> Best regards, Romain
On Sun, 10 May 2020 16:43:46 +0100 Mark Corbin <mark@dibsco.co.uk> wrote: > Add a RISC-V 64-bit autobuild configuration for the internal > toolchain with uclibc. > > Signed-off-by: Mark Corbin <mark@dibsco.co.uk> > --- > Changes v1 -> v2: > - acknowledge that this only adds a uclibc autobuilder configuration > and not a generic one (Thomas P) > --- > .../config-fragments/autobuild/br-riscv64-full-internal.config | 2 ++ > 1 file changed, 2 insertions(+) > create mode 100644 support/config-fragments/autobuild/br-riscv64-full-internal.config > > diff --git a/support/config-fragments/autobuild/br-riscv64-full-internal.config b/support/config-fragments/autobuild/br-riscv64-full-internal.config > new file mode 100644 > index 0000000000..c729eb55e9 > --- /dev/null > +++ b/support/config-fragments/autobuild/br-riscv64-full-internal.config > @@ -0,0 +1,2 @@ > +BR2_riscv=y > +BR2_TOOLCHAIN_BUILDROOT_CXX=y This was clearly not a "full" defconfig: you didn't had wchar/locale enabled, so I've added that. Also, you had forgotten to update the CSV file that lists the toolchain used by the autobuilders, support/config-fragments/autobuild/toolchain-configs.csv, so I did that. Applied with those changes. Thanks! Thomas
diff --git a/support/config-fragments/autobuild/br-riscv64-full-internal.config b/support/config-fragments/autobuild/br-riscv64-full-internal.config new file mode 100644 index 0000000000..c729eb55e9 --- /dev/null +++ b/support/config-fragments/autobuild/br-riscv64-full-internal.config @@ -0,0 +1,2 @@ +BR2_riscv=y +BR2_TOOLCHAIN_BUILDROOT_CXX=y
Add a RISC-V 64-bit autobuild configuration for the internal toolchain with uclibc. Signed-off-by: Mark Corbin <mark@dibsco.co.uk> --- Changes v1 -> v2: - acknowledge that this only adds a uclibc autobuilder configuration and not a generic one (Thomas P) --- .../config-fragments/autobuild/br-riscv64-full-internal.config | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 support/config-fragments/autobuild/br-riscv64-full-internal.config