[v3,10/22] package/x11r7/xkeyboard-config: switch to xorgproto

The new package xorgproto will combine and replace all current xproto_*
packages. For details read
https://lists.x.org/archives/xorg-announce/2018-February/002835.html

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/x11r7/xkeyboard-config/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Bernd, All,

On 2018-06-30 13:08 +0200, Bernd Kuhls spake thusly:
> The new package xorgproto will combine and replace all current xproto_*
> packages. For details read
> https://lists.x.org/archives/xorg-announce/2018-February/002835.html
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/x11r7/xkeyboard-config/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/x11r7/xkeyboard-config/Config.in b/package/x11r7/xkeyboard-config/Config.in
> index 5d1d6a72ed..c941742421 100644
> --- a/package/x11r7/xkeyboard-config/Config.in
> +++ b/package/x11r7/xkeyboard-config/Config.in
> @@ -3,7 +3,7 @@ config BR2_PACKAGE_XKEYBOARD_CONFIG
>  	# Runtime dependencies
>  	select BR2_PACKAGE_XAPP_XKBCOMP if BR2_PACKAGE_XORG7
>  	select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7
> -	select BR2_PACKAGE_XPROTO_XPROTO if BR2_PACKAGE_XORG7
> +	select BR2_PACKAGE_XORGPROTO if BR2_PACKAGE_XORG7

I'm always a bit warry about dependencies selected, that are not in the
.mk. Is it missing there?

But since that is not a problem your patch introduces:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

>  	help
>  	  keyboard configuration database for X
>  
> -- 
> 2.17.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

Hi Yann,

Am Mon, 02 Jul 2018 23:48:01 +0200 schrieb Yann E. MORIN:

>> --- a/package/x11r7/xkeyboard-config/Config.in
>> +++ b/package/x11r7/xkeyboard-config/Config.in
>> @@ -3,7 +3,7 @@ config BR2_PACKAGE_XKEYBOARD_CONFIG
>>  	# Runtime dependencies
>>  	select BR2_PACKAGE_XAPP_XKBCOMP if BR2_PACKAGE_XORG7
>>  	select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7
>> -	select BR2_PACKAGE_XPROTO_XPROTO if BR2_PACKAGE_XORG7
>> +	select BR2_PACKAGE_XORGPROTO if BR2_PACKAGE_XORG7
> 
> I'm always a bit warry about dependencies selected, that are not in the
> .mk. Is it missing there?

Afaics they are not missing in the.mk file because these packages are 
marked as runtime dependencies in Config.in.

Regards, Bernd

Bernd, All,

On 2018-07-13 21:55 +0200, Bernd Kuhls spake thusly:
> Am Mon, 02 Jul 2018 23:48:01 +0200 schrieb Yann E. MORIN:
> >> --- a/package/x11r7/xkeyboard-config/Config.in
> >> +++ b/package/x11r7/xkeyboard-config/Config.in
> >> @@ -3,7 +3,7 @@ config BR2_PACKAGE_XKEYBOARD_CONFIG
> >>  	# Runtime dependencies

Here ^^^

> >>  	select BR2_PACKAGE_XAPP_XKBCOMP if BR2_PACKAGE_XORG7
> >>  	select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7
> >> -	select BR2_PACKAGE_XPROTO_XPROTO if BR2_PACKAGE_XORG7
> >> +	select BR2_PACKAGE_XORGPROTO if BR2_PACKAGE_XORG7
> > 
> > I'm always a bit warry about dependencies selected, that are not in the
> > .mk. Is it missing there?
> 
> Afaics they are not missing in the.mk file because these packages are 
> marked as runtime dependencies in Config.in.

As noted above, yes, they are marlked "runtime dependencies".

However, I find it hard to believe that the xorg-proto, which supposedly
provides prototype information, is only a runtime dependency.

Similarly, I also find it hard to accept that xlib-libx11 is only a
runtime dependency.

I am afraid that only xapp-xkbcomp is actually a runtime dependency. The
rest are really build-time dependencies. /me thinks.

Regards,
Yann E. MORIN.

Am Sun, 15 Jul 2018 17:44:41 +0200 schrieb Yann E. MORIN:

> However, I find it hard to believe that the xorg-proto, which supposedly
> provides prototype information, is only a runtime dependency.
> 
> Similarly, I also find it hard to accept that xlib-libx11 is only a
> runtime dependency.
> 
> I am afraid that only xapp-xkbcomp is actually a runtime dependency. The
> rest are really build-time dependencies. /me thinks.

Hi Yann,

xkeyboard-config does not install any binary files, only keyboard 
configuration data. No part of this package links to libx11 during the 
build. These commits done by Thomas and Peter introduced the current 
Config.in content and provide background information about the x11 
runtime dependencies:

https://git.buildroot.net/buildroot/commit/?
id=dde83bc4639a7bf80ddd0d66b9ea3a8cc0157d65

https://git.buildroot.net/buildroot/commit/?
id=2ce67935e80b2ea6b24f22ebf1e810eae3dcefe0

Regards, Bernd