diff mbox series

[next] toolchain/buildroot: add comment for glibc NaN-2008 headers requirement

Message ID 20171125151902.502-1-yann.morin.1998@free.fr
State Accepted
Headers show
Series [next] toolchain/buildroot: add comment for glibc NaN-2008 headers requirement | expand

Commit Message

Yann E. MORIN Nov. 25, 2017, 3:19 p.m. UTC
Commit 4a5140ecf (toolchain/buildroot: glibc requires kernel headers >=
4.5 with NaN-2008) added a restriction on kernel hjeaders for glibc when
the architecture is using naN-2008.

However, such a restriction is usually associated to a comment explaining
the restiction, so the user knows what is happening.

That comment was forgotten in 4a5140ecf. Add it now.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Romain Naour <romain.naour@openwide.fr>
---
 toolchain/toolchain-buildroot/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Thomas Petazzoni Nov. 29, 2017, 9:17 p.m. UTC | #1
Hello,

On Sat, 25 Nov 2017 16:19:02 +0100, Yann E. MORIN wrote:
> Commit 4a5140ecf (toolchain/buildroot: glibc requires kernel headers >=
> 4.5 with NaN-2008) added a restriction on kernel hjeaders for glibc when
> the architecture is using naN-2008.
> 
> However, such a restriction is usually associated to a comment explaining
> the restiction, so the user knows what is happening.
> 
> That comment was forgotten in 4a5140ecf. Add it now.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Romain Naour <romain.naour@openwide.fr>
> ---
>  toolchain/toolchain-buildroot/Config.in | 5 +++++
>  1 file changed, 5 insertions(+)

Applied to next, thanks.

Thomas
diff mbox series

Patch

diff --git a/toolchain/toolchain-buildroot/Config.in b/toolchain/toolchain-buildroot/Config.in
index cbe2038a77..c624350cac 100644
--- a/toolchain/toolchain-buildroot/Config.in
+++ b/toolchain/toolchain-buildroot/Config.in
@@ -72,6 +72,11 @@  comment "glibc on powerpc64le needs a toolchain w/ headers >= 3.10"
 	depends on BR2_powerpc64le
 	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
 
+# Support for MIPS NAN2008 needs headers >= 4.5
+comment "glibc on MIPS w/ NAN2008 needs a toolchain w/ headers >= 4.5"
+	depends on BR2_MIPS_NAN_2008
+	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_5
+
 config BR2_TOOLCHAIN_BUILDROOT_MUSL
 	bool "musl"
 	depends on BR2_aarch64	  || BR2_arm     || BR2_armeb     || BR2_i386 || \