| Message ID | 20170409205128.11560-4-arnout@mind.be |
|---|---|
| State | Superseded |
| Headers | show |
Hello, On Sun, 9 Apr 2017 22:51:24 +0200, Arnout Vandecappelle (Essensium/Mind) wrote: > After running 'make randpackageconfig', and additional 'make oldconfig' > is done. However, this is redundant, since randpackageconfig already > does an olddefconfig. > > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Well, this oldconfig is not exactly right after randpackageconfig. We do this: - randpackageconfig - fixup_config() - oldconfig The fixup_config() function potentially does some changes to the .config file, and that's why we re-run oldconfig afterwards. This ensures that the build will not wait indefinitely while asking the user the value of a config option. Therefore, I wouldn't qualify this oldconfig as "redundant". Best regards, Thomas
On 10-04-17 10:25, Thomas Petazzoni wrote: > Hello, > > On Sun, 9 Apr 2017 22:51:24 +0200, Arnout Vandecappelle > (Essensium/Mind) wrote: >> After running 'make randpackageconfig', and additional 'make oldconfig' >> is done. However, this is redundant, since randpackageconfig already >> does an olddefconfig. >> >> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > > Well, this oldconfig is not exactly right after randpackageconfig. > > We do this: > > - randpackageconfig > - fixup_config() > - oldconfig > > The fixup_config() function potentially does some changes to > the .config file, and that's why we re-run oldconfig afterwards. This > ensures that the build will not wait indefinitely while asking the user > the value of a config option. D'oh, I missed that. Fortunately somebody reviews my crap! :-) So instead I'll replace it with olddefconfig and squash with the preceding patch, OK? Regards, Arnout > > Therefore, I wouldn't qualify this oldconfig as "redundant". > > Best regards, > > Thomas >
Hello, On Mon, 10 Apr 2017 10:46:54 +0200, Arnout Vandecappelle wrote: > So instead I'll replace it with olddefconfig and squash with the preceding > patch, OK? Yup, seen your v2, looks good to me. Thanks! Thomas
diff --git a/scripts/autobuild-run b/scripts/autobuild-run index 42276db..1df1ce0 100755 --- a/scripts/autobuild-run +++ b/scripts/autobuild-run @@ -586,12 +586,6 @@ def gen_config(**kwargs): if fixup_config(**kwargs): break - ret = subprocess.call(["yes '' 2>/dev/null| make O=%s -C %s oldconfig" % \ - (outputdir, srcdir)], shell=True, stdout=devnull, stderr=devnull) - if ret != 0: - log_write(log, "ERROR: cannot oldconfig") - return -1 - ret = subprocess.call(["make", "O=%s" % outputdir, "-C", srcdir, "savedefconfig"], stdout=devnull, stderr=devnull) if ret != 0:
After running 'make randpackageconfig', and additional 'make oldconfig' is done. However, this is redundant, since randpackageconfig already does an olddefconfig. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> --- scripts/autobuild-run | 6 ------ 1 file changed, 6 deletions(-)