[6/6] efl: remove broken JP2K loader

This option has been marked as broken since 2016.08. Since nobody
repaired it, we'll just remove it.

Since technically it was already removed in 2016.08, it's added to the
2016.08 section of the legacy menu.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Cc: Romain Naour <romain.naour@gmail.com>
Cc: Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
---
Romain, Gustavo, last chance to unbreak the package :-)
---
 Config.in.legacy      |  7 +++++++
 package/efl/Config.in | 10 ----------
 package/efl/efl.mk    |  8 +-------
 3 files changed, 8 insertions(+), 17 deletions(-)

On Tue, Mar 7, 2017 at 8:50 PM, Arnout Vandecappelle (Essensium/Mind)
<arnout@mind.be> wrote:
>
> This option has been marked as broken since 2016.08. Since nobody
> repaired it, we'll just remove it.
>
> Since technically it was already removed in 2016.08, it's added to the
> 2016.08 section of the legacy menu.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Romain Naour <romain.naour@gmail.com>
> Cc: Gustavo Sverzut Barbieri <barbieri@profusion.mobi>

Reviewed-By:  Gustavo Sverzut Barbieri <barbieri@profusion.mobi>

> ---
> Romain, Gustavo, last chance to unbreak the package :-)
> ---
>  Config.in.legacy      |  7 +++++++
>  package/efl/Config.in | 10 ----------
>  package/efl/efl.mk    |  8 +-------
>  3 files changed, 8 insertions(+), 17 deletions(-)
>
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 1f3d09b389..67f6e4e3a0 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -475,6 +475,13 @@ config BR2_LINUX_KERNEL_CUSTOM_LOCAL
>  ###############################################################################
>  comment "Legacy options removed in 2016.08"
>
> +config BR2_PACKAGE_EFL_JP2K
> +       bool "libevas jp2k loader has been removed"
> +       select BR2_LEGACY
> +         JP2K support in EFL requires openjpeg 1.x (libopenjpeg1.pc)
> +         while Buildroot only packages openjpeg 2.x. Therefore, the
> +         JP2K loader has been removed from EFL.
> +
>  config BR2_PACKAGE_SYSTEMD_COMPAT
>         bool "systemd compatibility libraries have been removed"
>         select BR2_LEGACY
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index 5e89af602c..960f2752c3 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -252,16 +252,6 @@ config BR2_PACKAGE_EFL_PNG
>           This enables the loader code that loads png files using
>           libpng.
>
> -# JP2K support require openjpeg 1.x (libopenjpeg1.pc) which is not
> -# available in Buildroot anymore.
> -config BR2_PACKAGE_EFL_JP2K
> -       bool "libevas jp2k loader"
> -       select BR2_PACKAGE_OPENJPEG
> -       depends on BROKEN # require openjpeg 1.x
> -       help
> -         This enables the loader code that loads jp2k files using
> -         openjpeg.
> -
>  config BR2_PACKAGE_EFL_JPEG
>         bool "libevas jpeg loader"
>         help
> diff --git a/package/efl/efl.mk b/package/efl/efl.mk
> index 1e54f72810..e0ec6d6bcc 100644
> --- a/package/efl/efl.mk
> +++ b/package/efl/efl.mk
> @@ -38,6 +38,7 @@ EFL_CONF_OPTS = \
>         --with-elm-prefs-cc=$(HOST_DIR)/usr/bin/elm_prefs_cc \
>         --with-elua=$(HOST_DIR)/usr/bin/elua \
>         --with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
> +       --disable-image-loader-jp2k \
>         --disable-lua-old \
>         --disable-poppler \
>         --disable-sdl \
> @@ -251,13 +252,6 @@ else
>  EFL_CONF_OPTS += --disable-image-loader-tiff
>  endif
>
> -ifeq ($(BR2_PACKAGE_EFL_JP2K),y)
> -EFL_CONF_OPTS += --enable-image-loader-jp2k=yes
> -EFL_DEPENDENCIES += openjpeg
> -else
> -EFL_CONF_OPTS += --disable-image-loader-jp2k
> -endif
> -
>  ifeq ($(BR2_PACKAGE_EFL_WEBP),y)
>  EFL_CONF_OPTS += --enable-image-loader-webp=yes
>  EFL_DEPENDENCIES += webp
> --
> 2.11.0
>

Hi Arnout, All,

Le 08/03/2017 à 13:49, Gustavo Sverzut Barbieri a écrit :
> On Tue, Mar 7, 2017 at 8:50 PM, Arnout Vandecappelle (Essensium/Mind)
> <arnout@mind.be> wrote:
>>
>> This option has been marked as broken since 2016.08. Since nobody
>> repaired it, we'll just remove it.
>>
>> Since technically it was already removed in 2016.08, it's added to the
>> 2016.08 section of the legacy menu.
>>
>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>> Cc: Romain Naour <romain.naour@gmail.com>
>> Cc: Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
> 
> Reviewed-By:  Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
> 
>> ---
>> Romain, Gustavo, last chance to unbreak the package :-)

I reported the issue upstream, see:

https://phab.enlightenment.org/T5255

At the time when I tested this option openjpeg was still at 1.x version but it
was bumped to 2.x after that.

efl 1.19 will be released soon (1.19-beta2 right now) it may be fixed before the
official release.

Otherwise:
Acked-by: Romain Naour <romain.naour@gmail.com>

Because it's still broken :-/

Best regards,
Romain

Hello,

On Wed, 8 Mar 2017 00:50:54 +0100, Arnout Vandecappelle
(Essensium/Mind) wrote:
> This option has been marked as broken since 2016.08. Since nobody
> repaired it, we'll just remove it.
> 
> Since technically it was already removed in 2016.08, it's added to the
> 2016.08 section of the legacy menu.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Romain Naour <romain.naour@gmail.com>
> Cc: Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
> ---
> Romain, Gustavo, last chance to unbreak the package :-)
> ---
>  Config.in.legacy      |  7 +++++++
>  package/efl/Config.in | 10 ----------
>  package/efl/efl.mk    |  8 +-------
>  3 files changed, 8 insertions(+), 17 deletions(-)

Applied to master, thanks.

Thomas