| Message ID | 20170108222011.3839-2-romain.naour@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello, On Sun, 8 Jan 2017 23:20:11 +0100, Romain Naour wrote: > The legacy entry was missing in commit [1]. > > [1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4 > > Signed-off-by: Romain Naour <romain.naour@gmail.com> > Cc: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > Config.in.legacy | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Config.in.legacy b/Config.in.legacy > index 20445b8..8dfbbc8 100644 > --- a/Config.in.legacy > +++ b/Config.in.legacy > @@ -145,6 +145,13 @@ endif > ############################################################################### > comment "Legacy options removed in 2017.02" > > +config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX > + bool "xserver AIGLX Extension removed" > + depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17 > + select BR2_LEGACY > + help > + The xserver AIGLX Extension has been removed in 1.19.0 release. Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option defined in two different places, with two different prompts. Do we really want to do this? Cc'ing Arnout and Yann, to get their insights. Thanks, Thomas
On 24-01-17 11:33, Thomas Petazzoni wrote: > Hello, > > On Sun, 8 Jan 2017 23:20:11 +0100, Romain Naour wrote: >> The legacy entry was missing in commit [1]. >> >> [1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4 >> >> Signed-off-by: Romain Naour <romain.naour@gmail.com> >> Cc: Bernd Kuhls <bernd.kuhls@t-online.de> >> --- >> Config.in.legacy | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Config.in.legacy b/Config.in.legacy >> index 20445b8..8dfbbc8 100644 >> --- a/Config.in.legacy >> +++ b/Config.in.legacy >> @@ -145,6 +145,13 @@ endif >> ############################################################################### >> comment "Legacy options removed in 2017.02" >> >> +config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX >> + bool "xserver AIGLX Extension removed" >> + depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17 >> + select BR2_LEGACY >> + help >> + The xserver AIGLX Extension has been removed in 1.19.0 release. > > Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option > defined in two different places, with two different prompts. Do we > really want to do this? No we don't. We certainly don't want that changing some option (the server version) suddenly creates a legacy option. Also, legacy is not needed here: it never was possible (in a released buildroot) to select this option for v1.19.0+. Regards, Arnout > > Cc'ing Arnout and Yann, to get their insights. > > Thanks, > > Thomas >
Hi Arnout, Thomas, All, Le 25/01/2017 à 11:56, Arnout Vandecappelle a écrit : > > On 24-01-17 11:33, Thomas Petazzoni wrote: >> Hello, >> >> On Sun, 8 Jan 2017 23:20:11 +0100, Romain Naour wrote: >>> The legacy entry was missing in commit [1]. >>> >>> [1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4 >>> >>> Signed-off-by: Romain Naour <romain.naour@gmail.com> >>> Cc: Bernd Kuhls <bernd.kuhls@t-online.de> >>> --- >>> Config.in.legacy | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/Config.in.legacy b/Config.in.legacy >>> index 20445b8..8dfbbc8 100644 >>> --- a/Config.in.legacy >>> +++ b/Config.in.legacy >>> @@ -145,6 +145,13 @@ endif >>> ############################################################################### >>> comment "Legacy options removed in 2017.02" >>> >>> +config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX >>> + bool "xserver AIGLX Extension removed" >>> + depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17 >>> + select BR2_LEGACY >>> + help >>> + The xserver AIGLX Extension has been removed in 1.19.0 release. >> >> Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option >> defined in two different places, with two different prompts. Do we >> really want to do this? > > No we don't. We certainly don't want that changing some option (the server > version) suddenly creates a legacy option. Indeed it's annoying... > > Also, legacy is not needed here: it never was possible (in a released > buildroot) to select this option for v1.19.0+. ...but the xserver package is special since we support several versions. If only one version was used, this option would be removed with the bump to 1.19.0 and a legacy entry added. If we previously used the latest xserver version (1.18.4) in 2016.11 with BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX selected, this option will be silently removed from the defconfig with 2017.02. How we should handle new/old options when a package has several version available ? Best regards, Romain > > Regards, > Arnout > >> >> Cc'ing Arnout and Yann, to get their insights. >> >> Thanks, >> >> Thomas >> >
On 25-01-17 20:29, Romain Naour wrote: > Hi Arnout, Thomas, All, > > Le 25/01/2017 à 11:56, Arnout Vandecappelle a écrit : >> >> On 24-01-17 11:33, Thomas Petazzoni wrote: >>> Hello, >>> >>> On Sun, 8 Jan 2017 23:20:11 +0100, Romain Naour wrote: >>>> The legacy entry was missing in commit [1]. >>>> >>>> [1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4 >>>> >>>> Signed-off-by: Romain Naour <romain.naour@gmail.com> >>>> Cc: Bernd Kuhls <bernd.kuhls@t-online.de> >>>> --- >>>> Config.in.legacy | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/Config.in.legacy b/Config.in.legacy >>>> index 20445b8..8dfbbc8 100644 >>>> --- a/Config.in.legacy >>>> +++ b/Config.in.legacy >>>> @@ -145,6 +145,13 @@ endif >>>> ############################################################################### >>>> comment "Legacy options removed in 2017.02" >>>> >>>> +config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX >>>> + bool "xserver AIGLX Extension removed" >>>> + depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17 >>>> + select BR2_LEGACY >>>> + help >>>> + The xserver AIGLX Extension has been removed in 1.19.0 release. >>> >>> Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option >>> defined in two different places, with two different prompts. Do we >>> really want to do this? >> >> No we don't. We certainly don't want that changing some option (the server >> version) suddenly creates a legacy option. > > Indeed it's annoying... > >> >> Also, legacy is not needed here: it never was possible (in a released >> buildroot) to select this option for v1.19.0+. > > ...but the xserver package is special since we support several versions. > If only one version was used, this option would be removed with the bump to > 1.19.0 and a legacy entry added. > > If we previously used the latest xserver version (1.18.4) in 2016.11 with > BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX selected, this option will be silently > removed from the defconfig with 2017.02. > > How we should handle new/old options when a package has several version available ? Well, normally the BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_18 legacy entry would force the user to select a different version, and it would be obvious that aiglx disappears in v1.19. However, we didn't add a legacy entry for v1.18... Regards, Arnout > > Best regards, > Romain > >> >> Regards, >> Arnout >> >>> >>> Cc'ing Arnout and Yann, to get their insights. >>> >>> Thanks, >>> >>> Thomas >>> >> >
On 2017-01-25 11:56 +0100, Arnout Vandecappelle spake thusly: > > > On 24-01-17 11:33, Thomas Petazzoni wrote: > > Hello, > > > > On Sun, 8 Jan 2017 23:20:11 +0100, Romain Naour wrote: > >> The legacy entry was missing in commit [1]. > >> > >> [1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4 > >> > >> Signed-off-by: Romain Naour <romain.naour@gmail.com> > >> Cc: Bernd Kuhls <bernd.kuhls@t-online.de> > >> --- > >> Config.in.legacy | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/Config.in.legacy b/Config.in.legacy > >> index 20445b8..8dfbbc8 100644 > >> --- a/Config.in.legacy > >> +++ b/Config.in.legacy > >> @@ -145,6 +145,13 @@ endif > >> ############################################################################### > >> comment "Legacy options removed in 2017.02" > >> > >> +config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX > >> + bool "xserver AIGLX Extension removed" > >> + depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17 > >> + select BR2_LEGACY > >> + help > >> + The xserver AIGLX Extension has been removed in 1.19.0 release. > > > > Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option > > defined in two different places, with two different prompts. Do we > > really want to do this? > > No we don't. We certainly don't want that changing some option (the server > version) suddenly creates a legacy option. My stake on this: - we must add a legacy entry for 1.18 - we must not add a legacy entry for AIGLX, because it is not yet legacy. It will turn legacy when the last xserver version we have that support AIGLX is dropped. For now, it is just an package option that is only available with some versions (1.17 and 1.14). > Also, legacy is not needed here: it never was possible (in a released > buildroot) to select this option for v1.19.0+. Agreed. Regards, Yann E. MORIN.
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: Hi, >> > Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option >> > defined in two different places, with two different prompts. Do we >> > really want to do this? >> >> No we don't. We certainly don't want that changing some option (the server >> version) suddenly creates a legacy option. > My stake on this: > - we must add a legacy entry for 1.18 Ok. > - we must not add a legacy entry for AIGLX, because it is not yet > legacy. It will turn legacy when the last xserver version we have > that support AIGLX is dropped. For now, it is just an package option > that is only available with some versions (1.17 and 1.14). As I understood it, AIGLX support is now unconditionally enabled: https://cgit.freedesktop.org/xorg/xserver/commit/?id=501d8e2beb337e072c93c9310fcd927a099b9c3b So the legacy option would just state that this option is now unconditionally enabled. I'm not sure how helpful that is. The user is presumably already notified that the server version has changed (E.G. from 1.14/1.17 to 1.19+).
diff --git a/Config.in.legacy b/Config.in.legacy index 20445b8..8dfbbc8 100644 --- a/Config.in.legacy +++ b/Config.in.legacy @@ -145,6 +145,13 @@ endif ############################################################################### comment "Legacy options removed in 2017.02" +config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX + bool "xserver AIGLX Extension removed" + depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17 + select BR2_LEGACY + help + The xserver AIGLX Extension has been removed in 1.19.0 release. + config BR2_PACKAGE_PERL_DB_FILE bool "perl-db-file removed" select BR2_LEGACY
The legacy entry was missing in commit [1]. [1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4 Signed-off-by: Romain Naour <romain.naour@gmail.com> Cc: Bernd Kuhls <bernd.kuhls@t-online.de> --- Config.in.legacy | 7 +++++++ 1 file changed, 7 insertions(+)