diff mbox

dialog: bump to version 1.2-20150125

Message ID 20150221140752.3aa8449b@free-electrons.com
State Not Applicable
Headers show

Commit Message

Thomas Petazzoni Feb. 21, 2015, 1:07 p.m. UTC 
Dear Gustavo Zacarias,

On Sat, 21 Feb 2015 08:52:27 -0300, Gustavo Zacarias wrote:
> And drop thread requirement, it's really not necessary.
> For python-dialog that was already inherent in python itself.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Applied to next, thanks. Interestingly, it's you who added this thread
dependency because dialog needs MMU. And Peter applied the patch. See:

commit 9d9d842d871b8645f70c3a90f59f8e2e09935656
Author: Gustavo Zacarias <gustavo@zacarias.com.ar>
Date:   Fri Dec 28 00:59:00 2012 +0000

    dialog: needs mmu
    
    Fixes
    http://autobuild.buildroot.net/results/b673ef6d6315dc5df77e000199a63f90904829d5
    
    Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
    Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>


Thomas

Comments

Gustavo Zacarias Feb. 21, 2015, 1:17 p.m. UTC | #1 
On 02/21/2015 10:07 AM, Thomas Petazzoni wrote:

> Dear Gustavo Zacarias,
> 
> On Sat, 21 Feb 2015 08:52:27 -0300, Gustavo Zacarias wrote:
>> And drop thread requirement, it's really not necessary.
>> For python-dialog that was already inherent in python itself.
>>
>> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> 
> Applied to next, thanks. Interestingly, it's you who added this thread
> dependency because dialog needs MMU. And Peter applied the patch. See:

Yes, i find it was odd as well and backtracked on it since tests say
it's not required at all (and the TODO for dialog says "we want threads
eventually" which is a clear sign heh).
Regards.
diff mbox

Patch

diff --git a/package/dialog/Config.in b/package/dialog/Config.in
index 9d3462e..db5197f 100644
--- a/package/dialog/Config.in
+++ b/package/dialog/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_DIALOG
        bool "dialog"
+       depends on BR2_TOOLCHAIN_HAS_THREADS # fork()
        select BR2_PACKAGE_NCURSES
        select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
        help